Meme button in Phabricator text area bar doesn't work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• MZMcBride
	Oct 25 2014, 10:02 PM

Description

There's a very stoic-looking face in the toolbar above any description or comment text area in Phabricator. It's labeled "Meme" and when I click this button, I receive an error message:

Access Denied: Application Restricted Application
You do not have permission to view this object.
Users with the "Can View" capability:
Administrators can take this action.

This software interaction seems pretty user-hostile. If the meme functionality is disabled/unavailable, we should either hide or disable the button in the toolbar. We should not offer a useless button and throw a scary warning message.

Related Objects

Mentioned In: T73245: Write Quips extension for Phabricator

Event Timeline

• MZMcBride created this task.Oct 25 2014, 10:02 PM

• MZMcBride raised the priority of this task from to Needs Triage.

• MZMcBride updated the task description. (Show Details)

• MZMcBride added a project: Phabricator.

• MZMcBride changed Security from none to None.

• MZMcBride subscribed.

Qgil renamed this task from Meme button in Phabricator text area bar doesn't work to Enable memes (Macro).Oct 26 2014, 6:33 AM

Qgil triaged this task as Low priority.

The solution requires to decide whether we want to enable Macro so users can post memes, or not.

You can play with this feature in phab-01:

https://phab-01.wmflabs.org/macro/

https://phab-01.wmflabs.org/T29

If memes aren't enabled, why do I see a memes button in the toolbar? That seems like the bug here.

I don't really want to make this task about enabling memes as I don't know what that means or why anyone would ever want/need such a feature in an issue tracker.

Qgil added a project: Phabricator (Upstream).Oct 26 2014, 2:24 PM

zeljkofilipin subscribed.Oct 27 2014, 4:02 PM

For the records, https://secure.phabricator.com/applications/view/PhabricatorMacroApplication/ currently says that it's installed and its settings are

Can Use Application: Public
Can Configure Application: Administrators
Can Manage Macros: Administrators

how about an admin just enables it for a day or something so we can see what it would do. then we'd know better if we like to have it or not

People can just do that in https://phab-01.wmflabs.org/macro/

Who knows, maybe someone wants to port all the MediaWiki maintenance templates. ;) More seriously, maybe there is indeed a productive use for this feature. Maybe. And maybe the use of memes can be open while the submissions of new memes could be restricted / moderated in order to avoid an excess of silliness.

Dzahn unsubscribed.Oct 29 2014, 10:10 PM

Quiddity subscribed.Nov 9 2014, 10:04 PM

I fixed the root issue (button appearing if you don't have access to the application) in the upstream (see https://secure.phabricator.com/D10900).

Thank you @epriestley! Resolving here now. We should sync with upstream in less than a month.

zeljkofilipin unsubscribed.Nov 26 2014, 9:44 AM

Dzahn mentioned this in T73245: Write Quips extension for Phabricator.Nov 26 2014, 10:30 PM

Danny_B added a project: Upstream.May 23 2016, 6:06 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 23 2016, 6:06 PM

Meme button in Phabricator text area bar doesn't workClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Meme button in Phabricator text area bar doesn't work
Closed, ResolvedPublic
Actions