Investigation: "other languages" box shows older revision unless one purges page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Feb 26 2015, 5:39 PM

Description

this happens on wikidata, as well as master.

I have an item with spanish description "Film von Diao Yinan (2014)"

edit the description to remove the year

click save

undo the edit (thus re-adding the year to the spanish description)

I am back on the item page, but the spanish description shows the previous version before undo. (e.g. no year)

If I click edit, then it shows the correct version.

Details

Subject	Repo	Branch	Lines +/-
Un-deprecate $revisionId = 0 in EntityRevisionLookup	mediawiki/extensions/Wikibase	master	+30 -18
[DNM] Disallow EntityRevision to represent current revision	mediawiki/extensions/Wikibase	master	+6 -6
Fix revision id used for EntityTermsView placeholder	mediawiki/extensions/Wikibase	master	+10 -6

Customize query in gerrit

Related Objects

Mentioned In: rMEXT8ecd2bb42a1d: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase…
rEWBA3d5e6380e520: Fix revision id used for EntityTermsView placeholder
T95407: create browser tests to check editing and display of terms in EntityTermView

Event Timeline

aude created this task.Feb 26 2015, 5:39 PM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.

aude subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2015, 5:39 PM

if i reload the page, like http://wikidata-repo/wiki/Q139?g it is still wrong.

the problem appears confined to the "other languages" / term box. If I edit then undo the english description (my user language), it shows correctly above the term box but wrong in the term box.

if i undo a site link or statement edit, also no problem.

purge the page and i see the correct description

Lydia_Pintscher triaged this task as High priority.Mar 2 2015, 1:55 PM

Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.

Lydia_Pintscher added a subscriber: daniel.

Lydia_Pintscher added subscribers: thiemowmde, JanZerebecki.

Lydia_Pintscher subscribed.

this still happens on master

here I simply added a label for english:

the label does not show in the term box but is displayed in the h1 element.

as we suspected, the term box is using older revision.

Tobi_WMDE_SW moved this task from needs discussion or investigation to ready to go on the Wikidata board.Mar 30 2015, 2:28 PM

seems to happen always, and not just for undo

Tobi_WMDE_SW renamed this task from "other languages" box shows older revision unless one purges page to Investigation: "other languages" box shows older revision unless one purges page.Apr 7 2015, 1:32 PM

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-04-07.

aude claimed this task.Apr 7 2015, 6:38 PM

aude moved this task from Backlog to Doing on the Wikidata-Sprint-2015-04-07 board.

Change 202466 had a related patch set uploaded (by Aude):
Fix revision id used for EntityTermsView placeholder

https://gerrit.wikimedia.org/r/202466

gerritbot added a project: Patch-For-Review.Apr 7 2015, 6:45 PM

aude moved this task from Doing to Review on the Wikidata-Sprint-2015-04-07 board.Apr 7 2015, 6:46 PM

aude mentioned this in T95407: create browser tests to check editing and display of terms in EntityTermView.Apr 8 2015, 10:18 AM

Change 202723 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Un-deprecate $revisionId = 0 in EntityRevisionLookup

https://gerrit.wikimedia.org/r/202723

Change 203045 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[DNM] Disallow EntityRevision to represent current revision

https://gerrit.wikimedia.org/r/203045

Change 202466 merged by jenkins-bot:
Fix revision id used for EntityTermsView placeholder

https://gerrit.wikimedia.org/r/202466

aude mentioned this in rEWBA3d5e6380e520: Fix revision id used for EntityTermsView placeholder.Apr 10 2015, 2:27 PM

Diffusion mentioned this in rMEXT8ecd2bb42a1d: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 10 2015, 2:27 PM

Lydia_Pintscher closed this task as Resolved.Apr 10 2015, 2:37 PM

Lydia_Pintscher moved this task from Review to Done on the Wikidata-Sprint-2015-04-07 board.

Change 203045 abandoned by Thiemo Mättig (WMDE):
[DNM] Disallow EntityRevision to represent current revision