Page MenuHomePhabricator
Create Task
Maniphest T91167

LivePreview does not show Preview header nor preview warning
Closed, ResolvedPublic
Actions

Description

A normal page preview has:
h2: Preview
This is only a preview; your changes have not yet been saved! → Go to editing area

But a Livepreview does not. We might want to consider adding it..

Details

SubjectRepoBranchLines +/-
LivePreview: Show parse warnings and preview header/warningmediawiki/coremaster+29 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Feb 28 2015, 2:40 PM
TheDJ raised the priority of this task from to Lowest.
TheDJ updated the task description. (Show Details)
TheDJ added projects: JavaScript, MediaWiki-Page-editing.
TheDJ subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2015, 2:40 PM
TheDJ added a parent task: T41272: Bugs in "Live preview" feature (tracking).Feb 28 2015, 2:40 PM
gerritbot subscribed.Mar 10 2015, 9:29 PM

Change 195695 had a related patch set uploaded (by TheDJ):
ApiParse: Support previewing section=new

https://gerrit.wikimedia.org/r/195695

gerritbot added a project: Patch-For-Review.Mar 10 2015, 9:29 PM
TheDJ removed a project: Patch-For-Review.Mar 10 2015, 10:40 PM
TheDJ set Security to None.
TheDJ removed a subscriber: gerritbot.
Ricordisamoa subscribed.Mar 10 2015, 10:59 PM
MGChecker moved this task from Backlog to Live preview on the MediaWiki-Page-editing board.Nov 15 2018, 10:23 PM
Pcj subscribed.Nov 21 2018, 10:52 PM

It should be noted this also prevents display of warnings passed from Scribunto using mw.addWarning() meaning warnings shown by module authors won't show up in preview.

TheDJ added a comment.Nov 22 2018, 9:32 AM

Note to self, parsewarnings of the apiparse output. https://github.com/wikimedia/mediawiki/blob/master/includes/EditPage.php#L3993

gerritbot added a comment.May 19 2020, 11:56 AM

Change 597262 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] warnings and header for livepreview

https://gerrit.wikimedia.org/r/597262

gerritbot added a project: Patch-For-Review.May 19 2020, 11:56 AM
gerritbot added a comment.Oct 15 2020, 3:15 PM

Change 597262 merged by jenkins-bot:
[mediawiki/core@master] LivePreview: Show parse warnings and preview header/warning

https://gerrit.wikimedia.org/r/597262

matmarex closed this task as Resolved.Oct 15 2020, 3:43 PM
matmarex assigned this task to TheDJ.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits