Page MenuHomePhabricator

Provide dh-virtualenv 0.9 package on apt.wikimedia.org Precise and Trusty distributions
Closed, ResolvedPublic

Description

I am packaging Zuul for Ubuntu Precise T48552: Create a Debian package for Zuul. Since lot of dependencies are missing I am going using dh-virtualenv to have them shipped in the zuul.deb package.

I could use the package 0.9 which has just been released on my request.

Result is available at: http://people.wikimedia.org/~hashar/debs/dh-virtualenv/

I have create a tarball of the whole directory for easy retrieval http://people.wikimedia.org/~hashar/debs/dh-virtualenv.tar.gz

The new version is in Debian mentors queue, pending review or in experimental for the brave soul ( https://packages.qa.debian.org/d/dh-virtualenv.html ).

Event Timeline

hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar added a project: acl*sre-team.
hashar subscribed.
hashar renamed this task from Provide dh-virtualenv package on apt.wikimedia.org Precise distribution to Provide dh-virtualenv 0.8 package on apt.wikimedia.org Precise distribution.Mar 5 2015, 2:13 PM
hashar updated the task description. (Show Details)
hashar set Security to None.

I originally used v0.7, I need a snapshot of 0.9. Got it from github repository directly.

I have requested upstream to tag a new version with https://github.com/spotify/dh-virtualenv/issues/78

coren triaged this task as Medium priority.Mar 5 2015, 4:33 PM
coren subscribed.
hashar renamed this task from Provide dh-virtualenv 0.8 package on apt.wikimedia.org Precise distribution to Provide dh-virtualenv 0.9 dev package on apt.wikimedia.org Precise distribution.Mar 6 2015, 2:14 PM
hashar updated the task description. (Show Details)
hashar renamed this task from Provide dh-virtualenv 0.9 dev package on apt.wikimedia.org Precise distribution to Provide dh-virtualenv 0.9 package on apt.wikimedia.org Precise distribution.Mar 9 2015, 11:54 AM
hashar updated the task description. (Show Details)
hashar renamed this task from Provide dh-virtualenv 0.9 package on apt.wikimedia.org Precise distribution to Provide dh-virtualenv 0.9 package on apt.wikimedia.org Precise and Trusty distributions.EditedMar 13 2015, 9:53 PM
hashar updated the task description. (Show Details)

I actually need it for our three distributions: Precise, Trusty and Jessie :)

Hello, tried rebuilding the package and I ran into a couple of problems with pdebuilder
In order to make it easier to use pbuilder, could you please add a clean target in debian/rules ? I used:

clean:
        dh_testdir
        dh_auto_clean
        dh_clean

which is the standard clean target but avoiding the calling of dh --with python2 --with sphinxdoc. Those 2 "withs" create unmet build dependencies to python-sphinxdoc and python-mock. debian/rules clean is run outside of the chroot so pbuilder can not be used to satisfy those build dependencies and as a result they either need to be installed outside the chroot (we don't want that) or the above trick to be used.

In other news, the package is quite fine and I like it, although let's avoid it for production packages we built and confine it to labs. Building (with my change) for all 3 distributions and uploading shortly

While doing git-buildpackage I just found:

W: dh_python2:479: Please add dh-python package to Build-Depends

I have added it. Note that on Jessie python3 depends on dh-python so the command works just fine but the warning remembers us to make the deps explicit.

It seems the clean target does not look at Build-Indep so we could add python-mock and python-sphinx there, but then they might not be arch independent (they each have arch: all).

Packages rebuilt and uploaded on apt.wikimedia.org. For jessie the package has been uploaded on the backports component while for trusty and precise on the main component.

I'd like to point one thing very clearly about this. I would hate to see packages for production packaged with dh-virtualenv. While it is a great tool for building debs used to deploy an application (btw, using debs is not the best possible deployment method) it should not be used to avoid correctly packaging software for production.