Page MenuHomePhabricator

Move GET/POST/COOKIE/SESSION assumptions into the UI controller
Open, Needs TriagePublic

Description

Don't assume that data is coming in through GPC globals, this harvesting should be done at the top level (normally, the UI controller), and the adapter should only deal with a flat key/value data structure.

This will help reduce orphan slaying and standalone special-casing.

Keep in mind that each adapter has its own order_id preference, write tests to ensure this is not jiggled during refactor.

Event Timeline

awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight subscribed.

Change 190359 had a related patch set uploaded (by Awight):
WIP move param harvesting to the form layer

https://gerrit.wikimedia.org/r/190359

Change 190359 abandoned by Awight:
WIP move param harvesting to the form layer

https://gerrit.wikimedia.org/r/190359