Page MenuHomePhabricator

Leave blank values in Silverpop file blank, not NULL
Closed, ResolvedPublic1 Estimated Story Points

Description

Urgency: low

Impact to fundraiser: extra work for Caitlin in Silverpop, opens up opportunity for user error & bad donor experience.

This is a follow up on card #1341, in which I asked for all NULL values to be removed from the first name and last name columns in our Silverpop import. Garfield was a recipient of one of our emails on Friday, and was addressed, “Dear NULL”, which is what made us realize there are still 275 contacts in the database with NULL first names — and some of these, unlike Garfield, actually have donated.

We have a workaround in Silverpop, but it’s a manual process, so it would be nice if we could ensure once and for all that empty fields are simply blank instead of NULL.

Event Timeline

CCogdill_WMF assigned this task to atgo.
CCogdill_WMF raised the priority of this task from to Needs Triage.
CCogdill_WMF updated the task description. (Show Details)
CCogdill_WMF subscribed.
atgo set Security to None.

This seems to be corrected for first and last names. Are null values in other fields still a problem, or can we close this, @CCogdill_WMF ?

Preferably any blank field in a field type we normally use would be left
blank; it just adds a little more complication to Silverpop queries when we
have to sort for is blank OR is NULL.

The fields impacted by these queries are:

  • latest_donation_date
  • latest_currnecy
  • latest_native_amount
  • highest_usd_amount

It would be nice if this would apply to those fields, too, but it's not
hugely important.

Oops, I'd totally forgotten about this ticket! I guess blank and NULL aren't actually the same from Silverpop's point of view. I'll fix the fields you listed above.

Change 369430 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/tools@master] Final export should have blanks instead of NULL

https://gerrit.wikimedia.org/r/369430

Ejegg set the point value for this task to 1.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Navel Warfare board.

Change 369430 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] Final export should have blanks instead of NULL

https://gerrit.wikimedia.org/r/369430

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Navel Warfare board.

OK @CCogdill_WMF, we just deployed something to fix empty dates. I think after tonight's export you'll be able to get rid of the funky rules.

Great, thanks! I'll purge the data from that field.

Le mar. 1 août 2017 à 15:21, Ejegg <no-reply@phabricator.wikimedia.org> a
écrit :

Ejegg added a comment.

OK @CCogdill_WMF https://phabricator.wikimedia.org/p/CCogdill_WMF/, we
just deployed something to fix empty dates. I think after tonight's export
you'll be able to get rid of the funky rules.

*TASK DETAIL*
https://phabricator.wikimedia.org/T91692

*EMAIL PREFERENCES*
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

*To: *Ejegg
*Cc: *gerritbot, Ejegg, CCogdill_WMF, Aklapper, Lordiis, Adik2382,
Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, DStrine