Page MenuHomePhabricator
Create Task
Maniphest T92431

white gap next to wikibase-sitelinkgroupview-heading-container in site link edit mode
Closed, ResolvedPublic
Actions

Description

The heading should extend the full width of it's container sitelinkgroupview elements, instead of leaving a white gap.

pasted_file (367×411 px, 41 KB)

The problem appears to be due to use of "width: auto" on .wikibase-sitelinkgroupview .wikibase-sitelinkgroupview-heading-container > .wikibase-toolbar-container

Details

SubjectRepoBranchLines +/-
Fix issue of white space in sitelinkgroupview headingmediawiki/extensions/Wikibasemaster+2 -3
Fix issue of white space in sitelinkgroupview headingmediawiki/extensions/Wikibasemaster+6 -4
Fix issue of white space in sitelinkgroupview headingmediawiki/extensions/Wikibasemaster+0 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
InvalidNoneT75654 Redesign Wikidata header
ResolvedthiemowmdeT92431 white gap next to wikibase-sitelinkgroupview-heading-container in site link edit mode
· · ·

Event Timeline

aude created this task.Mar 11 2015, 7:06 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2015, 7:06 PM
Lydia_Pintscher added a parent task: T75654: Redesign Wikidata header.Mar 11 2015, 7:07 PM
gerritbot subscribed.Mar 11 2015, 7:08 PM

Change 195986 had a related patch set uploaded (by Aude):
Fix issue of white space in sitelinkgroupview heading

https://gerrit.wikimedia.org/r/195986

gerritbot added a project: Patch-For-Review.Mar 11 2015, 7:08 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 12 2015, 11:30 AM
Lydia_Pintscher triaged this task as Medium priority.Mar 13 2015, 10:30 AM
Lydia_Pintscher set Security to None.
thiemowmde subscribed.Mar 16 2015, 7:32 PM

The removal of the width: auto property does that in my Fixefox:

Screenshot_from_2015-03-16_20:28:05.png (165×895 px, 32 KB)

Reason is that the heading is formatted as two table cells. But I can't find the corresponding display: table. Both table-cells are left-aligned. But they do not contain enough text to make the table fill the available width.

gerritbot added a comment.Mar 16 2015, 7:48 PM

Change 197121 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix issue of white space in sitelinkgroupview heading

https://gerrit.wikimedia.org/r/197121

Lydia_Pintscher added a project: § Wikidata-Sprint-2015-03-11.Mar 17 2015, 11:11 AM
Lydia_Pintscher moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-11 board.
Lydia_Pintscher subscribed.
Lydia_Pintscher assigned this task to thiemowmde.Mar 20 2015, 1:06 PM
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-24.Mar 24 2015, 3:07 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-24 board.Mar 24 2015, 3:10 PM
gerritbot added a comment.Mar 30 2015, 12:31 PM

Change 200543 had a related patch set uploaded (by Adrian Lang):
Fix issue of white space in sitelinkgroupview heading

https://gerrit.wikimedia.org/r/200543

gerritbot added a comment.Mar 30 2015, 1:09 PM

Change 195986 abandoned by Aude:
Fix issue of white space in sitelinkgroupview heading

https://gerrit.wikimedia.org/r/195986

gerritbot added a comment.Apr 1 2015, 1:29 PM

Change 197121 abandoned by Thiemo Mättig (WMDE):
Fix issue of white space in sitelinkgroupview heading

Reason:
Overcomplicated, replaced by Ic7c5e63.

https://gerrit.wikimedia.org/r/197121

thiemowmde closed this task as Resolved.Apr 1 2015, 1:37 PM
gerritbot added a comment.Apr 1 2015, 1:45 PM

Change 200543 merged by jenkins-bot:
Fix issue of white space in sitelinkgroupview heading

https://gerrit.wikimedia.org/r/200543

• adrianheine mentioned this in rMEXTdb45296835c2: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 1 2015, 1:45 PM
thiemowmde mentioned this in rEWBA938453aa2b7d: Fix issue of white space in sitelinkgroupview heading.Apr 1 2015, 1:45 PM
Tobi_WMDE_SW moved this task from Review to Done on the § Wikidata-Sprint-2015-03-24 board.Apr 1 2015, 1:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits