Page MenuHomePhabricator
Create Task
Maniphest T92525

No longer possible to convert an auto-numbered link to one with a label
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It is no longer possible to convert an auto-numbered link to one with a label. The code is still there in MWLinkNodeInspector, but the action button is never displayed.

  1. Press Ctrl+K with no text selected to open link inspector.
  2. Paste a URL, press Enter.
    • A new auto-numbered link like [1] is inserted.
  3. Select the link. The context menu lets you "Edit" it, click it.
  4. The "Simple link" inspector should have an "Add label" button, but doesn't.

An "Open" button should probably also appear (like in the link annotation inspector) and also doesn't.

Details

SubjectRepoBranchLines +/-
ve.ui.MWLinkNodeInspector: Restore action buttonsmediawiki/extensions/VisualEditormaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Mar 12 2015, 5:59 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: VisualEditor, VisualEditor-MediaWiki.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2015, 5:59 PM
gerritbot subscribed.Mar 12 2015, 6:32 PM

Change 196291 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWLinkNodeInspector: Restore action buttons

https://gerrit.wikimedia.org/r/196291

gerritbot added a project: Patch-For-Review.Mar 12 2015, 6:32 PM
Jdforrester-WMF closed this task as Resolved.Mar 12 2015, 7:40 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-18_(1.25wmf22); removed Patch-For-Review.
Jdforrester-WMF set Security to None.
gerritbot added a comment.Mar 12 2015, 7:42 PM

Change 196291 merged by jenkins-bot:
ve.ui.MWLinkNodeInspector: Restore action buttons

https://gerrit.wikimedia.org/r/196291

matmarex mentioned this in rEVED345879b277aa: ve.ui.MWLinkNodeInspector: Restore action buttons.Mar 12 2015, 7:42 PM
Jdforrester-WMF triaged this task as High priority.Mar 18 2015, 1:09 AM
Ryasmeen subscribed.Mar 18 2015, 4:06 AM

Verified the fix in Betalabs

Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Mar 27 2015, 10:18 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM
Jdforrester-WMF assigned this task to matmarex.Mar 29 2015, 11:31 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:50 PM
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 1 2015, 4:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits