Page MenuHomePhabricator
Create Task
Maniphest T92936

Reference adapatation cause javascript error with infinite recursion
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Try a translation - Special:ContentTranslation&page=Hebrew+language&from=en&to=he&targettitle=Hebrew+language&debug=1

Click on second paragraph and you will notice browser hangs for couple of seconds and finally an error in console saying maximum callstack reached..

It is caused by a recursion in ReferenceCard.prototype.getReferenceData method

Details

SubjectRepoBranchLines +/-
References: Fix javascript error by infinite recursionmediawiki/extensions/ContentTranslationmaster+8 -11
Customize query in gerrit

Related Objects

Event Timeline

santhosh created this task.Mar 17 2015, 6:26 AM
santhosh claimed this task.
santhosh raised the priority of this task from to High.
santhosh updated the task description. (Show Details)
santhosh added projects: ContentTranslation, LE-Sprint-84.
santhosh subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2015, 6:26 AM
Arrbee added a project: ContentTranslation-Release4.Mar 17 2015, 7:21 AM
Arrbee set Security to None.
gerritbot subscribed.Mar 17 2015, 8:28 AM

Change 197286 had a related patch set uploaded (by Santhosh):
References: Fix javascript error by infinite recursion

https://gerrit.wikimedia.org/r/197286

gerritbot added a project: Patch-For-Review.Mar 17 2015, 8:28 AM
santhosh moved this task from Backlog to In Review on the LE-Sprint-84 board.Mar 17 2015, 10:02 AM
santhosh edited a custom field.
gerritbot added a comment.Mar 18 2015, 7:46 AM

Change 197286 merged by jenkins-bot:
References: Fix javascript error by infinite recursion

https://gerrit.wikimedia.org/r/197286

santhosh moved this task from Backlog to Sprint 84 on the ContentTranslation-Release4 board.Mar 18 2015, 8:02 AM
santhosh moved this task from In Review to Done on the LE-Sprint-84 board.Mar 18 2015, 9:46 AM
Nikerabbit closed this task as Resolved.Mar 19 2015, 7:01 AM
Nikerabbit subscribed.
santhosh mentioned this in rECTXe703bbc8afcb: References: Fix javascript error by infinite recursion.Mar 23 2015, 3:54 PM
Diffusion mentioned this in rMEXTc7085bb85dfd: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Mar 23 2015, 3:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits