Page MenuHomePhabricator
Create Task
Maniphest T93002

[Regression wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Insert an image and go to Media Settings>Advanced dialogs dialog.
The label and the icon of the buttons are almost overlapping .

This is in Betalabs:

Screen_Shot_2015-03-17_at_12.53.51_PM.png (189×432 px, 18 KB)

This is in test2:
Screen_Shot_2015-03-17_at_12.54.22_PM.png (211×579 px, 20 KB)

Details

SubjectRepoBranchLines +/-
Revert "Button styles between OOJS and MW"oojs/uimaster+13 -10
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Mar 17 2015, 7:56 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2015, 7:56 PM
Ryasmeen renamed this task from [Regression pre-wmf22] No gap between Button labels and icons in Media Settings>Advanced dialogs to [Regression pre-wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog.Mar 17 2015, 7:56 PM
Ryasmeen set Security to None.
Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.Mar 17 2015, 9:37 PM
Jdforrester-WMF triaged this task as High priority.Mar 18 2015, 2:14 AM
Jdforrester-WMF lowered the priority of this task from High to Medium.
Jdforrester-WMF moved this task from External and Administrivia to TR6: Visual diffs on the VisualEditor board.
Jdforrester-WMF added a project: OOUI.
Ankita-ks subscribed.Mar 27 2015, 1:28 AM
gerritbot subscribed.Mar 30 2015, 9:19 PM

Change 200747 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Button styles between OOJS and MW"

https://gerrit.wikimedia.org/r/200747

gerritbot added a project: Patch-For-Review.Mar 30 2015, 9:19 PM
gerritbot added a comment.Mar 30 2015, 11:59 PM

Change 200747 merged by jenkins-bot:
Revert "Button styles between OOJS and MW"

https://gerrit.wikimedia.org/r/200747

matmarex mentioned this in rGOJU0f710e1f3946: Revert "Button styles between OOJS and MW".Mar 30 2015, 11:59 PM
matmarex claimed this task.Mar 31 2015, 7:50 AM
matmarex subscribed.

Probably fixed, have to test after pulling OOjs UI update to MediaWiki.

Jdforrester-WMF renamed this task from [Regression pre-wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog to [Regression wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog.Apr 2 2015, 10:21 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF edited projects, added OOjs-UI-next-release, VisualEditor 2014/15 Q4 blockers; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 2 2015, 10:25 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.9.5); removed OOjs-UI-next-release.Apr 7 2015, 4:26 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 8 2015, 10:49 AM
Jdforrester-WMF added a project: WMF-deploy-2015-04-08_(1.26wmf1).Apr 8 2015, 8:20 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Apr 29 2015, 9:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits