Page MenuHomePhabricator
Create Task
Maniphest T93016

Selecting an inspector while another inspector is open shows both inspector buttons as 'clicked'
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

To reproduce:

  1. Select a bit of text on a page and click "link"; the word will transform into a link.
  2. Without dismissing the link inspector, click on "Cite" inspector.
  3. Result -- the link inspector is still open, but both toolbar buttons are marked as active in the toolbar.

Details

SubjectRepoBranchLines +/-
Auto-close inspectorsVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Mar 17 2015, 9:28 PM
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: VisualEditor.
Mooeypoo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2015, 9:28 PM
Mooeypoo assigned this task to • TrevorParscal.Mar 17 2015, 9:29 PM
Mooeypoo set Security to None.
Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.Mar 17 2015, 9:36 PM
• TrevorParscal triaged this task as High priority.Mar 17 2015, 10:25 PM
• TrevorParscal added a project: VisualEditor 2014/15 Q3 blockers.
• TrevorParscal moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.
gerritbot subscribed.Mar 17 2015, 10:52 PM

Change 197432 had a related patch set uploaded (by Trevor Parscal):
Auto-close inspectors

https://gerrit.wikimedia.org/r/197432

gerritbot added a project: Patch-For-Review.Mar 17 2015, 10:52 PM
Jdforrester-WMF closed this task as Resolved.Mar 17 2015, 10:56 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-18_(1.25wmf22), VisualEditor-EditingTools; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Mar 17 2015, 10:57 PM

Change 197432 merged by jenkins-bot:
Auto-close inspectors

https://gerrit.wikimedia.org/r/197432

Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 18 2015, 12:22 AM
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 18 2015, 2:29 AM
Ryasmeen subscribed.Mar 18 2015, 4:10 AM

Verified the fix in Betalabs

• TrevorParscal mentioned this in rGVEDaedeba4d462c: Auto-close inspectors.Mar 23 2015, 3:53 PM
Ryasmeen added a project: Verified-in-Phase0.Mar 27 2015, 9:44 PM
Ryasmeen added a comment.Mar 27 2015, 9:47 PM

When you follow these steps, after clicking on autofill citation option from toolbar the selection extends over the link and also the citation note.Is that how we want it?

Screen_Shot_2015-03-27_at_2.47.11_PM.png (222×428 px, 24 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits