Page MenuHomePhabricator
Create Task
Maniphest T93098

Remove default values in flickrripper script
Closed, ResolvedPublic
Actions

Description

The flickrripper script uses default values for all parameters which is not always sensible. For example the following function can't work when not both parameters are given:

def getPhoto(flickr=None, photo_id=''):                                         
    """                                                                         
    Get the photo info and the photo sizes so we can use these later on.        
                                                                                
    TODO: Add exception handling                                                
                                                                                
    """                                                                         
    while True:                                                                 
        try:                                                                    
            photoInfo = flickr.photos_getInfo(photo_id=photo_id)                
            # xml.etree.ElementTree.dump(photoInfo)                             
            photoSizes = flickr.photos_getSizes(photo_id=photo_id)              
            # xml.etree.ElementTree.dump(photoSizes)                            
            return photoInfo, photoSizes                                        
        except flickrapi.exceptions.FlickrError:                                
            pywikibot.output(u'Flickr api problem, sleeping')                   
            time.sleep(30)

Details

SubjectRepoBranchLines +/-
Change flickrripper:remove default values for parameters wherever necessarypywikibot/coremaster+9 -9
Change flickrripper:remove default values for all parameterspywikibot/coremaster+11 -11
Customize query in gerrit

Related Objects

Event Timeline

XZise created this task.Mar 18 2015, 4:50 PM
XZise raised the priority of this task from to Lowest.
XZise updated the task description. (Show Details)
XZise added projects: Pywikibot, good first task.
XZise subscribed.
Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptMar 18 2015, 4:50 PM
jayvdb added a project: Pywikibot-Commons.Sep 3 2015, 4:13 AM
jayvdb subscribed.
jayvdb moved this task from Backlog to Harvesting on the Pywikibot-Commons board.Sep 3 2015, 4:30 AM
Nemo_bis added a project: Google-Code-In-2015.Jan 7 2016, 9:03 PM
Nemo_bis set Security to None.
Restricted Application added a subscriber: Avicennasis. · View Herald TranscriptJan 7 2016, 9:03 PM
jayvdb moved this task from Proposed to Mentors Required on the Google-Code-In-2015 board.Jan 9 2016, 3:20 AM
darthbhyrava subscribed.Feb 28 2016, 7:12 AM
darthbhyrava claimed this task.Feb 28 2016, 7:15 AM

I'm new to Pywikibot, but I think I can take this up.
Looking at "scripts/flickrripper.py" and https://www.flickr.com/services/api/ .

darthbhyrava added a comment.Feb 29 2016, 12:35 AM

Changes I'm making in my patch:

def getPhoto(flickr=None, photo_id='') --> def getPhoto(flickr, photo_id)
def isAllowedLicense(photoInfo=None) --> def isAllowedLicense(photoInfo)
def getPhotoUrl(photoSizes=None) --> def getPhotoUrl(photoSizes)
.
.
.
def getPhotos(flickr=None, user_id=u'', group_id=u'', photoset_id=u'', start_id='', end_id='', tags=u'') --> def getPhotos(flick, user_id, group_id, photoset_id, start_id, end_id, tags)

Please correct me if this was not what was expected.

gerritbot subscribed.Feb 29 2016, 2:30 AM

Change 273842 had a related patch set uploaded (by Darthbhyrava):
Change flickrripper:remove default values for all parameters\n Remove default values for all parameters to avoid errors in functions\n Bug: T93098

https://gerrit.wikimedia.org/r/273842

gerritbot added a project: Patch-For-Review.Feb 29 2016, 2:30 AM
darthbhyrava added a subscriber: Xqt.Feb 29 2016, 2:38 AM

Added a patch.
@XZise @Xqt could you please review this and let me know if I am on the wrong track?
Thanks!

gerritbot added a comment.Feb 29 2016, 10:46 AM

Change 273866 had a related patch set uploaded (by Darthbhyrava):
Change flickrripper:remove default values for all parameters

https://gerrit.wikimedia.org/r/273866

gerritbot added a comment.Feb 29 2016, 11:07 AM

Change 273866 abandoned by Darthbhyrava:
Change flickrripper:remove default values for all parameters

Reason:
Should be an amend commit, not a duplicate one.

https://gerrit.wikimedia.org/r/273866

gerritbot added a comment.Feb 29 2016, 1:05 PM

Change 273842 had a related patch set uploaded (by Darthbhyrava):
Change flickrripper:remove default values for parameters wherever necessary

https://gerrit.wikimedia.org/r/273842

gerritbot added a comment.Mar 1 2016, 11:15 AM

Change 273842 merged by jenkins-bot:
Change flickrripper:remove default values for parameters wherever necessary

https://gerrit.wikimedia.org/r/273842

jayvdb added a comment.Mar 5 2016, 2:00 PM

@darthbhyrava , the script panoramiopicker.py is nearly a copy of flickrripper.py, and has the same problem. If you like, you can fix this problem in panoramiopicker.py also.

darthbhyrava added a comment.EditedMar 5 2016, 9:37 PM

@jayvdb sure, I'll take a look into that, too. :)
T129017

darthbhyrava added a comment.Mar 6 2016, 1:17 PM
This comment was removed by darthbhyrava.
darthbhyrava closed this task as Resolved.Mar 6 2016, 2:10 PM

The patch has been merged, hence closing the task.

darthbhyrava mentioned this in T130585: Pywikibot Support for Thanks (GSoC Proposal).Mar 22 2016, 10:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits