Setting a image to reflow after inserting prevents saving, offset out of bounds
Closed, ResolvedPublic1 Story Points

Description

Hi,
I'm trying to let an image reflow to the left, after I placed it. The wikicode looks like this

ABCD
[[Datei:MYIMAGE.jpg|thumb|MYDESCRIPTION]]

Steps to reproduce:

  • Create a new page with Sourcecode-Editor
  • Insert the Wikicode above (of course use an image link for an existing image)
  • Switch to VE
  • Select Image / Edit / Advanced Settings
  • Image reflow yes / LEFT
  • Hit Save

On my system it doesnt stop loading. Chrome shows the following JavaScript-Error

Note: It works when I initially insert the image with the reflow left setting, it just doesnt work after I added the picture normally.

Uncaught Error: offset 13 out of bounds
285 ve.dm.ElementLinearData.getAnnotationIndexesFromOffsetload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
286 ve.dm.ElementLinearData.getAnnotationsFromOffsetload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
288 ve.dm.ElementLinearData.getAnnotationsFromRangeload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
215 ve.dm.SurfaceFragment.getAnnotationsload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
209 ve.dm.SurfaceFragment.getSelectedModelsload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
494 ve.ui.Context.getRelatedSourcesload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
494 ve.ui.Context.isEmbeddableload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
743 ve.ui.DesktopContext.updateDimensionsload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
368 ve.ce.FocusableNode.onFocusableRerenderload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
839 oo.EventEmitter.emitload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
450 ve.ce.GeneratedContentNode.afterRenderload.php?debug=false&lang=de&modules=ext.visualEditor.data%2Cicons%2Clanguage%2Cmwcore%2Cmwformatti…:352 ve.ce.MWImageNode.renderload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
450 ve.ce.GeneratedContentNode.updateload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
448 ve.ce.GeneratedContentNode.onGeneratedContentNodeUpdateload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
839 oo.EventEmitter.emitload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
113 ve.dm.Node.setLengthload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
113 ve.dm.Node.adjustLengthload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
112 ve.dm.Node.setLengthload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
113 ve.dm.Node.adjustLengthload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
131 ve.dm.BranchNode.spliceload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
47 (anonymous function)load.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
240 ve.dm.Document.rebuildNodesload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
251 ve.dm.DocumentSynchronizer.synchronizers.rebuildload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
253 ve.dm.DocumentSynchronizer.synchronizeload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
152 ve.dm.TransactionProcessor.processload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
232 ve.dm.Document.commitload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
206 ve.dm.Surface.changeInternalload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
206 ve.dm.Surface.changeload.php?debug=false&lang=de&modules=ext.visualEditor.data%2Cicons%2Clanguage%2Cmwcore%2Cmwformatti…:93 ve.dm.MWImageModel.updateImageNodeload.php?debug=false&lang=de&modules=ext.visualEditor.data%2Cicons%2Clanguage%2Cmwcore%2Cmwformatti…:143 ve.ui.MWMediaDialog.getActionProcess.handlerload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
878 (anonymous function)load.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
878 OO.ui.Process.executeload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
868 OO.ui.Dialog.executeActionload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
928 OO.ui.ProcessDialog.executeActionload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
866 OO.ui.Dialog.onActionClickload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
839 oo.EventEmitter.emitload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
839 oo.EventEmitter.emitload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
884 OO.ui.ButtonElement.onClickload.php?debug=false&lang=de&modules=Base64.js|easy-deflate.core%2Cdeflate|ext.visualEditor.base%2C…:
960 OO.ui.ButtonWidget.onClickload.php?debug=false&lang=de&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150312T1…:65 jQuery.event.dispatchload.php?debug=false&lang=de&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150312T1…:60 jQuery.event.add.elemData.handle

My setup

VE-Branchwmf/1.25wmf21
Commit4f9ea2722fe28e31b46561fe29aed6eca81cc686
MediaWiki-Branchmaster
MediaWiki commit5362d4d98361e8ffb8672d25cac6a825fc2755f1
BrowserGoogle Chrome @ Windows 8 64bit 41.0.2272.89 m
Hmrc87 created this task.Mar 19 2015, 3:11 PM
Hmrc87 added a project: VisualEditor.
Hmrc87 added a subscriber: Hmrc87.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2015, 3:11 PM
Hmrc87 edited the task description. (Show Details)Mar 19 2015, 3:17 PM
Hmrc87 set Security to None.
Catrope raised the priority of this task from "Normal" to "Unbreak Now!".Mar 19 2015, 4:40 PM
Catrope claimed this task.

Change 197968 had a related patch set uploaded (by Catrope):
Work around JS errors when editing image properties

https://gerrit.wikimedia.org/r/197968

Change 197968 merged by jenkins-bot:
Work around JS errors when editing image properties

https://gerrit.wikimedia.org/r/197968

Jdforrester-WMF closed this task as "Resolved".Mar 19 2015, 8:45 PM

Verified the fix in betalabs.

Jdforrester-WMF moved this task from To Triage to Done on the VisualEditor board.Apr 1 2015, 4:13 PM