Page MenuHomePhabricator
Create Task
Maniphest T93234

Separate the XmlSelect class (generates <select ...>...</select> comboboxes) and implement where it should be used
Closed, ResolvedPublic
Actions

Description

Currently, to write an combobox in MediaWiki, the steps are:

  • a call to Xml:openElement for <select...
  • as many calls to Html:element( 'option', ...) as the count of options
  • a call to Xml:closeElement to get the </select>

This makes operations like "write a combobox with this array as options and set the option ... as default" rather long and tedious to write.

A widget class would be interesting to abstract the process.

Move XmlSelect to its own file, and use it where it should be used in various codez.

See P673 for codes to replace

Details

SubjectRepoBranchLines +/-
Use XmlSelect in SpecialEditTagsmediawiki/coremaster+8 -10
Enable multiple default values for XmlSelectmediawiki/coremaster+7 -3
Use XmlSelect in SpecialListusersmediawiki/coremaster+6 -5
Use XmlSelect in ProtectionFormmediawiki/coremaster+20 -32
Use XmlSelect in WebInstallerPagemediawiki/coremaster+6 -6
Use XmlSelect to simplify Xml::monthSelectormediawiki/coremaster+9 -16
Move XmlSelect to its own filemediawiki/coremaster+131 -107
Customize query in gerrit

Related Objects

Event Timeline

Dereckson created this task.Mar 19 2015, 6:19 PM
Dereckson raised the priority of this task from to Needs Triage.
Dereckson updated the task description. (Show Details)
Dereckson added a project: MediaWiki-General.
Dereckson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2015, 6:19 PM
Dereckson updated the task description. (Show Details)Mar 19 2015, 7:17 PM
Dereckson set Security to None.
Dereckson added a project: good first task.Mar 19 2015, 9:44 PM
Aklapper triaged this task as Lowest priority.Mar 20 2015, 11:02 AM
Sn1per claimed this task.May 22 2015, 2:28 PM
Sn1per subscribed.

I might work on this? Especially because school is out.

matmarex subscribed.May 22 2015, 2:29 PM

There is one, actually! XmlSelect, in includes/Xml.php. We should probably split it to separate file to make it easier to find.

Dereckson added a comment.May 22 2015, 8:27 PM

What you can do in this case is to implement this XmlSelect in the following files to simplify our code:

  • includes/ProtectionForm.php
  • includes/installer/WebInstallerPage.php
  • includes/specials/SpecialListusers.php

See P673 for the output of the ag -Q "openElement( 'select'" command.

Sn1per renamed this task from An helper class to generate <select ...>...</select> comboboxes to Separate the XmlSelect class (generates <select ...>...</select> comboboxes) and implement where it should be used.Jun 1 2015, 3:23 AM
Sn1per updated the task description. (Show Details)
gerritbot subscribed.Jun 2 2015, 11:46 PM

Change 215551 had a related patch set uploaded (by Sn1per):
Move XmlSelect to its own file

https://gerrit.wikimedia.org/r/215551

gerritbot added a project: Patch-For-Review.Jun 2 2015, 11:46 PM
gerritbot added a comment.Jun 3 2015, 3:34 AM

Change 215551 merged by jenkins-bot:
Move XmlSelect to its own file

https://gerrit.wikimedia.org/r/215551

Legoktm mentioned this in rMW8007e25308a3: Move XmlSelect to its own file.Jun 3 2015, 3:35 AM
• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-06-09_(1.26wmf9).Jun 3 2015, 4:00 AM
• Forrestbot subscribed.
gerritbot added a comment.Jun 6 2015, 11:41 PM

Change 216511 had a related patch set uploaded (by Sn1per):
Use XmlSelect to "simplify" stuff in class Xml

https://gerrit.wikimedia.org/r/216511

gerritbot added a comment.Jun 13 2015, 1:10 PM

Change 216511 merged by jenkins-bot:
Use XmlSelect to simplify Xml::monthSelector

https://gerrit.wikimedia.org/r/216511

Sn1per mentioned this in rMW78401facfe7a: Use XmlSelect to simplify Xml::monthSelector.Jun 13 2015, 1:10 PM
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 13 2015, 2:00 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Sn1per updated the task description. (Show Details)Jul 25 2015, 3:33 PM
gerritbot added a comment.Jul 30 2015, 7:08 PM

Change 228054 had a related patch set uploaded (by Sn1per):
Use XmlSelect in WebInstallerPage

https://gerrit.wikimedia.org/r/228054

gerritbot added a comment.Jul 30 2015, 8:00 PM

Change 228127 had a related patch set uploaded (by Sn1per):
Use XmlSelect in ProtectionForm

https://gerrit.wikimedia.org/r/228127

gerritbot added a comment.Jul 30 2015, 9:20 PM

Change 228054 merged by jenkins-bot:
Use XmlSelect in WebInstallerPage

https://gerrit.wikimedia.org/r/228054

gerritbot added a comment.Jul 30 2015, 9:47 PM

Change 228127 merged by jenkins-bot:
Use XmlSelect in ProtectionForm

https://gerrit.wikimedia.org/r/228127

• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Jul 30 2015, 10:00 PM
Sn1per mentioned this in rMW1ba74a62136f: Use XmlSelect in WebInstallerPage.Jul 30 2015, 10:15 PM
Sn1per mentioned this in rMW0d83dd176fc4: Use XmlSelect in ProtectionForm.
gerritbot added a comment.Aug 1 2015, 9:17 PM

Change 228566 had a related patch set uploaded (by Sn1per):
Use XmlSelect in SpecialListusers

https://gerrit.wikimedia.org/r/228566

gerritbot added a comment.Aug 1 2015, 9:39 PM

Change 228566 merged by jenkins-bot:
Use XmlSelect in SpecialListusers

https://gerrit.wikimedia.org/r/228566

Sn1per mentioned this in rMWb853f0e14d7b: Use XmlSelect in SpecialListusers.Aug 1 2015, 9:40 PM
Sn1per updated the task description. (Show Details)Sep 9 2015, 8:12 PM
gerritbot added a comment.Sep 13 2015, 11:01 PM

Change 238075 had a related patch set uploaded (by Sn1per):
Enable multiple default values for XmlSelect

https://gerrit.wikimedia.org/r/238075

gerritbot added a comment.Sep 13 2015, 11:01 PM

Change 238076 had a related patch set uploaded (by Sn1per):
Use XmlSelect in SpecialEditTags

https://gerrit.wikimedia.org/r/238076

gerritbot added a comment.Sep 15 2015, 1:54 PM

Change 238075 merged by jenkins-bot:
Enable multiple default values for XmlSelect

https://gerrit.wikimedia.org/r/238075

Sn1per mentioned this in rMWe36845aac662: Enable multiple default values for XmlSelect.Sep 15 2015, 1:54 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 15 2015, 2:00 PM
gerritbot added a comment.Sep 15 2015, 2:03 PM

Change 238076 merged by jenkins-bot:
Use XmlSelect in SpecialEditTags

https://gerrit.wikimedia.org/r/238076

Sn1per mentioned this in rMW36a53afd1fad: Use XmlSelect in SpecialEditTags.Sep 15 2015, 2:03 PM
Legoktm subscribed.Sep 24 2015, 5:07 PM

@Sn1per, are there any instances left that still need fixing?

Sn1per added a comment.Sep 24 2015, 9:19 PM

@Legoktm hey, there are still a few instances (see P673), but for the most part, all of the "easy" drop-in replacements are done; some of the remaining replacements may require a little work to get working.

Legoktm added a comment.Sep 24 2015, 10:55 PM

Should we keep this assigned to you then (are you planning to work on the rest)? Or maybe file other tasks for the remaining instances and close this one?

Sn1per added a comment.Sep 25 2015, 12:34 AM

@Legoktm I am going to get around to the rest, eventually :P but others are welcome to do it if they want to.

The remaining replacements are kinda too small to be separate tasks, but if they are not trivial, separate tasks could be filed. e.g. I tried to convert Xml::listDropDown() a while back (it was in one of the merged gerrit changes, but I removed it), but the logic was so heavily based around Xml::openElement and Xml::select that I ended up making it messier; at one point it was suggested that listDropDown could, if needed, be separated into a separate class :P

matmarex closed this task as Resolved.Oct 27 2015, 11:04 PM

Let's close this then, if this doesn't actually improve the code in other cases, it's probably not worth spending time on. (If you decide that it does, feel free to submit more patches though!)

Dereckson added a comment.Oct 28 2015, 6:51 AM

Thank you @Sn1per for this work.

Dereckson awarded a token.Oct 28 2015, 6:52 AM
Sn1per added a comment.Oct 28 2015, 5:53 PM

@matmarex Sounds good, thanks.

@Dereckson Thanks for the broccoli tree

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits