Create Task
Maniphest T93322

Focusable hIghlight logic is broken, only rendering for the root element
Closed, ResolvedPublic1 Story Points
Actions

Description

Eurgh.

See e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Cat?veaction=edit (also reproducible in production). Widely-used template, so we need to fix this.

Related Objects

Jdforrester-WMF created this task.Mar 20 2015, 2:53 AM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF raised the priority of this task from to High.
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF added projects: VisualEditor 2014/15 Q3 blockers, VisualEditor, VisualEditor-MediaWiki-Templates.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2015, 2:53 AM
Esanders renamed this task from On enwiki, {{Taxobox}} doesn't get a shield so its contents are clickable to Focusable hIghlight logic is broken, only rendering for the root element..Mar 20 2015, 12:38 PM
Esanders set Security to None.
gerritbot added a subscriber: gerritbot.Mar 20 2015, 12:44 PM

Change 198216 had a related patch set uploaded (by Esanders):
Fix webkit column hack

https://gerrit.wikimedia.org/r/198216

gerritbot added a comment.Mar 20 2015, 6:51 PM

Change 198216 merged by jenkins-bot:
Fix webkit column hack

https://gerrit.wikimedia.org/r/198216

gerritbot added a comment.Mar 20 2015, 6:54 PM

Change 198278 had a related patch set uploaded (by Jforrester):
Fix webkit column hack

https://gerrit.wikimedia.org/r/198278

gerritbot added a comment.Mar 20 2015, 6:54 PM

Change 198279 had a related patch set uploaded (by Jforrester):
Fix webkit column hack

https://gerrit.wikimedia.org/r/198279

Jdforrester-WMF renamed this task from Focusable hIghlight logic is broken, only rendering for the root element. to Focusable hIghlight logic is broken, only rendering for the root element.Mar 20 2015, 11:05 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-25_(1.25wmf23), WMF-deploy-2015-03-18_(1.25wmf22), WMF-deploy-2015-03-11_(1.25wmf21); removed Patch-For-Review.
gerritbot added a comment.Mar 21 2015, 12:50 AM

Change 198279 merged by jenkins-bot:
Fix webkit column hack

https://gerrit.wikimedia.org/r/198279

gerritbot added a comment.Mar 21 2015, 1:12 AM

Change 198278 merged by jenkins-bot:
Fix webkit column hack

https://gerrit.wikimedia.org/r/198278

Jdforrester-WMF moved this task from To Triage to Done on the VisualEditor board.Apr 1 2015, 4:13 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL