Maniphest T93504

Header and summary diff view throw due to not meeting new diffRevision signature
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mattflaschen-WMF
	Mar 22 2015, 5:46 AM

Tags

Referenced Files

None

Subscribers

• Mattflaschen-WMF

Description

Matthias fixed this earlier in https://gerrit.wikimedia.org/r/#/c/197026/ , but it needs to be cherry-picked to 1.25wmf21. It is currently affecting everything except MediaWiki.org and the test wikis (this means it affects all Wikipedias).

Amir hit this issue in T93492: Fatal in getUserLinks for a revision that undoes a suppression, though I don't think that led to the other bug (editing the header does not trigger a visible diff).

Details

	Subject	Repo	Branch	Lines +/-
	Fix header & summary diff view	mediawiki/extensions/Flow	wmf/1.25wmf21	+10 -4

Customize query in gerrit

Related Objects

Mentioned In: rEFLWf1375567b675: Fix header & summary diff view
T93492: Fatal in getUserLinks for a revision that undoes a suppression
Mentioned Here: T93333: "BadMethodCallException" from EchoHooks::getNotificationTypes adding to certain talk page
T93492: Fatal in getUserLinks for a revision that undoes a suppression

Event Timeline

• Mattflaschen-WMF created this task.Mar 22 2015, 5:46 AM

• Mattflaschen-WMF assigned this task to matthiasmullie.

• Mattflaschen-WMF raised the priority of this task from to Unbreak Now!.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: StructuredDiscussions, WMF-Server-Backports.

• Mattflaschen-WMF added subscribers: • Mattflaschen-WMF, Amire80.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2015, 5:46 AM

• Mattflaschen-WMF mentioned this in T93492: Fatal in getUserLinks for a revision that undoes a suppression.Mar 22 2015, 5:47 AM

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF set Security to None.

Change 198541 had a related patch set uploaded (by Mattflaschen):
Fix header & summary diff view

https://gerrit.wikimedia.org/r/198541

gerritbot added a project: Patch-For-Review.Mar 22 2015, 6:06 AM

@matthiasmullie, can you be around for morning SWAT on Monday for this (in addition to T93333: "BadMethodCallException" from EchoHooks::getNotificationTypes adding to certain talk page)?

• Mattflaschen-WMF added a subscriber: EBernhardson.Mar 22 2015, 6:10 AM

@Mattflaschen: I'll be around for SWAT. Thanks for preparing all cherry-picks!

Change 198541 merged by jenkins-bot:
Fix header & summary diff view

https://gerrit.wikimedia.org/r/198541

• Mattflaschen-WMF mentioned this in rEFLWf1375567b675: Fix header & summary diff view.Mar 23 2015, 3:53 PM

EBernhardson closed this task as Resolved.Mar 23 2015, 5:38 PM