Page MenuHomePhabricator
Create Task
Maniphest T93333

"BadMethodCallException" from EchoHooks::getNotificationTypes adding to certain talk page
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Twice tonight when adding a section to a user talk page, the submit resulted in:

https://www.mediawiki.org/w/index.php?title=User_talk:Waldir&action=submit
Exception encountered, of type "BadMethodCallException".

If I reload the web page and resubmit the I get an edit conflict, and it turns out my contribution was successful.

legoktm found

legoktm@fluorine:/a/mw-log$ grep "BadMethodCallException" exception.log | grep mediawikiwiki
2015-03-20 07:54:02 mw1212 mediawikiwiki: [4b5683b8] /w/index.php?title=User_talk:Waldir&action=submit  
   BadMethodCallException from line 221 of /
   srv/mediawiki/php-1.25wmf22/extensions/Echo/Hooks.php:
   Call to a member function isMinor() on a non-object (NULL)

the second exception has identifier [49120a69]

I tried adding a new section to my own user page and it worked fine.

Here's the full log from the first exception.

2015-03-20 07:54:02 mw1212 mediawikiwiki: [4b5683b8] /w/index.php?title=User_talk:Waldir&action=submit BadMethodCallException from line 221 of /srv/mediawiki/php-1.25wmf22/extensions/Echo/Hooks.php: Call to a member function isMinor() on a non-object (NULL)
#0 /srv/mediawiki/php-1.25wmf22/includes/Hooks.php(209): EchoHooks::getNotificationTypes()
#1 /srv/mediawiki/php-1.25wmf22/includes/GlobalFunctions.php(4016): Hooks::run()
#2 /srv/mediawiki/php-1.25wmf22/extensions/Echo/controller/NotificationController.php(82): wfRunHooks()
#3 /srv/mediawiki/php-1.25wmf22/extensions/Echo/model/Event.php(146): EchoNotificationController::notify()
#4 /srv/mediawiki/php-1.25wmf22/extensions/Echo/includes/DiscussionParser.php(97): EchoEvent::create()
#5 /srv/mediawiki/php-1.25wmf22/extensions/Echo/Hooks.php(444): EchoDiscussionParser::generateEventsForRevision()
#6 /srv/mediawiki/php-1.25wmf22/includes/Hooks.php(209): EchoHooks::onArticleSaved()
#7 /srv/mediawiki/php-1.25wmf22/includes/content/ContentHandler.php(1161): Hooks::run()
#8 /srv/mediawiki/php-1.25wmf22/includes/page/WikiPage.php(1979): ContentHandler::runLegacyHooks()
#9 /srv/mediawiki/php-1.25wmf22/includes/page/Article.php(1991): WikiPage->doEditContent()
#10 /srv/mediawiki/php-1.25wmf22/includes/EditPage.php(1905): Article->__call()
#11 /srv/mediawiki/php-1.25wmf22/includes/EditPage.php(1298): EditPage->internalAttemptSave()
#12 /srv/mediawiki/php-1.25wmf22/includes/EditPage.php(538): EditPage->attemptSave()
#13 /srv/mediawiki/php-1.25wmf22/includes/actions/EditAction.php(56): EditPage->edit()
#14 /srv/mediawiki/php-1.25wmf22/includes/actions/SubmitAction.php(40): EditAction->show()
#15 /srv/mediawiki/php-1.25wmf22/includes/MediaWiki.php(403): SubmitAction->show()
#16 /srv/mediawiki/php-1.25wmf22/includes/MediaWiki.php(275): MediaWiki->performAction()
#17 /srv/mediawiki/php-1.25wmf22/includes/MediaWiki.php(571): MediaWiki->performRequest()
#18 /srv/mediawiki/php-1.25wmf22/includes/MediaWiki.php(422): MediaWiki->main()
#19 /srv/mediawiki/php-1.25wmf22/index.php(46): MediaWiki->run()
#20 /srv/mediawiki/w/index.php(3): include()

Details

SubjectRepoBranchLines +/-
Read revision from master when determining notifications to sendmediawiki/extensions/Echowmf/1.25wmf22+1 -1
Read revision from master when determining notifications to sendmediawiki/extensions/Echowmf/1.25wmf21+1 -1
Read revision from master when determining notifications to sendmediawiki/extensions/Echomaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Spage created this task.Mar 20 2015, 8:25 AM
• Spage raised the priority of this task from to High.
• Spage updated the task description. (Show Details)
• Spage added projects: Notifications, Wikimedia-production-error.
• Spage subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2015, 8:25 AM
gerritbot subscribed.Mar 20 2015, 11:20 PM

Change 198426 had a related patch set uploaded (by EBernhardson):
Read revision from master when determining notifications to send

https://gerrit.wikimedia.org/r/198426

gerritbot added a project: Patch-For-Review.Mar 20 2015, 11:20 PM
EBernhardson subscribed.Mar 20 2015, 11:23 PM

This wasn't noticed until now as its a timing bug and depended on the amount of slave lag and the time it took to get from writing out the new revision to sending the notifications.

• Spage added a comment.Mar 20 2015, 11:31 PM

FWIW from fluorine logs:

  • there were three other occurrences in today's exception.log that weren't me, all on mediawikiwiki.
  • on 2015-03-19 there were 20 exceptions, including some on test2wiki and testwikidatawiki (I wonder if some browsertest failed?)
  • no exceptions earlier in March
gerritbot added a comment.Mar 21 2015, 3:04 AM

Change 198426 merged by jenkins-bot:
Read revision from master when determining notifications to send

https://gerrit.wikimedia.org/r/198426

• Mattflaschen-WMF added a project: WMF-Server-Backports.Mar 21 2015, 4:26 AM
• Mattflaschen-WMF subscribed.

I think this also means users with enotifminoredits falsy can miss notifications, so we need to SWAT this on Monday.

gerritbot added a comment.Mar 21 2015, 4:28 AM

Change 198467 had a related patch set uploaded (by Mattflaschen):
Read revision from master when determining notifications to send

https://gerrit.wikimedia.org/r/198467

gerritbot added a comment.Mar 21 2015, 4:29 AM

Change 198468 had a related patch set uploaded (by Mattflaschen):
Read revision from master when determining notifications to send

https://gerrit.wikimedia.org/r/198468

• Mattflaschen-WMF added a subscriber: matthiasmullie.Mar 21 2015, 4:35 AM

@matthiasmullie I did the cherry-picks above. It would be good to get this in the morning SWAT if possible.

• Mattflaschen-WMF added a comment.Mar 21 2015, 4:41 AM

It depends on cherry-picks of "Update mock wgEchoConfig to also run on Special:JavaScript/qunit/plain" to pass Jenkins, which I've done now.

Florian subscribed.Mar 21 2015, 9:33 PM
Krenair subscribed.Mar 21 2015, 9:47 PM
Florian mentioned this in T93490: Exception encountered, of type "BadMethodCallException".Mar 21 2015, 10:20 PM
• Mattflaschen-WMF merged a task: T93490: Exception encountered, of type "BadMethodCallException".Mar 22 2015, 5:31 AM
• Mattflaschen-WMF added a subscriber: Kaganer.
• Mattflaschen-WMF mentioned this in T93504: Header and summary diff view throw due to not meeting new diffRevision signature.Mar 22 2015, 6:08 AM
gerritbot added a comment.Mar 23 2015, 2:15 PM

Change 198467 merged by jenkins-bot:
Read revision from master when determining notifications to send

https://gerrit.wikimedia.org/r/198467

gerritbot added a comment.Mar 23 2015, 2:16 PM

Change 198468 merged by jenkins-bot:
Read revision from master when determining notifications to send

https://gerrit.wikimedia.org/r/198468

Krinkle mentioned this in rECHO80ddd5549b98: Read revision from master when determining notifications to send.Mar 23 2015, 3:54 PM
• Mattflaschen-WMF mentioned this in rECHO0fe734be161e: Read revision from master when determining notifications to send.Mar 23 2015, 3:54 PM
• Mattflaschen-WMF mentioned this in rECHOf373ae269606: Read revision from master when determining notifications to send.
EBernhardson mentioned this in rMEXTb3165553c4cc: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Mar 23 2015, 3:56 PM
• Mattflaschen-WMF closed this task as Resolved.Mar 26 2015, 10:05 PM
• Mattflaschen-WMF assigned this task to EBernhardson.
• Mattflaschen-WMF set Security to None.
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:35 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 12 2015, 6:35 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 15 2015, 11:31 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits