Page MenuHomePhabricator
Create Task
Maniphest T93570

[Bug] deleting text of value and then clicking remove hangs UI
Closed, ResolvedPublic
Actions

Description

Edit a claim. Remove the text in the value field. Click remove. The text "Removing..." is displayed. Nothing happens after this. After reloading the page the claim is still there.
The JS error I get is "Uncaught TypeError: Cannot read property 'getClaim' of null"

This seems to happen for:

  • quantity
  • date
  • item link
  • property link
  • monolingual text
  • geocoordinate

It does not seem to be an issue for:

  • string
  • URL
  • commons media

Details

SubjectRepoBranchLines +/-
Fix statementlistview trying to remove statement with GUID nullmediawiki/extensions/Wikibasemaster+22 -11
Customize query in gerrit

Event Timeline

Lydia_Pintscher created this task.Mar 23 2015, 10:08 AM
Lydia_Pintscher raised the priority of this task from to Medium.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Lydia_Pintscher added subscribers: Lydia_Pintscher, thiemowmde, • adrianheine.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 10:08 AM
Lydia_Pintscher added a comment.Mar 23 2015, 10:10 AM

This happens on items and property pages.

aude subscribed.Mar 23 2015, 10:19 AM

@Lydia_Pintscher does this happen on test wikidata? and/or wikidata?

I cannot reproduce on test.wikidata, although maybe I misunderstand this bug.

Lydia_Pintscher added a comment.Mar 23 2015, 10:34 AM

Yes it also happens there. It does not happen for string values apparently.

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 23 2015, 11:24 AM
matej_suchanek subscribed.Mar 23 2015, 12:27 PM
• Jonas renamed this task from deleting text of value and then clicking remove hangs UI to [Bug] deleting text of value and then clicking remove hangs UI.Sep 10 2015, 12:13 PM
• Jonas updated the task description. (Show Details)
• Jonas set Security to None.
• Jonas updated the task description. (Show Details)Sep 10 2015, 12:32 PM
Nikki subscribed.Apr 23 2016, 2:58 PM

I just got this with an identifier. I also tested with string, monolingual text, URL, Commons media and mathematical expression and the same happens for those (contrary to what the description says).

gerritbot subscribed.Apr 23 2016, 5:52 PM

Change 285016 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix statementlistview trying to remove statement with GUID null

https://gerrit.wikimedia.org/r/285016

gerritbot added a project: Patch-For-Review.Apr 23 2016, 5:52 PM
thiemowmde claimed this task.Apr 23 2016, 5:53 PM
thiemowmde added projects: MediaWiki-extensions-WikibaseView, Wikidata-Sprint-2016-04-12.
thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-04-12 board.Apr 23 2016, 5:58 PM
thiemowmde closed this task as Resolved.Apr 26 2016, 7:20 AM
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2016-04-12 board.
gerritbot added a comment.Apr 26 2016, 9:09 AM

Change 285016 merged by jenkins-bot:
Fix statementlistview trying to remove statement with GUID null

https://gerrit.wikimedia.org/r/285016

matej_suchanek unsubscribed.Apr 28 2016, 2:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits