The property label doesn't scroll with the viewport anymore.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Adapt statementgrouplabelscroll to DOM changes | mediawiki/extensions/Wikibase | master | +4 -5 |
Related Objects
Event Timeline
Just to let you know: I had a look into this right when the Wikidata-Sprint-2015-05-05 started. To my surprise I could not find the code responsible for the sticky property labels. @Snaterlicious, do you have a hint?
Change 220091 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Adapt statementgrouplabelscroll to DOM changes
Had a chat with @Snaterlicious. The relevant JavaScript source file is jquery.wikibase.statementgrouplabelscroll.js, which is now in the view folder of Wikibase.git. jquery.sticknode.js and the word "stick" I originally searched for does not appear in this file. "labelscroll" is what I should have searched for.
Reason for the regression are the DOM changes in https://gerrit.wikimedia.org/r/#/c/186228/9/repo/resources/templates.php. Labelscroll was not adapted. Now patched in https://gerrit.wikimedia.org/r/#/c/220091/.
Side note: The performance of this feature feels bad. Is it me? Is it my machine?