Page MenuHomePhabricator

property label doesn't scroll with viewport anymore
Closed, ResolvedPublic1 Estimated Story Points


The property label doesn't scroll with the viewport anymore.


Event Timeline

JanZerebecki raised the priority of this task from to Needs Triage.
JanZerebecki updated the task description. (Show Details)
Lydia_Pintscher set Security to None.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
Lydia_Pintscher added a subscriber: thiemowmde.

Just to let you know: I had a look into this right when the Wikidata-Sprint-2015-05-05 started. To my surprise I could not find the code responsible for the sticky property labels. @Snaterlicious, do you have a hint?

Change 220091 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Adapt statementgrouplabelscroll to DOM changes

Had a chat with @Snaterlicious. The relevant JavaScript source file is jquery.wikibase.statementgrouplabelscroll.js, which is now in the view folder of Wikibase.git. jquery.sticknode.js and the word "stick" I originally searched for does not appear in this file. "labelscroll" is what I should have searched for.

Reason for the regression are the DOM changes in Labelscroll was not adapted. Now patched in

Side note: The performance of this feature feels bad. Is it me? Is it my machine?

Bene assigned this task to thiemowmde.
Bene removed a project: Patch-For-Review.
Bene moved this task from Backlog to Done on the Wikidata-Sprint-2015-06-16 board.

Change 220091 merged by jenkins-bot:
Adapt statementgrouplabelscroll to DOM changes

@thiemowmde I also see the bad performance and have opened T103485 for that.