Page MenuHomePhabricator

The "Help" link has bad color contrast in the Modern skin
Open, LowestPublic

Description

Some special pages now have a icon with a help link in the right top corner. In modern skin the contrast is bad and the link is not visible.

Event Timeline

Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender added a project: Modern.
Umherirrender subscribed.
Jdlrobson triaged this task as Lowest priority.Jan 22 2021, 1:06 AM
Jdlrobson edited projects, added MediaWiki-Special-pages, Modern (Tracking); removed Modern.
Jdlrobson subscribed.

Screen Shot 2021-01-21 at 5.04.48 PM.png (150×2 px, 40 KB)

Perhaps this should be declined as we don't actively support Modern or encourage its use.

Krinkle renamed this task from help link has bad contrast in modern skin to The "Help" link has bad color contrast in the Modern skin.Jun 19 2021, 2:54 AM
Krinkle subscribed.

This seems to be a general problem with page indicators in the Modern skin. It rendered them in its skin layout outside the content area. I suspect this may have unintentionally happened as part of refactoring, and not result of an intentional decision to output indicators over there.

They are not an abstract piece of information that can be expected to adapt to a skin's layout and theme. They are user-generated and thus should render in a location suitable for such content which is generally the content area or something visually compatible with it.

For example:

https://nl.wikipedia.org/wiki/Berlijn?useskin=modern

modern_skin-page_indicator.png (1×2 px, 285 KB)

It seems that Modern is the only skin that separates the page header outside of the "content area". For the same reason, ContentTranslation's buttons on contribution pages appear on top of other toolbars:

image.png (909×2 px, 339 KB)