Page MenuHomePhabricator

Gerrit +2 Access Request (Mjbmr)
Closed, DeclinedPublic

Description

Hello, I would like to have +2 access for mediawiki/core and extensions for approving long time waiting minor commits.

Event Timeline

Mjbmr raised the priority of this task from to Needs Triage.
Mjbmr updated the task description. (Show Details)
Mjbmr subscribed.
Aklapper changed the task status from Open to Stalled.Apr 3 2015, 3:10 PM

Also see https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Requesting_repository_ownership

I see you listed 13 times as a reviewer in https://gerrit.wikimedia.org/r/#/q/reviewer:Mjbmr,n,z and only two of these patches are still open. Can you please provide specific examples for "long time waiting minor commits", as I don't see a particular problem with these numbers?

@Aklapper

What exactly I missed about https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Requesting_repository_ownership

When I don't have access, no one is going to add me as a reviewer, but you can visit following link:

https://gerrit.wikimedia.org/r/#/q/owner:Mjbmr,n,z

and by "long time waiting minor commits" I meant my own commits for example translations and stuff which been waiting but seems @Raymond is handling them.

and by "long time waiting minor commits" I meant my own commits for example translations and stuff which been waiting but seems @Raymond is handling them.

"In projects deployed on the Wikimedia cluster, +2-ing your own code is unacceptable and can be grounds for revocation."
https://www.mediawiki.org/wiki/Gerrit/%2B2#Very_few_changes_are_trivial_enough_to_self-merge

Mjbmr claimed this task.
Florian changed the task status from Declined to Invalid.Apr 3 2015, 8:07 PM
Florian subscribed.

Change status to invalid, cause declined would require, that your request was declined (?), which isn't the fact here :)

Maybe next time.

@Florian sure I can mark my own created task as declined.

Krenair changed the task status from Invalid to Declined.Apr 3 2015, 8:23 PM

Now it's declined.

What is the different between my declined and your declined? You guys might check on that. Anyways please check my mediawiki commits, I've added much people over a week, if you guys are gonna approve people who they you know I'm gonna stop contributing.

@Mjbmr Surely the point is to approve people known in the community? Approving anyone could cause any number of issues.

@onei Hi, so you admitting on that? if there is any problem with commit you can just comment.

BTW, see this:

https://meta.wikimedia.org/w/index.php?title=User_talk:Elitre_%28WMF%29&oldid=11182420#Re:

I'm not really sure what you're asking @onei about, but they're correct that we would only support people who we (the existing MediaWiki developers and other involved parties) know well enough to trust. This is entirely reasonable, see https://www.mediawiki.org/wiki/Gerrit/%2B2 in case it's not clear why.

I read your discussion with @Aklapper - among other things, adding qqq documentation for messages which you create certainly is your responsibility as the patch uploader, and I would expect someone applying for +2 access to core and extensions to know this.

@Krenair I commit as a volunteer, I don't get paid, and I don't know everything from the born. These are just not friendly.

Back in 2010 I couldn't communicate well in English, now look what I turned into. but just because I'm in low grow country, I can't study well, otherwise I've a great mind.

I also commit as a volunteer sometimes without getting paid. I didn't know everything from the start either, but I knew that long before I was given +2 access to mediawiki repositories.

@Krenair I know what do you mean and I don't insistence on getting access. I just don't appreciate who trying to ruin people's volunteer work just because they think that user is not trusted. Read all these above comments you all saying I'm not trusted without even checking my commit.

I don't want to continue this conversation unless you write something that needs reply.

I'm not trying to ruin anyone's work. I have checked your commits, and I have interacted with you before.

What is the different between my declined and your declined? You guys might check on that. Anyways please check my mediawiki commits, I've added much people over a week, if you guys are gonna approve people who they you know I'm gonna stop contributing.

For me, it sounds strange, that you decline your own request :) You shouldn't be able to vote your own request (if you don't support it, you normaly don't file the request :)). So, if you withdraw your own request you should use "Invalid", due to lack of a "withdraw" status or similar (that's my understanding of the (new) process here in phabricator) :) That's my intention (so, please don't count my comment as a vote :)).

Nobody ruins work here. Instead, people learn together from each other and try to help improving work. That also means that patches are not always perfect from the very beginning, so they receive comments and reviews by others, and hence need some more work. That is the workflow for everybody in our community, no matter if you have been around and involved for a week or for ten years.
I'd say that patch review itself is unrelated to personal trust: it's related to technical code. But getting +2 rights after a while is related to trust indeed.

General note: Everybody please keep in mind to respectfully criticize ideas, not people. Thank you!

One question, how L10n-bot submits and merges?

One question, how L10n-bot submits and merges?

Per script on command line on the translatewiki.net server, operated by me or Siebrand.