Page MenuHomePhabricator

problems caused by translate function using lang instead of code
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/199579/ (Use site.lang instead of site.code) was a breaking change, not backwards compatible.

It allowed scripts to fallback to English undesirably, such as when their code was wikidata or commons. e.g. T94680

It also caused site specific logic to not be used. e.g. category.py has a special configuration for test.wikipedia, which now isnt used. (see cfd_templates)
More examples can be found in git grep "'commons':"

Event Timeline

jayvdb raised the priority of this task from to High.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb added subscribers: jayvdb, Xqt, XZise, Ladsgroup.
Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptApr 3 2015, 11:07 PM
Xqt closed this task as Resolved.EditedJan 11 2022, 4:25 PM
Xqt claimed this task.

Already reverted in rPWBC316b0434, see also T100392