Page MenuHomePhabricator

Tables: Invalid attributes in wikitext rows aren't roundtripped properly
Closed, ResolvedPublic

Description

[subbu@earth tests] cat /tmp/wt
{|
|- title="foo" | [[Foo]]
|}
[subbu@earth tests] node parse --wt2wt < /tmp/wt
{|
|- title="foo" |   [ Foo]]
|}

See http://localhost:8000/_rt/arwiki/%D8%A7%D9%84%D9%83%D8%A7%D8%AB%D9%88%D9%84%D9%8A%D9%83%D9%8A%D8%A9_%D8%AD%D8%B3%D8%A8_%D8%A7%D9%84%D8%A8%D9%84%D8%AF

Event Timeline

ssastry raised the priority of this task from to Low.
ssastry updated the task description. (Show Details)
ssastry subscribed.

After 4d1551535c5a2b8cfbdb70b83ca88bb562ee6138 it now rt's as,

[[Foo]]
{|
|- title="foo" | 
|}

which is arguably more correct.

We have a test for this called, "RT-ed inter-element separators should be valid separators".

Change 237182 had a related patch set uploaded (by Arlolra):
Content on table start / row is all attributes

https://gerrit.wikimedia.org/r/237182

T95131#1618958 was very wrong. Content on table start / row is all attributes. With that patch,

λ (T95131) cat t | node parse --wt2wt
{|
|- title="foo" | [[Foo]]
|}

Change 237182 merged by jenkins-bot:
Content on table start / row is all attributes

https://gerrit.wikimedia.org/r/237182

Arlolra claimed this task.