Page MenuHomePhabricator
Create Task
Maniphest T95308

Bad formats cause citoid to crash
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Check for formats such as 'badformat' in server endpoint

Details

SubjectRepoBranchLines +/-
Update citoid to 7e3ee47mediawiki/services/citoid/deploymaster+12 K -302 K
Explicitly define allowed formatsmediawiki/services/citoidmaster+62 -27
Customize query in gerrit

Related Objects

Event Timeline

Mvolz created this task.Apr 7 2015, 4:14 PM
Mvolz claimed this task.
Mvolz raised the priority of this task from to Unbreak Now!.
Mvolz updated the task description. (Show Details)
Mvolz added a project: Citoid.
Mvolz moved this task to Service on the Citoid board.
Mvolz subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2015, 4:14 PM
gerritbot subscribed.Apr 13 2015, 2:41 PM

Change 203828 had a related patch set uploaded (by Mvolz):
[WIP] Explicitly define allowed formats

https://gerrit.wikimedia.org/r/203828

gerritbot added a project: Patch-For-Review.Apr 13 2015, 2:41 PM
gerritbot added a comment.Apr 14 2015, 10:30 AM

Change 203828 merged by Mobrovac:
Explicitly define allowed formats

https://gerrit.wikimedia.org/r/203828

• mobrovac moved this task from Service to Zotero on the Citoid board.Apr 14 2015, 10:54 AM
• mobrovac moved this task from Zotero to Waiting on Deploy on the Citoid board.
• mobrovac removed a project: Patch-For-Review.
• mobrovac set Security to None.
• mobrovac removed a subscriber: gerritbot.
Mvolz mentioned this in rGCIT352d11587cac: Explicitly define allowed formats.Apr 14 2015, 10:58 AM
gerritbot added a comment.Apr 22 2015, 3:45 PM

Change 205872 had a related patch set uploaded (by Mobrovac):
Update citoid to 7e3ee47

https://gerrit.wikimedia.org/r/205872

gerritbot added a project: Patch-For-Review.Apr 22 2015, 3:45 PM
gerritbot added a comment.Apr 22 2015, 4:46 PM

Change 205872 merged by Mobrovac:
Update citoid to 7e3ee47

https://gerrit.wikimedia.org/r/205872

Jdforrester-WMF closed this task as Resolved.Apr 22 2015, 4:59 PM
Jdforrester-WMF added projects: WMF-deploy-2015-04-22_(1.26wmf3), VisualEditor 2014/15 Q4 blockers.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
• mobrovac mentioned this in rGCIDa343b09282ce: Update citoid to 7e3ee47.Apr 22 2015, 5:23 PM
Jdforrester-WMF removed a project: Patch-For-Review.May 6 2015, 10:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL