Page MenuHomePhabricator
Create Task
Maniphest T95432

VE save/load performance tracking for desktop and mobile are comingled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Apparently.

Details

SubjectRepoBranchLines +/-
Set targetName for apiLoad and restbaseLoad metrics to the correct values againmediawiki/extensions/VisualEditorwmf/1.25wmf24+13 -8
Set targetName for apiLoad and restbaseLoad metrics to the correct values againmediawiki/extensions/VisualEditorwmf/1.26wmf1+13 -8
Set targetName for apiLoad and restbaseLoad metrics to the correct values againmediawiki/extensions/VisualEditormaster+13 -8
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Apr 8 2015, 3:36 PM
Jdforrester-WMF raised the priority of this task from to Needs Triage.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-Performance.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2015, 3:36 PM
Catrope subscribed.Apr 8 2015, 6:23 PM

Yes, they are, sorry :( . I had to do that to unbreak things after TargetLoader was merged. Now that Alex has TargetLoader-ified MobileFrontend, I think we can bring un-comingle them again.

Jdforrester-WMF triaged this task as High priority.Apr 8 2015, 6:27 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.Apr 8 2015, 7:13 PM
Jdforrester-WMF moved this task from Nominated to Backlog: Urgent Fixes on the VisualEditor 2014/15 Q4 blockers board.
Catrope assigned this task to Krenair.Apr 8 2015, 7:27 PM
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.Apr 9 2015, 11:26 AM
Krenair added a subscriber: ori.Apr 9 2015, 12:13 PM

Caused by patch for T93156

Krenair added a comment.Apr 9 2015, 12:49 PM
In T95432#1191022, @Catrope wrote:

Now that Alex has TargetLoader-ified MobileFrontend, I think we can bring un-comingle them again.

I don't think fixing this depended on changing MobileFrontend. MobileViewTarget is in VE-MW.

gerritbot subscribed.Apr 9 2015, 12:58 PM

Change 203048 had a related patch set uploaded (by Alex Monk):
Set targetName for apiLoad and restbaseLoad metrics to the correct values again

https://gerrit.wikimedia.org/r/203048

gerritbot added a project: Patch-For-Review.Apr 9 2015, 12:58 PM
gerritbot added a comment.Apr 9 2015, 5:21 PM

Change 203113 had a related patch set uploaded (by Jforrester):
Set targetName for apiLoad and restbaseLoad metrics to the correct values again

https://gerrit.wikimedia.org/r/203113

gerritbot added a comment.Apr 9 2015, 5:25 PM

Change 203115 had a related patch set uploaded (by Jforrester):
Set targetName for apiLoad and restbaseLoad metrics to the correct values again

https://gerrit.wikimedia.org/r/203115

gerritbot added a comment.Apr 9 2015, 5:25 PM

Change 203048 merged by jenkins-bot:
Set targetName for apiLoad and restbaseLoad metrics to the correct values again

https://gerrit.wikimedia.org/r/203048

Krenair mentioned this in rEVED19dc7d31fec3: Set targetName for apiLoad and restbaseLoad metrics to the correct values again.Apr 9 2015, 5:26 PM
gerritbot added a comment.Apr 9 2015, 6:25 PM

Change 203113 merged by jenkins-bot:
Set targetName for apiLoad and restbaseLoad metrics to the correct values again

https://gerrit.wikimedia.org/r/203113

gerritbot added a comment.Apr 9 2015, 6:25 PM

Change 203115 merged by jenkins-bot:
Set targetName for apiLoad and restbaseLoad metrics to the correct values again

https://gerrit.wikimedia.org/r/203115

Jdforrester-WMF mentioned this in rEVED706458ae3562: Set targetName for apiLoad and restbaseLoad metrics to the correct values again.Apr 9 2015, 6:26 PM
Jdforrester-WMF mentioned this in rEVED5ea078abeda6: Set targetName for apiLoad and restbaseLoad metrics to the correct values again.
Jdforrester-WMF closed this task as Resolved.Apr 9 2015, 10:18 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-01_(1.25wmf24), WMF-deploy-2015-04-08_(1.26wmf1), WMF-deploy-2015-04-15_(1.26wmf2); removed Patch-For-Review.
Jdforrester-WMF moved this task from Backlog: Urgent Fixes to Done on the VisualEditor 2014/15 Q4 blockers board.
Jdforrester-WMF moved this task from Bug Fixes to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 16 2015, 9:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL