Maniphest T96036

submit=Search in Wikibase special page urls
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Apr 14 2015, 3:55 PM

Tags

Referenced Files

None

Subscribers

Lydia_Pintscher

Description

when I click submit on Wikibase special pages, "submit=Search" or similar becomes part of the special page url. that should be in the url.

Special:ItemByTitle?site=frwiki&page=&submit=Search

for pages that use GET method in the forms.

Details

	Subject	Repo	Branch	Lines +/-
	Remove "submit=Go" from Special:GoToLinkedPage	mediawiki/extensions/Wikibase	master	+3 -10
	Remove "submit=Find" from Special:EntitiesWithout*	mediawiki/extensions/Wikibase	master	+2 -2
	Remove "submit=Search" from Special:ItemDisambiguation	mediawiki/extensions/Wikibase	master	+2 -2
	Remove "submit=Search" from Special:ItemByTitle	mediawiki/extensions/Wikibase	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T96040 Wikibase special pages (tracking)
		Resolved		Ricordisamoa	T96036 submit=Search in Wikibase special page urls

Event Timeline

aude created this task.Apr 14 2015, 3:55 PM

aude raised the priority of this task from to Low.

aude updated the task description. (Show Details)

aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.

aude added subscribers: Aklapper, aude.

aude mentioned this in T96035: Support $wgUseMediaWikiUIEverywhere in Wikibase forms.Apr 14 2015, 4:13 PM

aude added a parent task: T96040: Wikibase special pages (tracking).Apr 14 2015, 4:37 PM

What should the URL look like instead?

JanZerebecki moved this task from incoming to needs discussion or investigation on the Wikidata board.May 16 2015, 6:53 PM

Ricordisamoa claimed this task.Aug 31 2015, 7:59 PM

Change 235080 had a related patch set uploaded (by Ricordisamoa):
Remove "submit=Search" from Special:ItemByTitle

https://gerrit.wikimedia.org/r/235080

gerritbot added a project: Patch-For-Review.Aug 31 2015, 8:21 PM

Ricordisamoa added a project: good first task.Aug 31 2015, 8:52 PM

With this patch it will be gone

Is this the expected behavior?

Change 235080 merged by jenkins-bot:
Remove "submit=Search" from Special:ItemByTitle

https://gerrit.wikimedia.org/r/235080

Addshore mentioned this in rEWBA731d3d623a22: Remove "submit=Search" from Special:ItemByTitle.Sep 1 2015, 12:57 PM

Diffusion mentioned this in rMEXT0846dc53bd30: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 1 2015, 12:57 PM

Ricordisamoa removed a project: Patch-For-Review.Sep 1 2015, 1:55 PM

Ricordisamoa set Security to None.

Ricordisamoa edited subscribers, added: Ricordisamoa; removed: gerritbot.Sep 2 2015, 10:26 PM

• Jonas closed this task as Resolved.Sep 8 2015, 9:02 AM

Not only for Special:ItemByTitle, as per description.

Change 238093 had a related patch set uploaded (by Ricordisamoa):
Remove "submit=Search" from Special:ItemDisambiguation

https://gerrit.wikimedia.org/r/238093

gerritbot added a project: Patch-For-Review.Sep 14 2015, 6:16 AM

Change 238093 merged by jenkins-bot:
Remove "submit=Search" from Special:ItemDisambiguation

https://gerrit.wikimedia.org/r/238093

Diffusion mentioned this in rMEXTf2d8f0a5bf04: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 14 2015, 9:01 AM

Ricordisamoa mentioned this in rEWBA43a659967cb1: Remove "submit=Search" from Special:ItemDisambiguation.Sep 14 2015, 9:02 AM

Ricordisamoa removed a project: Patch-For-Review.Sep 14 2015, 9:59 PM

Change 238523 had a related patch set uploaded (by Ricordisamoa):
Remove "submit=Find" from Special:EntitiesWithout*

https://gerrit.wikimedia.org/r/238523

gerritbot added a project: Patch-For-Review.Sep 15 2015, 6:46 PM

Change 238523 merged by jenkins-bot:
Remove "submit=Find" from Special:EntitiesWithout*

https://gerrit.wikimedia.org/r/238523

Ricordisamoa mentioned this in rEWBAf80214d0a7f9: Remove "submit=Find" from Special:EntitiesWithout*.Sep 16 2015, 3:54 PM

Diffusion mentioned this in rMEXTf1fbb56c92f5: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 16 2015, 3:54 PM

Ricordisamoa removed a project: Patch-For-Review.Sep 16 2015, 3:58 PM

Change 238776 had a related patch set uploaded (by Ricordisamoa):
Remove "submit=Go" from Special:GoToLinkedPage

https://gerrit.wikimedia.org/r/238776

gerritbot added a project: Patch-For-Review.Sep 16 2015, 4:09 PM

Change 238776 merged by jenkins-bot:
Remove "submit=Go" from Special:GoToLinkedPage

https://gerrit.wikimedia.org/r/238776

Diffusion mentioned this in rMEXT401fa9c07272: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 18 2015, 3:41 PM

Ricordisamoa mentioned this in rEWBA5011cc3e4944: Remove "submit=Go" from Special:GoToLinkedPage.Sep 18 2015, 3:41 PM

Ricordisamoa removed a project: Patch-For-Review.Sep 18 2015, 3:57 PM

I can't find any occurrences left.

\o/