[Task] Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this (action=compare)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Apr 15 2015, 7:44 AM

Description

we should present a more friendly error message for this, than an uncaught exception.

/w/api.php?fromrev=12093&action=compare&torev=12094&maxlag=5&format=json MWException from line 791 of /srv/mediawiki/php-1.26wmf1/includes/diff/DifferenceEngine.php: Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this.
#0 /srv/mediawiki/php-1.26wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/Diff/EntityContentDiffView.php(218): DifferenceEngine->generateContentDiffBody()
#1 /srv/mediawiki/php-1.26wmf1/includes/diff/DifferenceEngine.php(733): Wikibase\Repo\Diff\EntityContentDiffView->generateContentDiffBody()
#2 /srv/mediawiki/php-1.26wmf1/includes/api/ApiComparePages.php(65): DifferenceEngine->getDiffBody()
#3 /srv/mediawiki/php-1.26wmf1/includes/api/ApiMain.php(1043): ApiComparePages->execute()
#4 /srv/mediawiki/php-1.26wmf1/includes/api/ApiMain.php(394): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.26wmf1/includes/api/ApiMain.php(367): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.26wmf1/api.php(90): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): include()

Related Objects

Mentioned Here: T52202: Diffing between different content models throws a fatal error

Event Timeline

aude created this task.Apr 15 2015, 7:44 AM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.

aude subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2015, 7:44 AM

JanZerebecki triaged this task as Low priority.May 16 2015, 6:32 PM

JanZerebecki set Security to None.

Suggestions, what it should say?
Why don't we implement this?

JanZerebecki moved this task from incoming to needs discussion or investigation on the Wikidata board.May 16 2015, 6:36 PM

Ricordisamoa subscribed.Aug 22 2015, 1:53 PM

• Jonas renamed this task from Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this (action=compare) to [Task] Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this (action=compare).Nov 2 2015, 3:31 PM

matej_suchanek added a project: TestMe.Dec 8 2017, 4:20 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 8 2017, 4:20 PM

It looks like this was fixed along with T52202: Diffing between different content models throws a fatal error. I can not reproduce the error any more with the provided example URL.

[Task] Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this (action=compare)Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

[Task] Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this (action=compare)
Closed, ResolvedPublic
Actions