Select all produces an incorrect DOM range when the page ends in a block slug
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Apr 17 2015, 11:16 AM

Description

Go to any page with a block slug at the end (e.g. aliens.html). Press CTRL+A. The view selection range end is too early in the document.

Details

	Subject	Repo	Branch	Lines +/-
	Fix getNodeAndOffset for block slugs	VisualEditor/VisualEditor	master	+11 -3

Customize query in gerrit

Related Objects

Mentioned In: rGVED9dd8ad58517c: Fix getNodeAndOffset for block slugs
Mentioned Here: T96671: Select all + overwrite fails on a document that starts and ends with a block slug

Event Timeline

Esanders created this task.Apr 17 2015, 11:16 AM

Esanders raised the priority of this task from to Needs Triage.

Esanders updated the task description. (Show Details)

Esanders added a project: VisualEditor.

Esanders added subscribers: Esanders, dchan.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2015, 11:16 AM

This appears to be caused by block slugs - if you remove all block aliens from the document the bug goes away.

Change 205580 had a related patch set uploaded (by Divec):
Fix getNodeAndOffset for block slugs

https://gerrit.wikimedia.org/r/205580

gerritbot added a project: Patch-For-Review.Apr 21 2015, 11:22 AM

Change 205580 fixes the view selection. But there's a separate issue that the model selection is not in fact correct: a CTRL+A selection should start at DM position 1, not position 0.

dchan renamed this task from Select all produces strange offsets to Select all produces an incorrect DOM range.Apr 21 2015, 11:29 AM

dchan renamed this task from Select all produces an incorrect DOM range to Select all produces an incorrect DOM range when the page ends in a block slug.

dchan updated the task description. (Show Details)

dchan set Security to None.

See T96671 for the related issue.

Jdforrester-WMF assigned this task to dchan.Apr 22 2015, 12:43 AM

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF added projects: VisualEditor-ContentEditable, VisualEditor 2014/15 Q4 blockers.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF closed this task as Resolved.Apr 22 2015, 7:12 PM

Jdforrester-WMF edited projects, added WMF-deploy-2015-04-29_(1.26wmf4); removed Patch-For-Review.

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 22 2015, 7:14 PM

Change 205580 merged by jenkins-bot:
Fix getNodeAndOffset for block slugs

https://gerrit.wikimedia.org/r/205580