Page MenuHomePhabricator
Create Task
Maniphest T96358

NPE crash from page.ToCHandler$2.onDrawerOpened when opening the left hamburger (TOC) before page is loaded
Closed, ResolvedPublic
Actions

Description

USER_COMMENT= see task topic
ANDROID_VERSION=4.4.4
APP_VERSION_NAME=2.0-alpha-2015-04-14
BRAND=google
PHONE_MODEL=Nexus 5
CUSTOM_DATA=api = he.m.wikipedia.org
title = עמוד ראשי

STACK_TRACE=java.lang.NullPointerException
at org.wikipedia.page.ToCHandler$2.onDrawerOpened(ToCHandler.java:101)
at android.support.v4.widget.DrawerLayout.dispatchOnDrawerOpened(DrawerLayout.java:656)
at android.support.v4.widget.DrawerLayout.updateDrawerState(DrawerLayout.java:616)
at android.support.v4.widget.DrawerLayout$ViewDragCallback.onViewDragStateChanged(DrawerLayout.java:1627)
at android.support.v4.widget.ViewDragHelper.setDragState(ViewDragHelper.java:873)
at android.support.v4.widget.ViewDragHelper$2.run(ViewDragHelper.java:335)
at android.os.Handler.handleCallback(Handler.java:733)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:136)
at android.app.ActivityThread.main(ActivityThread.java:5001)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
at dalvik.system.NativeStart.main(Native Method)

Details

SubjectRepoBranchLines +/-
Fix possible crash when pulling out ToC (for real).apps/android/wikipediamaster+3 -0
Fix possible NPE when pulling out ToC.apps/android/wikipediamaster+8 -2
Disable pulling of ToC before page has finished loading.apps/android/wikipediamaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Matanya created this task.Apr 17 2015, 11:34 AM
Matanya raised the priority of this task from to Needs Triage.
Matanya updated the task description. (Show Details)
Matanya added a project: Wikipedia-Android-App-Backlog.
Matanya subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2015, 11:34 AM
Matanya renamed this task from app crashes when clicking the left hambuerger before main page is loaded to app crashes when clicking the left hambuerger (TOC) before main page is loaded.Apr 17 2015, 11:35 AM
Matanya set Security to None.
Krenair subscribed.Apr 17 2015, 2:53 PM

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8263316 may be helpful

Krenair renamed this task from app crashes when clicking the left hambuerger (TOC) before main page is loaded to NPE crash from page.ToCHandler$2.onDrawerOpened when opening the left hamburger (TOC) before page is loaded.Apr 19 2015, 8:33 PM
gerritbot subscribed.Apr 20 2015, 12:34 PM

Change 205234 had a related patch set uploaded (by Dbrant):
Disable pulling of ToC before page has finished loading.

https://gerrit.wikimedia.org/r/205234

gerritbot added a project: Patch-For-Review.Apr 20 2015, 12:34 PM
Dbrant claimed this task.Apr 20 2015, 12:35 PM
Dbrant added a project: Mobile-App-Sprint-55-Android.
Dbrant moved this task from To Do to Code Review on the Mobile-App-Sprint-55-Android board.
Dbrant subscribed.
Dbrant moved this task from Needs Triage to Current Sprint on the Wikipedia-Android-App-Backlog board.Apr 20 2015, 12:40 PM
gerritbot added a comment.Apr 21 2015, 1:10 AM

Change 205234 merged by jenkins-bot:
Disable pulling of ToC before page has finished loading.

https://gerrit.wikimedia.org/r/205234

• bearND mentioned this in rAPAW498364a067db: Disable pulling of ToC before page has finished loading..Apr 21 2015, 1:14 AM
• bearND moved this task from Code Review to Ready for Signoff on the Mobile-App-Sprint-55-Android board.Apr 21 2015, 1:15 AM
• Deskana closed this task as Resolved.Apr 23 2015, 8:51 PM
• Deskana moved this task from Ready for Signoff to Done on the Mobile-App-Sprint-55-Android board.
• Deskana subscribed.
• Deskana moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Apr 24 2015, 5:21 PM
Dbrant reopened this task as Open.May 2 2015, 8:26 PM

Still happening in the current production release :(

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8332714
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8332724
...

Dbrant triaged this task as High priority.May 2 2015, 8:26 PM
Dbrant added a project: Mobile-App-Sprint-56-Android.
Dbrant moved this task from To Do to Doing on the Mobile-App-Sprint-56-Android board.May 4 2015, 4:13 PM
gerritbot added a comment.May 4 2015, 4:27 PM

Change 208663 had a related patch set uploaded (by Dbrant):
Fix possible NPE when pulling out ToC.

https://gerrit.wikimedia.org/r/208663

Dbrant moved this task from Doing to Code Review on the Mobile-App-Sprint-56-Android board.May 4 2015, 4:27 PM
gerritbot added a comment.May 4 2015, 4:51 PM

Change 208663 merged by jenkins-bot:
Fix possible NPE when pulling out ToC.

https://gerrit.wikimedia.org/r/208663

• bearND mentioned this in rAPAW2699448b7a08: Fix possible NPE when pulling out ToC..May 4 2015, 4:51 PM
• bearND moved this task from Code Review to QA Signoff on the Mobile-App-Sprint-56-Android board.May 4 2015, 4:51 PM
Dbrant merged a task: T98136: Attempt to invoke virtual method 'void org.wikipedia.analytics.ToCInteractionFunnel.logOpen()' on a null object reference.May 5 2015, 12:30 PM
Dbrant merged a task: T98242: Clicking on the icon for content menu in offline mode crashes the app.May 5 2015, 11:49 PM
Dbrant added a subscriber: Etonkovidova.
Dbrant added a comment.May 6 2015, 12:04 AM

@Etonkovidova Please test with today's alpha (or later).

Dbrant edited projects, added Mobile-App-Sprint-57-Android; removed Mobile-App-Sprint-56-Android.May 11 2015, 2:05 PM
Dbrant moved this task from To Do to Design Signoff on the Mobile-App-Sprint-57-Android board.
Dbrant moved this task from Design Signoff to QA Signoff on the Mobile-App-Sprint-57-Android board.
Etonkovidova added a comment.May 14 2015, 10:45 PM

Checked with 2.0.101-alpha-2015-05-05 large articles - 'Barack Obama', 'India', 'Cat'.

Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Sprint-57-Android board.May 14 2015, 10:45 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Sprint-57-Android board.May 15 2015, 7:04 PM
Dbrant added a project: Mobile-App-Sprint-58-Android.May 27 2015, 2:44 PM

Still bloody happening :(((
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8393768

gerritbot added a comment.Jun 5 2015, 3:41 PM

Change 216110 had a related patch set uploaded (by Dbrant):
Fix possible crash when pulling out ToC (for real).

https://gerrit.wikimedia.org/r/216110

Dbrant moved this task from To Do to Code Review on the Mobile-App-Sprint-58-Android board.Jun 5 2015, 3:41 PM
• bearND moved this task from Code Review to QA Signoff on the Mobile-App-Sprint-58-Android board.Jun 5 2015, 7:56 PM
gerritbot added a comment.Jun 5 2015, 8:02 PM

Change 216110 merged by jenkins-bot:
Fix possible crash when pulling out ToC (for real).

https://gerrit.wikimedia.org/r/216110

• bearND mentioned this in rAPAWc3f665be6404: Fix possible crash when pulling out ToC (for real)..Jun 5 2015, 8:02 PM
• KLans_WMF edited projects, added Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together; removed Mobile-App-Sprint-58-Android, Mobile-App-Sprint-57-Android, Mobile-App-Sprint-55-Android.Jun 8 2015, 5:21 PM
• KLans_WMF moved this task from To Do to QA Signoff on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.
Etonkovidova added a comment.Jun 10 2015, 10:01 PM

Checked 2.0.102-alpha-2015-06-09 on GT-P7510(tablet 4.0.4) on English wiki.

The content can be pulled/clicked before the whole article is fully loaded.

Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.Jun 10 2015, 10:03 PM
• Deskana unsubscribed.Jun 10 2015, 10:04 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.Jun 11 2015, 12:03 AM
Dbrant closed this task as Resolved.Jun 23 2015, 2:51 AM
• bearND mentioned this in T103788: Android Production Release 2.0.105.Jun 25 2015, 6:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits