Page MenuHomePhabricator
Create Task
Maniphest T96838

Create unit tests for ve.ce.Document#getNodeAndOffset
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Tests for getNodeAndOffset (matching current quirky behaviour)VisualEditor/VisualEditormaster+166 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 22 2015, 11:51 AM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.
Esanders added subscribers: Esanders, dchan.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2015, 11:51 AM
gerritbot subscribed.Apr 23 2015, 10:12 AM

Change 206094 had a related patch set uploaded (by Divec):
Tests for getNodeAndOffset (matching current quirky behaviour)

https://gerrit.wikimedia.org/r/206094

gerritbot added a project: Patch-For-Review.Apr 23 2015, 10:12 AM
Jdforrester-WMF closed this task as Resolved.Apr 23 2015, 3:55 PM
Jdforrester-WMF assigned this task to dchan.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added VisualEditor-ContentEditable, Technical-Debt, WMF-deploy-2015-04-29_(1.26wmf4), VisualEditor 2014/15 Q4 blockers; removed Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.Apr 23 2015, 3:57 PM

Change 206094 merged by jenkins-bot:
Tests for getNodeAndOffset (matching current quirky behaviour)

https://gerrit.wikimedia.org/r/206094

dchan mentioned this in rGVEDbea61392ae83: Tests for getNodeAndOffset (matching current quirky behaviour).Apr 23 2015, 3:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL