Wrap commit message
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Fomafix
	Apr 25 2015, 7:25 PM

Description

The commit message should wrapped at 70 to 100 characters per line. (https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines)

Gerrit Patch Uploader uses <textarea cols="75"> with a proportional font for the commit message. This shows a wrapping between about 45 and 150 characters per line on screen. But the submitted message is not wrapped and is in one line.

It would be nice to have an automatic wrapped message. It would be useful when the wrapping is conform to RFC 3676.

Event Timeline

Fomafix created this task.Apr 25 2015, 7:25 PM

Fomafix raised the priority of this task from to Needs Triage.

Fomafix updated the task description. (Show Details)

Fomafix added a project: Tool-Gerrit-Patch-Uploader.

Fomafix subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2015, 7:25 PM

Line wrapping should be done by the author of a patch, not by a tool.

I'm not quite sure how you get wrapping at 45 characters, though. The point of having a textarea with cols="75" (which maybe should be more, say 100) is to give the user space to do the wrapping manually.

In T97229#1236186, @valhallasw wrote:

I'm not quite sure how you get wrapping at 45 characters, though.

I can enter 45 M or 161 l, then I am at the end of the line.

Ricordisamoa subscribed.Jul 17 2015, 6:27 PM

Wrap commit messageOpen, Needs TriagePublicActions

Description

Event Timeline

Wrap commit message
Open, Needs TriagePublic
Actions