Page MenuHomePhabricator
Create Task
Maniphest T97516

Use consistent error state for text input widgets
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Use consistent error state for text input widgets. We have error state in three places and each looks different.

pasted_file (476×701 px, 33 KB)

pasted_file (121×1 px, 15 KB)

pasted_file (475×506 px, 25 KB)

Details

SubjectRepoBranchLines +/-
Use consistent error state for text input widgetsVisualEditor/VisualEditormaster+20 -14
ve.ui.MWParameterPage: Remove dead CSSmediawiki/extensions/VisualEditormaster+0 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Apr 29 2015, 10:34 AM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: VisualEditor.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2015, 10:34 AM
matmarex added a subtask: T97403: Create error state for TextInputWidget.Apr 29 2015, 10:34 AM
matmarex claimed this task.Apr 29 2015, 10:49 PM
matmarex triaged this task as Low priority.
matmarex set Security to None.
Jdforrester-WMF subscribed.Apr 29 2015, 10:53 PM

I like the one in the template dialog best. But eh.

matmarex added a comment.Apr 29 2015, 10:57 PM

That is what we're implementing for the MediaWiki theme in T97403 (except for the blue/red border on focus, which is clearly a bug, present since the last design change of input widgets).

Jdforrester-WMF closed subtask T97403: Create error state for TextInputWidget as Resolved.Apr 30 2015, 12:59 AM
gerritbot subscribed.Apr 30 2015, 8:18 PM

Change 207935 had a related patch set uploaded (by Bartosz Dziewoński):
Use consistent error state for text input widgets

https://gerrit.wikimedia.org/r/207935

gerritbot added a project: Patch-For-Review.Apr 30 2015, 8:18 PM

Change 207942 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWParameterPage: Remove dead CSS

https://gerrit.wikimedia.org/r/207942

Jdforrester-WMF closed this task as Resolved.May 1 2015, 12:46 AM
Jdforrester-WMF added projects: VisualEditor-MediaWiki, UI-Standardization, VisualEditor 2014/15 Q4 blockers.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF edited projects, added WMF-deploy-2015-05-06_(1.26wmf5); removed Patch-For-Review.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.May 1 2015, 12:47 AM

Change 207942 merged by jenkins-bot:
ve.ui.MWParameterPage: Remove dead CSS

https://gerrit.wikimedia.org/r/207942

gerritbot added a comment.May 1 2015, 12:47 AM

Change 207935 merged by jenkins-bot:
Use consistent error state for text input widgets

https://gerrit.wikimedia.org/r/207935

matmarex mentioned this in rEVED2608a6c66b64: ve.ui.MWParameterPage: Remove dead CSS.May 1 2015, 12:47 AM
matmarex mentioned this in rGVEDc5284c7bb875: Use consistent error state for text input widgets.
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.May 6 2015, 12:58 AM
Jdforrester-WMF added a project: User-notice.May 8 2015, 4:36 PM
gpaumier moved this task from To Triage to Announce in next Tech/News on the User-notice board.May 8 2015, 4:44 PM
gpaumier removed a project: User-notice.May 8 2015, 10:45 PM
gpaumier subscribed.

Removing User-notice since the change is mostly cosmetic and I don't expect anyone to be confused by this change. Feel free to re-add (soon-ish) if you disagree.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL