Page MenuHomePhabricator

Use consistent error state for text input widgets
Closed, ResolvedPublic1 Estimated Story Points

Description

Use consistent error state for text input widgets. We have error state in three places and each looks different.



Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: VisualEditor.
matmarex added a subscriber: matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2015, 10:34 AM
matmarex triaged this task as Low priority.
matmarex set Security to None.

I like the one in the template dialog best. But eh.

That is what we're implementing for the MediaWiki theme in T97403 (except for the blue/red border on focus, which is clearly a bug, present since the last design change of input widgets).

Change 207935 had a related patch set uploaded (by Bartosz Dziewoński):
Use consistent error state for text input widgets

https://gerrit.wikimedia.org/r/207935

Change 207942 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWParameterPage: Remove dead CSS

https://gerrit.wikimedia.org/r/207942

Change 207942 merged by jenkins-bot:
ve.ui.MWParameterPage: Remove dead CSS

https://gerrit.wikimedia.org/r/207942

Change 207935 merged by jenkins-bot:
Use consistent error state for text input widgets

https://gerrit.wikimedia.org/r/207935

Jdforrester-WMF moved this task from To Triage to Q4 on the VisualEditor board.May 6 2015, 12:58 AM
gpaumier added a subscriber: gpaumier.

Removing User-notice since the change is mostly cosmetic and I don't expect anyone to be confused by this change. Feel free to re-add (soon-ish) if you disagree.