Page MenuHomePhabricator
Create Task
Maniphest T98063

Refactor DI's response processing
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

processResponse is convoluted and tricky, and the transaction_results array holds too many things

*processResponse often duplicates a bunch of switch structure that also exists in the functions that parse out errors, data, and communications status. we can subsume those into processResponse for less duplication
*We should throw an exception with code and retry vars instead of returning an error code and mutating one of the arguments.

Details

Show related patches Customize query in gerrit

Related Objects

Mentioned In
T136665: Move controller code out of GatewayType#processResponse
rMEXT0014487c61d9: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI90212b242db6: Make do_transaction return a PaymentTransactionResponse
rMEXT1ce0aa730b3c: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOIb31cead95876: Start chipping away at getTransactionAllResults
rEDOIaa7a052f1f87: Finish eradicating setTransactionResult
rMEXT9cd8432c4bc9: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXTc6e3013f26ec: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI65ac875799fc: Get rid of more setTransactionResult calls
rMEXTef0a1f4d378e: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI731d44bb8ec7: Replace setTransactionResult calls in Adyen adapter
rEDOI9742cd18b075: Fold parseResponseXX calls into processResponse
rMEXT4270e7454752: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI3e52eb996414: Start refactoring processResponse
rMEXT505c7e5f61f3: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXT8fe3a54a51e0: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOIefef7965e46a: getResponseXX -> parseResponseXX
rMEXTa0f81d68f486: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI7be2535b4b1c: Prepare to prune $transaction_results
rMEXT0465d7e5ad67: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI43810890511f: Remove validation action from transaction_results
rMEXT1532fb4d9a7a: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOId042ea85dae0: Move Final Status out of transaction_results, use consts
rMEXT941acdf2d040: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI7df01fc9b863: Push gateway_params down into data

Event Timeline

Ejegg created this task.May 4 2015, 7:53 PM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: Fundraising-Backlog-Old, Fundraising Sprint James Brown.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2015, 7:53 PM
gerritbot subscribed.May 4 2015, 8:08 PM

Change 208739 had a related patch set uploaded (by Ejegg):
Start refactoring processResponse

https://gerrit.wikimedia.org/r/208739

gerritbot added a project: Patch-For-Review.May 4 2015, 8:08 PM
• atgo moved this task from Backlog to Doing on the Fundraising Sprint James Brown board.May 4 2015, 8:09 PM
gerritbot added a comment.May 5 2015, 1:26 AM

Change 208872 had a related patch set uploaded (by Ejegg):
Move Final Status out of transaction_results, use consts

https://gerrit.wikimedia.org/r/208872

gerritbot added a comment.May 5 2015, 7:57 PM

Change 208275 had a related patch set uploaded (by Ejegg):
Push gateway_params down into data

https://gerrit.wikimedia.org/r/208275

gerritbot added a comment.May 5 2015, 7:57 PM

Change 208295 had a related patch set uploaded (by Ejegg):
getResponseXX -> parseResponseXX

https://gerrit.wikimedia.org/r/208295

gerritbot added a comment.May 5 2015, 7:57 PM

Change 208276 had a related patch set uploaded (by Ejegg):
Prepare to prune $transaction_results

https://gerrit.wikimedia.org/r/208276

Ejegg updated the task description. (Show Details)May 5 2015, 8:01 PM
Ejegg set Security to None.
Ejegg edited a custom field.
gerritbot added a comment.May 6 2015, 12:08 AM

Change 208275 merged by jenkins-bot:
Push gateway_params down into data

https://gerrit.wikimedia.org/r/208275

awight mentioned this in rEDOI7df01fc9b863: Push gateway_params down into data.May 6 2015, 12:08 AM
Ejegg mentioned this in rMEXT941acdf2d040: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 6 2015, 12:08 AM
gerritbot added a comment.May 6 2015, 12:28 AM

Change 208872 merged by jenkins-bot:
Move Final Status out of transaction_results, use consts

https://gerrit.wikimedia.org/r/208872

awight mentioned this in rEDOId042ea85dae0: Move Final Status out of transaction_results, use consts.May 6 2015, 12:28 AM
Ejegg mentioned this in rMEXT1532fb4d9a7a: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 6 2015, 12:28 AM
gerritbot added a comment.May 6 2015, 5:22 PM

Change 209154 had a related patch set uploaded (by Ejegg):
Fold parseResponseXX calls into processResponse

https://gerrit.wikimedia.org/r/209154

gerritbot added a comment.May 7 2015, 12:49 AM

Change 209408 had a related patch set uploaded (by Ejegg):
Replace setTransactionResult calls in Adyen adapter

https://gerrit.wikimedia.org/r/209408

gerritbot added a comment.May 7 2015, 7:59 PM

Change 209612 had a related patch set uploaded (by Ejegg):
Remove validation action from transaction_results

https://gerrit.wikimedia.org/r/209612

gerritbot added a comment.May 7 2015, 11:01 PM

Change 209612 merged by jenkins-bot:
Remove validation action from transaction_results

https://gerrit.wikimedia.org/r/209612

awight mentioned this in rEDOI43810890511f: Remove validation action from transaction_results.May 7 2015, 11:01 PM
Ejegg mentioned this in rMEXT0465d7e5ad67: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 7 2015, 11:01 PM
gerritbot added a comment.May 7 2015, 11:08 PM

Change 208276 merged by jenkins-bot:
Prepare to prune $transaction_results

https://gerrit.wikimedia.org/r/208276

awight mentioned this in rEDOI7be2535b4b1c: Prepare to prune $transaction_results.May 7 2015, 11:08 PM
Ejegg mentioned this in rMEXTa0f81d68f486: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 7 2015, 11:08 PM
gerritbot added a comment.May 7 2015, 11:11 PM

Change 208295 merged by jenkins-bot:
getResponseXX -> parseResponseXX

https://gerrit.wikimedia.org/r/208295

awight mentioned this in rEDOIefef7965e46a: getResponseXX -> parseResponseXX.May 7 2015, 11:11 PM
Ejegg mentioned this in rMEXT8fe3a54a51e0: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 7 2015, 11:11 PM
gerritbot added a comment.May 7 2015, 11:41 PM

Change 208739 merged by jenkins-bot:
Start refactoring processResponse

https://gerrit.wikimedia.org/r/208739

Ejegg mentioned this in rMEXT505c7e5f61f3: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 7 2015, 11:41 PM
awight mentioned this in rEDOI3e52eb996414: Start refactoring processResponse.May 7 2015, 11:41 PM
gerritbot added a comment.May 8 2015, 5:23 PM

Change 209154 merged by jenkins-bot:
Fold parseResponseXX calls into processResponse

https://gerrit.wikimedia.org/r/209154

Ejegg mentioned this in rMEXT4270e7454752: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 8 2015, 5:23 PM
Ejegg mentioned this in rEDOI9742cd18b075: Fold parseResponseXX calls into processResponse.
gerritbot added a comment.May 12 2015, 5:39 PM

Change 210218 had a related patch set uploaded (by Ejegg):
Create PaymentResult from PaymentTransactionResponse

https://gerrit.wikimedia.org/r/210218

gerritbot added a comment.May 12 2015, 5:39 PM

Change 209779 had a related patch set uploaded (by Ejegg):
Get rid of more setTransactionResult calls

https://gerrit.wikimedia.org/r/209779

gerritbot added a comment.May 12 2015, 5:39 PM

Change 209785 had a related patch set uploaded (by Ejegg):
Finish eradicating setTransactionResult

https://gerrit.wikimedia.org/r/209785

gerritbot added a comment.May 12 2015, 5:39 PM

Change 209791 had a related patch set uploaded (by Ejegg):
Start chipping away at getTransactionAllResults

https://gerrit.wikimedia.org/r/209791

Ejegg added a project: Fundraising Sprint Kraftwerk.May 13 2015, 10:51 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Kraftwerk board.
gerritbot added a comment.May 14 2015, 9:31 PM

Change 211046 had a related patch set uploaded (by Ejegg):
Make do_transaction return a PaymentTransactionResponse

https://gerrit.wikimedia.org/r/211046

gerritbot added a comment.May 15 2015, 5:30 PM

Change 210218 abandoned by Ejegg:
Create PaymentResult from PaymentTransactionResponse

Reason:
Rolled into I5fc027cab109

https://gerrit.wikimedia.org/r/210218

gerritbot added a comment.May 15 2015, 11:52 PM

Change 209408 merged by jenkins-bot:
Replace setTransactionResult calls in Adyen adapter

https://gerrit.wikimedia.org/r/209408

awight mentioned this in rEDOI731d44bb8ec7: Replace setTransactionResult calls in Adyen adapter.May 15 2015, 11:52 PM
Ejegg mentioned this in rMEXTef0a1f4d378e: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 15 2015, 11:52 PM
gerritbot added a comment.May 15 2015, 11:58 PM

Change 209779 merged by jenkins-bot:
Get rid of more setTransactionResult calls

https://gerrit.wikimedia.org/r/209779

awight mentioned this in rEDOI65ac875799fc: Get rid of more setTransactionResult calls.May 15 2015, 11:58 PM
Ejegg mentioned this in rMEXTc6e3013f26ec: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 15 2015, 11:58 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Kraftwerk board.May 16 2015, 12:06 AM
gerritbot added a comment.May 16 2015, 12:10 AM

Change 209785 merged by jenkins-bot:
Finish eradicating setTransactionResult

https://gerrit.wikimedia.org/r/209785

Ejegg mentioned this in rMEXT9cd8432c4bc9: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 16 2015, 12:11 AM
awight mentioned this in rEDOIaa7a052f1f87: Finish eradicating setTransactionResult.May 16 2015, 12:11 AM
gerritbot added a comment.May 16 2015, 12:12 AM

Change 209791 merged by jenkins-bot:
Start chipping away at getTransactionAllResults

https://gerrit.wikimedia.org/r/209791

awight mentioned this in rEDOIb31cead95876: Start chipping away at getTransactionAllResults.May 16 2015, 12:15 AM
Ejegg mentioned this in rMEXT1ce0aa730b3c: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 16 2015, 12:16 AM
gerritbot added a comment.May 16 2015, 12:33 AM

Change 211046 merged by jenkins-bot:
Make do_transaction return a PaymentTransactionResponse

https://gerrit.wikimedia.org/r/211046

awight mentioned this in rEDOI90212b242db6: Make do_transaction return a PaymentTransactionResponse.May 16 2015, 12:34 AM
Ejegg mentioned this in rMEXT0014487c61d9: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 16 2015, 12:34 AM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Kraftwerk board.May 16 2015, 1:23 AM
Ejegg closed this task as Resolved.May 19 2015, 10:12 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Kraftwerk board.
• atgo added a project: Fundraising-Backlog.Jun 30 2015, 10:21 PM
• atgo moved this task from Triage to Closed Sprint Work Q4 1415 on the Fundraising-Backlog board.
awight mentioned this in T136665: Move controller code out of GatewayType#processResponse.Jun 1 2016, 1:58 AM
• DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits