[Regression wmf6] When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ]
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	May 12 2015, 1:56 AM

Description

Steps to reproduce:

1.Open a page with VE
2.Open the link inspector
3.Switch to "External link" section
4.Now type in an invalid external link such as "invalid link"
5.Click on Insert
6.Save the page

Observe that, on CE it is appearing as [invalid link]

Screen Shot 2015-05-11 at 6.54.49 PM.png (364×429 px, 28 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Only create annotations from text input if it is valid	VisualEditor/VisualEditor	master	+7 -4
	Disable 'done'/'insert' button when input invalid	VisualEditor/VisualEditor	master	+11 -2

Customize query in gerrit

Related Objects

Mentioned In: rGVEDaef9cbd12118: Only create annotations from text input if it is valid
rGVED91672cf67006: Disable 'done'/'insert' button when input invalid

Event Timeline

Ryasmeen created this task.May 12 2015, 1:56 AM

Ryasmeen raised the priority of this task from to Needs Triage.

Ryasmeen updated the task description. (Show Details)

Ryasmeen added a project: VisualEditor.

Ryasmeen subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 1:56 AM

Ryasmeen renamed this task from When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ] to [Regression pre-wmf6]When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ].May 12 2015, 2:05 AM

Ryasmeen set Security to None.

Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.

Ryasmeen assigned this task to Esanders.May 12 2015, 5:22 PM

Ryasmeen added a project: VisualEditor-MediaWiki-Links.

Jdforrester-WMF renamed this task from [Regression pre-wmf6]When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ] to [Regression pre-wmf6] When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ].May 12 2015, 5:42 PM

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.

Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.May 13 2015, 6:13 PM

Jdforrester-WMF moved this task from Backlog to Backlog: Urgent Fixes on the VisualEditor 2014/15 Q4 blockers board.May 13 2015, 6:18 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF renamed this task from [Regression pre-wmf6] When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ] to [Regression wmf6] When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ].May 21 2015, 2:18 PM

Change 214599 had a related patch set uploaded (by Esanders):
Disable 'done'/'insert' button when input invalid

https://gerrit.wikimedia.org/r/214599

Change 214600 had a related patch set uploaded (by Esanders):
Only create annotations from text input if it is valid

https://gerrit.wikimedia.org/r/214600

Jdforrester-WMF moved this task from Backlog: Urgent Fixes to Doing on the VisualEditor 2014/15 Q4 blockers board.May 30 2015, 7:22 PM

Change 214599 merged by jenkins-bot:
Disable 'done'/'insert' button when input invalid

https://gerrit.wikimedia.org/r/214599

Change 214600 merged by jenkins-bot:
Only create annotations from text input if it is valid

https://gerrit.wikimedia.org/r/214600

Jdforrester-WMF mentioned this in rGVED91672cf67006: Disable 'done'/'insert' button when input invalid.Jun 1 2015, 6:35 PM

Jdforrester-WMF mentioned this in rGVEDaef9cbd12118: Only create annotations from text input if it is valid.

Jdforrester-WMF closed this task as Resolved.Jun 1 2015, 6:36 PM

Jdforrester-WMF added a project: WMF-deploy-2015-06-09_(1.26wmf9).

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.

Ryasmeen added a project: Verified-in-Phase0.Jun 9 2015, 3:09 PM

Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Jun 17 2015, 11:31 PM

	F163796: Screen Shot 2015-05-11 at 6.54.49 PM.png
	May 12 2015, 1:56 AM

[Regression wmf6] When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ]Closed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[Regression wmf6] When an invalid text is entered as external link, it is appearing on the CE with square brackets [ ]
Closed, ResolvedPublic8 Estimated Story Points
Actions