Page MenuHomePhabricator

"Search within pages" icon broken
Closed, ResolvedPublic

Description

Spotted on betalabs and local master:
http://en.m.wikipedia.beta.wmflabs.org/

Open the search overlay and type in some search query (doesn't matter what). You see (as the first row) a "Search within pages" link, which looks like:

search.png (305×1 px, 26 KB)

and should looks like:

search2.JPG (184×462 px, 13 KB)

Event Timeline

Florian raised the priority of this task from to High.
Florian updated the task description. (Show Details)
Florian added a project: Readers-Web-Backlog.
Florian added a subscriber: Florian.
Florian set Security to None.

According to git bisect this was caused by 210346.

Jdlrobson added a subscriber: Jdlrobson.

It's not using mw-ui-icon and this was being masked by the caching fixes. Doh.

Change 212556 had a related patch set uploaded (by Jdlrobson):
Fix icons in the search overlay

https://gerrit.wikimedia.org/r/212556

Change 212556 merged by jenkins-bot:
Fix icons in the search overlay

https://gerrit.wikimedia.org/r/212556

phuedx removed a project: Patch-For-Review.

One remaining problem that needs to be addressed with relation to this icon to truly call it complete: https://gerrit.wikimedia.org/r/213199