Page MenuHomePhabricator
Create Task
Maniphest T99100

"Search within pages" icon broken
Closed, ResolvedPublic
Actions

Description

Spotted on betalabs and local master:
http://en.m.wikipedia.beta.wmflabs.org/

Open the search overlay and type in some search query (doesn't matter what). You see (as the first row) a "Search within pages" link, which looks like:

search.png (305×1 px, 26 KB)

and should looks like:

search2.JPG (184×462 px, 13 KB)

Details

SubjectRepoBranchLines +/-
Fix icons in the search overlaymediawiki/extensions/MobileFrontendmaster+18 -11
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.May 14 2015, 6:14 PM
Florian raised the priority of this task from to High.
Florian updated the task description. (Show Details)
Florian added a project: Web-Team-Backlog.
Florian subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2015, 6:14 PM
Florian updated the task description. (Show Details)May 14 2015, 6:15 PM
Florian set Security to None.
phuedx subscribed.May 15 2015, 3:57 PM

According to git bisect this was caused by 210346.

phuedx moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.May 15 2015, 4:01 PM
Liuxinyu970226 subscribed.May 18 2015, 11:51 AM
Jdlrobson merged a task: T99667: Search within pages icon broken.May 19 2015, 11:06 AM
Jdlrobson subscribed.

It's not using mw-ui-icon and this was being masked by the caching fixes. Doh.

phuedx moved this task from 2016-17 Q2 to Incoming on the Web-Team-Backlog board.May 19 2015, 11:07 AM
Jdlrobson claimed this task.May 21 2015, 3:17 PM
gerritbot subscribed.May 21 2015, 3:28 PM

Change 212556 had a related patch set uploaded (by Jdlrobson):
Fix icons in the search overlay

https://gerrit.wikimedia.org/r/212556

gerritbot added a project: Patch-For-Review.May 21 2015, 3:28 PM
Jdlrobson moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog board.May 21 2015, 3:28 PM
gerritbot added a comment.May 24 2015, 12:53 PM

Change 212556 merged by jenkins-bot:
Fix icons in the search overlay

https://gerrit.wikimedia.org/r/212556

Jdlrobson mentioned this in rEMFR34c00bec03df: Fix icons in the search overlay.May 24 2015, 12:53 PM
Jdlrobson mentioned this in rMEXT11bb451e3f6c: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
phuedx closed this task as Resolved.May 25 2015, 6:47 AM
phuedx removed a project: Patch-For-Review.
Liuxinyu970226 unsubscribed.May 25 2015, 7:18 AM
Jdlrobson reopened this task as Open.May 26 2015, 6:59 AM

One remaining problem that needs to be addressed with relation to this icon to truly call it complete: https://gerrit.wikimedia.org/r/213199

phuedx closed this task as Resolved.Jun 2 2015, 3:03 PM
• Phabricator_maintenance moved this task from 2017-18 Q3 to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL