Page MenuHomePhabricator
Create Task
Maniphest T99855

Browse topics and sorting choice is not aligned correctly in Firefox
Closed, ResolvedPublic
Actions

Description

On Mediawiki.org today, following the latest code release, the line with browse topics and sorting choice is not aligned correctly in Firefox. They're floating above the line where they should be. This is OK in Chrome.

ToC bar firefox.jpg (684×1 px, 256 KB)

Details

SubjectRepoBranchLines +/-
Fix style to show sort icon (downCaret)mediawiki/extensions/Flowmaster+19 -9
Customize query in gerrit

Related Objects

Event Timeline

• DannyH created this task.May 20 2015, 11:24 PM
• DannyH raised the priority of this task from to Medium.
• DannyH updated the task description. (Show Details)
• DannyH added projects: Collaboration-Team-Triage, StructuredDiscussions.
• DannyH moved this task to Ready for next sprint on the Collaboration-Team-Triage board.
• DannyH subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2015, 11:24 PM
• DannyH moved this task from Ready for next sprint to Near-Term Interest on the Collaboration-Team-Triage board.Jun 3 2015, 12:27 AM
SBisson subscribed.Jun 11 2015, 2:46 PM

The icon next to the sorting menu is actually gone. I don't know if it is on purpose but no icon, no alignment issue :)

• DannyH added a comment.Jun 11 2015, 4:12 PM

No, we need that icon -- it's the way users know that there's a choice. This is still a bug. :)

SBisson added a comment.Jun 24 2015, 1:38 PM

Introduced by https://gerrit.wikimedia.org/r/#/c/207154/

Class mw-ui-icon-after is used to position the icon but it does not exist in core.

SBisson claimed this task.Jun 24 2015, 3:17 PM
SBisson added a project: Collaboration-Team-Sprint-D-2015-06-30.
SBisson set Security to None.
SBisson moved this task from Sprint D - ends July 1 to In Development on the Collaboration-Team-Sprint-D-2015-06-30 board.
gerritbot subscribed.Jun 24 2015, 3:19 PM

Change 220478 had a related patch set uploaded (by Sbisson):
Fix style to show sort icon (downCaret)

https://gerrit.wikimedia.org/r/220478

gerritbot added a project: Patch-For-Review.Jun 24 2015, 3:19 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 24 2015, 3:21 PM
gerritbot added a comment.Jun 24 2015, 4:45 PM

Change 220478 merged by jenkins-bot:
Fix style to show sort icon (downCaret)

https://gerrit.wikimedia.org/r/220478

SBisson mentioned this in rEFLW86084788e63d: Fix style to show sort icon (downCaret).Jun 24 2015, 4:45 PM
Diffusion mentioned this in rMEXTb7f2fe05990c: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 24 2015, 4:46 PM
• Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jun 24 2015, 5:00 PM
• Forrestbot subscribed.
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 24 2015, 5:16 PM
Etonkovidova subscribed.Jun 24 2015, 10:35 PM

Checked in FF 38, Chrome, and Safar 8.0.6.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 24 2015, 10:37 PM
SBisson moved this task from Near-Term Interest to Current workboard on the Collaboration-Team-Triage board.Jun 26 2015, 1:06 PM
• DannyH closed this task as Resolved.Jun 29 2015, 5:10 PM

Works on Beta

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 29 2015, 5:10 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• DannyH moved this task from Current workboard to Resolved on the Collaboration-Team-Triage board.Jun 30 2015, 4:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL