Page MenuHomePhabricator
Feed Advanced Search

Mar 3 2024

Rockingpenny4 added a comment to T327263: Add class to row's paragraph.
$text = Html::rawElement(
    'p',  ['class' => $this->name], "\n"
);

On going through the documentation and the file , maybe the rawElement() method could be used as above for the classnames.

Mar 3 2024, 2:14 PM · MediaWiki-extensions-AdminLinks
Rockingpenny4 added a comment to T327263: Add class to row's paragraph.

@Yaron_Koren where can i find more information regarding the built-in classes , should I refer to this https://www.mediawiki.org/wiki/Manual:Html.php?

Mar 3 2024, 12:47 PM · MediaWiki-extensions-AdminLinks
Rockingpenny4 added a comment to T327263: Add class to row's paragraph.

What if we were to escape the special characters using htmlspecialchars?

Mar 3 2024, 2:23 AM · MediaWiki-extensions-AdminLinks

Mar 1 2024

Rockingpenny4 added a comment to T327263: Add class to row's paragraph.

@Yaron_Koren - Yes that is definitely a much better way to implement that , custom attributes don't seem to have any rules and are a well fit for this case . Does something like this look correct

$text = "	<p data-row-name='admin-links-row-" . $this->name . "'>\n";
Mar 1 2024, 9:40 PM · MediaWiki-extensions-AdminLinks
Rockingpenny4 added a comment to T327263: Add class to row's paragraph.
Mar 1 2024, 8:50 PM · MediaWiki-extensions-AdminLinks
Rockingpenny4 added a comment to T327263: Add class to row's paragraph.

@Yaron_Koren please review the patch

Mar 1 2024, 8:50 PM · MediaWiki-extensions-AdminLinks
Rockingpenny4 added a comment to T327263: Add class to row's paragraph.

@Yaron_Koren I was successfully able to set it up and install the inline Comments extension , but I am not able to locate the ALrow.php file. Can you assist me on that?

Mar 1 2024, 6:05 PM · MediaWiki-extensions-AdminLinks
Rockingpenny4 added a comment to T327263: Add class to row's paragraph.

@Yaron_Koren I installed the mediawiki repo and in the extensions folder i installed the inline comments repo however I am not able to locate the LocalSettings.php file for configuration. Did i make any mistake while setting up?

Mar 1 2024, 1:20 PM · MediaWiki-extensions-AdminLinks

Feb 29 2024

Rockingpenny4 added a comment to T327263: Add class to row's paragraph.

@Yaron_Koren may i take up this issue?

Feb 29 2024, 3:15 PM · MediaWiki-extensions-AdminLinks
Rockingpenny4 added a comment to T358694: Change word "Link" to domain name in Page Exchange URL display.

Hello, @Yaron_Koren , I would like to take up this issue

Feb 29 2024, 12:36 PM · MediaWiki-extensions-PageExchange