Change 497928 merged by jenkins-bot:
[mediawiki/vagrant@master] ldapauth: support LDAP account locking via blocks

I wonder if categories should be listed at all. It is a "filter", and we don't list other filters (which currently only includes participants). The real issue I see is there's no wiki specified, outside clicking on the link. Another option, and I'm unsure about design, would be to specify the number of categories. That could link to the actual category list, and make it expand.

Change 490648 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable WikibaseCirrusSearch on wikidata

TechCom hosted an IRC discussion about this today:

• Minutes: https://tools.wmflabs.org/meetbot/wikimedia-office/2019/wikimedia-office.2019-03-20-21.45.html
• Log: https://tools.wmflabs.org/meetbot/wikimedia-office/2019/wikimedia-office.2019-03-20-21.45.log.html

works now with some puppet cherry-picks

works now with some puppet cherry-picks :)

Partial blocks are now on Persian. We haven't heard reports about any breakage.

Fixed by https://gerrit.wikimedia.org/r/#/c/eventlogging/+/497648/

Change 497943 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: replace BetaOptinPanel parent

@jeropbrenda It looks good for an overview, but could use more detail. What's a mergeable edit? What do you do if the edits you're interested in aren't shown as mergeable edits? What are possible failure modes, and how should they be handled? Etc.

Excellent report Dan. I really envy your excellent sense of humor!

Possibly same as T218722?

Change 497937 merged by jenkins-bot:
[mediawiki/core@master] Check whether a user is blocked from upload in ApiUpload

Change 497941 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@wmf/1.33.0-wmf.22] Avoid counting input lines twice in BlockLevelPass::execute()

Change 497941 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@wmf/1.33.0-wmf.22] Avoid counting input lines twice in BlockLevelPass::execute()

Change 497940 had a related patch set uploaded (by Jforrester; owner: Arlolra):
[mediawiki/core@wmf/1.33.0-wmf.22] BlockLevelPass: further fixes for T218817

Change 497940 had a related patch set uploaded (by Jforrester; owner: Arlolra):
[mediawiki/core@wmf/1.33.0-wmf.22] BlockLevelPass: further fixes for T218817

Change 497939 had a related patch set uploaded (by Jforrester; owner: Arlolra):
[mediawiki/core@wmf/1.33.0-wmf.22] parser: Count occurrences of newlines

The final result, I41a45266d266195aa6002d3854e018cacf052ca6, is the one we want but since they all stack on top of each other, you might have to do all three. It's fine to just rebase the last one though.

I agree, left-aligned and with four separate labels looks good and gives plenty of room for long wiki and category lists. Also would mean the long 'view all edits' button would be less likely to get in the way (it'd be next to the two date lines).

Which of the patches should get back-ported?

@elukey Please keep the directories of mtizzoni and panisson on stat* untouched. You can purge the rest (for them and the other two usernames). I'm talking with them to see when those two directories can be purged. There is some data there we may want to release.

If I understand this task correctly, this was fixed some time in the last year with a reworking of how CirrusSearch treats cross-namespace redirects. I currently get completions for MOS:, such as MOS:DUPECITE and more. Please reopen if this is not the case.

Not sure what's the version of the testing app, but I cannot reproduce it on the latest alpha app.

OK, TestCommons is now live. If all is well, should we proceed to RealCommons?

PR238 is already merged, so no need for a separate ticket. :)

In T218233#5036593, @Krinkle wrote:

Looks like all the Debian channels (jessie, stretch, buster, sid) are still on 1.8.13. Last update was last year (1.8.13-10) indicating that the package no longer has a Debian maintainer (discussion).

Mentioned in SAL (#wikimedia-operations) [2019-03-20T22:29:11Z] <jforrester@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T214075 Enable federation of Wikidata items and properties on Test Commons (duration: 00m 57s)

In T218445#5041834, @jmatazzoni wrote:

MusikAnimal Mooeypoo, please see the note "Per-wiki metrics" in the "Functionality" section of the Description. I'd said in Estimation that we would report per-wiki metrics for Wikipedias only. But it doesn't make sense to not report Uploads to Commons, for example. So reporting what we do have and ignoring the columns that don't apply seems like a better solution, and just as easy (because we still don't have to customize the tables for the various different wikis). Is this OK?

Is this approach OK from a level of effort perspective, do you think? I.e., I don't want to add work to the ticket.

I can force the client to timeout, but I can't seem to reproduce the problem with displaying the response on screen. It seems plausible that display_errors was the problem, and is now fixed. I'm willing to call this complete and we can re-open if it is seen again.

In T218414#5041394, @ppelberg wrote:

Where will the code for this to be decided patch live?

The code for the approach we move forward with will live in the VisualEditor repo.

From: Antoine Musso
Date: Wed, 20 Mar 2019, 22:24

From: Paolo Greppi
Date: Wed, 20 Mar 2019 18:52:04 +0100

0.3.1 released.

Per T185227: Sunset/archive Configure extension?, Configure is getting archived. Reclassifying as a general MediaWiki configuration feature request.

Thanks for pointing that out @dom_walden - it needed an additional patch in core.

Per T185227: Sunset/archive Configure extension?, Configure is getting archived. Reclassifying as a general MediaWiki extension registration feature request.

Change 485082 merged by jenkins-bot:
[operations/mediawiki-config@master] TestCommons: Enable federation of Wikidata items and properties

Change 497937 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Check whether a user is blocked from upload in ApiUpload

Per T185227: Sunset/archive Configure extension?, this extension is getting archived.

Because the type hint just below it will say ?string not string|null? We should be using the one markup language which is used by PHP, not making up our own?

According to the database, MABot has 2 unread login-fail-new notifications on English Wikipedia from May 2018, and 1 unread "thank you for your first edit" notification on English Wikiquote from yesterday (March 19th). So I don't understand why the Special:Notifications UI isn't working for you, but the notifications it's talking about are there, at least according to the database.

In T218445#5041716, @MusikAnimal wrote:

Change 497932 had a related patch set uploaded (by Didicodes; owner: Didicodes):
[mediawiki/extensions/ExtJSBase@master] Fixed 'implmented' typo

I like the links, but in my opinion the left alignment is more legible. Can we at least add some extra spacing between the "Last updated" line and the information below it? And perhaps go back to "Start date" and "End date" so it's easier on the eyes?

Per T185227: Sunset/archive Configure extension?, this extension is getting archived.

Per T185227: Sunset/archive Configure extension?, this extension is getting archived.

Per T185227: Sunset/archive Configure extension?, this extension is getting archived.

Per T185227: Sunset/archive Configure extension?, this extension is getting archived.

Per T185227: Sunset/archive Configure extension?, this extension is getting archived.

Per T185227: Sunset/archive Configure extension?, this extension is getting archived.

Fixed now.

Thank your for the extra context!

So this is a bit of a grey area of if this change is within the realm of things that a community can request. The foundation may feel it wants a consistent feel to all the projects that it hosts.

Change 497865 merged by jenkins-bot:
[mediawiki/core@master] Avoid counting input lines twice in BlockLevelPass::execute()

Change 497865 merged by jenkins-bot:
[mediawiki/core@master] Avoid counting input lines twice in BlockLevelPass::execute()

Next step is to apply the following to replace the test IP with codfw text-lb IP.

[edit firewall family inet filter transport-in4 term no-offload-ping4 from destination-address]
+        208.80.153.224/32;
-        208.80.153.225/32;
[edit firewall family inet filter transport-in4 term offload-ping4 from destination-address]
+        208.80.153.224/32;
-        208.80.153.225/32;
[edit firewall family inet filter border-in4 term offload-ping4 from destination-address]
+        208.80.153.224/32;
-        208.80.153.225/32;

@matmarex mentioned that this is probably related to the fact that you can provide a string as the block length and PHP's date math does something weird with it

In T213802#5017771, @abi_ wrote:

Updated previous comment with the latest changes made to the code after reviews from @Nikerabbit. (Thanks!)

TechCom hosted an IRC meeting on this topic today:

• minutes: https://tools.wmflabs.org/meetbot/wikimedia-office/2019/wikimedia-office.2019-03-20-21.00.html
• log: https://tools.wmflabs.org/meetbot/wikimedia-office/2019/wikimedia-office.2019-03-20-21.00.log.html