Change 864883 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Add option to donation QC to wait for messages

https://gerrit.wikimedia.org/r/864883

xbuild is old, unmaintained, deprecated, and doesn't work with VS/MSBuild projects written in the last 5 years (at least). As far as I can tell, Debian doesn't package msbuild, I don't know why. The only discussion was this request (#959045).

Mentioned in SAL (#wikimedia-operations) [2022-12-06T02:42:37Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T323907)', diff saved to https://phabricator.wikimedia.org/P42396 and previous config saved to /var/cache/conftool/dbconfig/20221206-024236-ladsgroup.json

Change 864882 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] A whole lotta upstream patches for background imports

https://gerrit.wikimedia.org/r/864882

Actually I realized its pure CSS. Here is the size difference between what it is and what we should have. See the last one here it is closest to Figma in terms of size and colour. It was shared by DS designer.

I suppose it wouldn't be too hard to add either via a downstream patch or web server config. There are several potential issues though:

• It would require a second domain, and be limited to that domain, otherwise it could be trivially used for XSS attacks against Gitlab itself.
• It would have to be limited to URLs with static content (ie. which contain a commit ID), otherwise an attacker can take over the script owner's Gitlab account and use it to launch an XSS against Wikipedia. We have seen such attacks via Wikimedia account takeover for on-wiki hosted scripts, I don't think we'd want to worry about another authentication system (which we have less control about) being added to the threat surface.
  • Because you have to do that, it wouldn't allow any kind of managed rollout of upgrades, you'd have to go around, find every wiki which links to an old version and change the links. It would be basically equivalent to copy-pasting the file content to a wiki page on every wiki using the script, which is an existing antipattern that script maintainers have been trying to move away from in various ways.
• It could be used to host XSS attack vectors against third parties. Not a big risk I suppose, as so many other places can be used for that, but if it does happen (possibly because the attacker's intent is to damage Wikimedia's reputation), it could get the site on malware lists etc.

Hi @Etonkovidova I checked this implementation and everything looks great except the size of the three dot loading indicator. It is quite large. Also the design system team suggested we use the blue as shown in Figma for this indicator.

Checked on betalabs - the issue is fixed. The position of the guided tour is shifted toward the first line and to the left (according to the spec) and stays no matter if the additional text above the search results is present or not.

a user cannot create an article (additional text is added above the search results) a user can create an article

Mentioned in SAL (#wikimedia-operations) [2022-12-06T02:28:18Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1200 (T322618)', diff saved to https://phabricator.wikimedia.org/P42395 and previous config saved to /var/cache/conftool/dbconfig/20221206-022817-ladsgroup.json

@sgrabarczuk From what I gathered from the description and comments, this looks good. If I'm wrong, please let me know.

Change 864839 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a8

https://gerrit.wikimedia.org/r/864839

The ProfilerSetup/ProfilerState split is awkward. ProfilerSetup needs state. And maybe it is nice to have a singleton object in there somewhere, as a setup/config bundle, and for testability.

Change 864839 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a8

https://gerrit.wikimedia.org/r/864839

Change 864839 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a8

https://gerrit.wikimedia.org/r/864839

I confirm Chrome and Firefox seem to have implemented some optimization for the $( '#ca-addsection a' ) case, because it's significantly faster than $( 'a' ), otherwise it would have been the contrary.

Mentioned in SAL (#wikimedia-operations) [2022-12-06T02:16:39Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1168 (T323907)', diff saved to https://phabricator.wikimedia.org/P42393 and previous config saved to /var/cache/conftool/dbconfig/20221206-021638-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T02:16:17Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T323907)', diff saved to https://phabricator.wikimedia.org/P42392 and previous config saved to /var/cache/conftool/dbconfig/20221206-021617-ladsgroup.json

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Mentioned in SAL (#wikimedia-operations) [2022-12-06T02:13:02Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db2169:3316 (T323907)', diff saved to https://phabricator.wikimedia.org/P42390 and previous config saved to /var/cache/conftool/dbconfig/20221206-021301-ladsgroup.json

Change 864844 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Also assert that metadata values are undefined when not expected to be set.

https://gerrit.wikimedia.org/r/864844

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:42:51Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1200 (T322618)', diff saved to https://phabricator.wikimedia.org/P42386 and previous config saved to /var/cache/conftool/dbconfig/20221206-014251-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:40:46Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db2178 (T322618)', diff saved to https://phabricator.wikimedia.org/P42385 and previous config saved to /var/cache/conftool/dbconfig/20221206-014046-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:40:38Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1200 (T322618)', diff saved to https://phabricator.wikimedia.org/P42384 and previous config saved to /var/cache/conftool/dbconfig/20221206-014038-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:40:17Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1185 (T322618)', diff saved to https://phabricator.wikimedia.org/P42383 and previous config saved to /var/cache/conftool/dbconfig/20221206-014017-ladsgroup.json

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:30:58Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T323907)', diff saved to https://phabricator.wikimedia.org/P42382 and previous config saved to /var/cache/conftool/dbconfig/20221206-013057-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:28:12Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db2169:3316 (T323907)', diff saved to https://phabricator.wikimedia.org/P42381 and previous config saved to /var/cache/conftool/dbconfig/20221206-012812-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:27:51Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db2158 (T323907)', diff saved to https://phabricator.wikimedia.org/P42380 and previous config saved to /var/cache/conftool/dbconfig/20221206-012750-ladsgroup.json

Seems like it has already been added in wikimedia/banana-checker#89 (thanks @Jdforrester-WMF!) but defaults to allowTrailingWhitespace: true so needs either a change to the default, or the MediaWiki default should be updated.

In T48235#4756856, @Ghybu wrote:

Hello! Now "ku" is in the list of supported collations by cldr: http://www.unicode.org/repos/cldr/trunk/common/collation/

Mentioned in SAL (#wikimedia-operations) [2022-12-06T01:11:29Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1165 (T323907)', diff saved to https://phabricator.wikimedia.org/P42376 and previous config saved to /var/cache/conftool/dbconfig/20221206-011128-ladsgroup.json

I provided FF68 as an example for reproduction, as can be seen on caniuse most browsers started supporting this about a year ago so FF83 should be affected too. (and IE, Opera Mini, UC browser for Android, QQ browser and KaiOS browser don't support it either according to caniuse) I don't know how many people use a browser that doesn't support this feature.

In T307035#8436528, @Eevans wrote:

In T307035#8078353, @Cmjohnson wrote:

@Eevans take your time, I just want to make sure that we're not falling behind on-site. Let me know whenever you're ready.

@Cmjohnson, apologies for the amount of time that's passed, but we're good to go with these moves now.

Change 864870 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Optimize some jQuery selectors

https://gerrit.wikimedia.org/r/864870

Change 864867 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Optimize some jQuery selectors

https://gerrit.wikimedia.org/r/864867

Mentioned in SAL (#wikimedia-operations) [2022-12-06T00:55:27Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db2178 (T322618)', diff saved to https://phabricator.wikimedia.org/P42372 and previous config saved to /var/cache/conftool/dbconfig/20221206-005526-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T00:54:57Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1185 (T322618)', diff saved to https://phabricator.wikimedia.org/P42371 and previous config saved to /var/cache/conftool/dbconfig/20221206-005457-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T00:54:01Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db2178 (T322618)', diff saved to https://phabricator.wikimedia.org/P42370 and previous config saved to /var/cache/conftool/dbconfig/20221206-005401-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T00:53:40Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db2171:3315 (T322618)', diff saved to https://phabricator.wikimedia.org/P42369 and previous config saved to /var/cache/conftool/dbconfig/20221206-005339-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T00:52:44Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1185 (T322618)', diff saved to https://phabricator.wikimedia.org/P42368 and previous config saved to /var/cache/conftool/dbconfig/20221206-005244-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-12-06T00:52:23Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T322618)', diff saved to https://phabricator.wikimedia.org/P42367 and previous config saved to /var/cache/conftool/dbconfig/20221206-005223-ladsgroup.json

Interesting, I knew that in the general case selectors are evaluated like that, but I expected the special case of an ID selector to be optimized somehow. It turns out that Firefox and Chrome indeed optimize $( '#ca-addsection a' ), but not $( '#t-permalink a, #coll-download-as-rl a' ) (and IE 11, which we still support, optimizes neither).