Page MenuHomePhabricator
Create Task
Maniphest T369260

PHP Notice: Undefined offset: 0
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined offset: 0
error.stack_trace
from /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/PermissionManager.php(624)
#0 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/PermissionManager.php(624): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/PermissionManager.php(1022): MediaWiki\Permissions\PermissionManager->resultToStatus(MediaWiki\Permissions\PermissionStatus, array)
#2 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/PermissionManager.php(554): MediaWiki\Permissions\PermissionManager->checkQuickPermissions(string, MediaWiki\User\User, MediaWiki\Permissions\PermissionStatus, string, boolean, MediaWiki\Title\Title)
#3 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/PermissionManager.php(1327): MediaWiki\Permissions\PermissionManager->getPermissionStatus(string, MediaWiki\User\User, MediaWiki\Title\Title, string, boolean)
#4 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/PermissionManager.php(554): MediaWiki\Permissions\PermissionManager->checkActionPermissions(string, MediaWiki\User\User, MediaWiki\Permissions\PermissionStatus, string, boolean, MediaWiki\Title\Title)
#5 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/PermissionManager.php(336): MediaWiki\Permissions\PermissionManager->getPermissionStatus(string, MediaWiki\User\User, MediaWiki\Title\Title, string, boolean)
#6 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/UserAuthority.php(389): MediaWiki\Permissions\PermissionManager->userCan(string, MediaWiki\User\User, MediaWiki\Title\Title, string)
#7 /srv/mediawiki/php-1.43.0-wmf.12/includes/Permissions/UserAuthority.php(176): MediaWiki\Permissions\UserAuthority->internalCan(string, string, MediaWiki\Title\Title, NULL, boolean)
#8 /srv/mediawiki/php-1.43.0-wmf.12/includes/user/User.php(3262): MediaWiki\Permissions\UserAuthority->probablyCan(string, MediaWiki\Title\Title, NULL)
#9 /srv/mediawiki/php-1.43.0-wmf.12/includes/Output/OutputPage.php(3908): MediaWiki\User\User->probablyCan(string, MediaWiki\Title\Title)
#10 /srv/mediawiki/php-1.43.0-wmf.12/includes/Output/OutputPage.php(3721): MediaWiki\Output\OutputPage->getJSVars(integer)
#11 /srv/mediawiki/php-1.43.0-wmf.12/includes/Output/OutputPage.php(4859): MediaWiki\Output\OutputPage->getBottomScripts()
#12 /srv/mediawiki/php-1.43.0-wmf.12/includes/skins/SkinMustache.php(103): MediaWiki\Output\OutputPage->tailElement(MediaWiki\Skins\Vector\SkinVector22)
#13 /srv/mediawiki/php-1.43.0-wmf.12/includes/skins/SkinTemplate.php(178): SkinMustache->generateHTML()
#14 /srv/mediawiki/php-1.43.0-wmf.12/includes/Output/OutputPage.php(3017): SkinTemplate->outputPage()
#15 /srv/mediawiki/php-1.43.0-wmf.12/includes/actions/ActionEntryPoint.php(162): MediaWiki\Output\OutputPage->output(boolean)
#16 /srv/mediawiki/php-1.43.0-wmf.12/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#17 /srv/mediawiki/php-1.43.0-wmf.12/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}
Impact

Upon deploying the MediaWiki train (T366957) on group 2 wikis, several hundred of those logs were emitted. They come primarily from enwiki, some came from fawiki . That comes from the Draft namespace.

Notes

Details

Request URL
https://en.wikipedia.org/wiki/Draft:Emi_Tsutsumi
SubjectRepoBranchLines +/-
PermissionManager: Handle empty error array from TitleQuickPermissionsmediawiki/corewmf/1.43.0-wmf.12+20 -6
PermissionManager: Handle empty error array from TitleQuickPermissionsmediawiki/coremaster+20 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasehasharT366957 1.43.0-wmf.12 deployment blockers
 ResolvedPRODUCTION ERRORTgrT369260 PHP Notice: Undefined offset: 0

Event Timeline

hashar triaged this task as Unbreak Now! priority.Thu, Jul 4, 9:06 AM
hashar created this task.
Restricted Application added subscribers: Huji, Aklapper. · View Herald TranscriptThu, Jul 4, 9:06 AM
hashar added a parent task: T366957: 1.43.0-wmf.12 deployment blockers.Thu, Jul 4, 9:06 AM
daniel added subscribers: matmarex, daniel.Thu, Jul 4, 9:22 AM

Judging by the data and git blame, this is a likely culprit: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1039337

Pinging @matmarex

Tgr subscribed.EditedThu, Jul 4, 9:34 AM

I guess the TitleQuickPermissions hook returns false without actually setting an error?

Tgr added a comment.Thu, Jul 4, 9:43 AM

Indeed: https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/8d1e9472138a499f138f3c2b1a3138973f339697/wmf-config/CommonSettings.php#2356

Michael subscribed.Thu, Jul 4, 9:49 AM
matmarex added a comment.Thu, Jul 4, 9:58 AM

So it seems that here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1039337/3/includes/Permissions/PermissionManager.php#1022 if $errors is empty, we should just return without modifying the $status. My bad, I missed that.

gerritbot added a comment.Thu, Jul 4, 10:16 AM

Change #1052067 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] PermissionManager: Handle empty error array from TitleQuickPermissions

https://gerrit.wikimedia.org/r/1052067

gerritbot added a project: Patch-For-Review.Thu, Jul 4, 10:16 AM
gerritbot added a comment.Thu, Jul 4, 10:29 AM

Change #1052069 had a related patch set uploaded (by D3r1ck01; author: Gergő Tisza):

[mediawiki/core@wmf/1.43.0-wmf.12] PermissionManager: Handle empty error array from TitleQuickPermissions

https://gerrit.wikimedia.org/r/1052069

gerritbot added a comment.Thu, Jul 4, 10:50 AM

Change #1052067 merged by jenkins-bot:

[mediawiki/core@master] PermissionManager: Handle empty error array from TitleQuickPermissions

https://gerrit.wikimedia.org/r/1052067

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Thu, Jul 4, 11:00 AM
gerritbot added a comment.Thu, Jul 4, 11:49 AM

Change #1052069 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.12] PermissionManager: Handle empty error array from TitleQuickPermissions

https://gerrit.wikimedia.org/r/1052069

Stashbot added a comment.Thu, Jul 4, 11:56 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-04T11:56:11Z] <hashar@deploy1002> Started scap sync-world: Backport for [[gerrit:1052069|PermissionManager: Handle empty error array from TitleQuickPermissions (T369260)]]

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.12; 2024-07-02); removed MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Thu, Jul 4, 12:00 PM
Stashbot added a comment.Thu, Jul 4, 12:02 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-04T12:02:34Z] <hashar@deploy1002> hashar, d3r1ck01: Backport for [[gerrit:1052069|PermissionManager: Handle empty error array from TitleQuickPermissions (T369260)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Thu, Jul 4, 12:03 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-04T12:03:44Z] <hashar@deploy1002> Started scap sync-world: Backport for [[gerrit:1052069|PermissionManager: Handle empty error array from TitleQuickPermissions (T369260)]]

Stashbot added a comment.Thu, Jul 4, 12:06 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-04T12:06:19Z] <hashar@deploy1002> hashar, d3r1ck01: Backport for [[gerrit:1052069|PermissionManager: Handle empty error array from TitleQuickPermissions (T369260)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Thu, Jul 4, 12:11 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-04T12:11:30Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:1052069|PermissionManager: Handle empty error array from TitleQuickPermissions (T369260)]] (duration: 07m 45s)

hashar closed this task as Resolved.Thu, Jul 4, 12:51 PM
hashar assigned this task to Tgr.

The log spam is gone!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits