Page MenuHomePhabricator
Feed Advanced Search

Wed, Mar 24

Urfiner awarded T234555: Upload file form does not update file name if the provided file name is not valid a Insectivore token.
Wed, Mar 24, 2:38 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Feb 26 2020

Tombolano added a comment to T246199: "editor=wikieditor" no longer works in Page Forms for MW 1.34 and higher.

Hi, this works for me, what version of Page Forms are you using? I think this is related to this bug: https://phabricator.wikimedia.org/T239023, which should be already fixed in the last version of Page Forms.

Feb 26 2020, 10:15 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms, WikiEditor

Nov 24 2019

Tombolano added a comment to T239023: wikieditor is not loaded when using the editor=wikieditor option in texarea fiels on MediaWiki 1.33.1.

I tested the code on MediaWiki 1.33.1 (wikieditor 0.5.2) and MediaWiki 1.31.5 (wikieditor 0.5.1) and worked fine.

Nov 24 2019, 8:55 PM · MediaWiki-extensions-Page_Forms
Tombolano created T239023: wikieditor is not loaded when using the editor=wikieditor option in texarea fiels on MediaWiki 1.33.1.
Nov 24 2019, 1:42 PM · MediaWiki-extensions-Page_Forms

Nov 13 2019

Tombolano updated the task description for T238204: Added emails are not trimed and not converted to lowercase.
Nov 13 2019, 12:05 PM · MediaWiki-extensions-Email_Authorization
Tombolano created T238204: Added emails are not trimed and not converted to lowercase.
Nov 13 2019, 12:03 PM · MediaWiki-extensions-Email_Authorization

Nov 10 2019

Tombolano added a comment to T234366: Truncate string values before row insertion.

I have also had problems due to having some long strings not being truncated, but in my case the SQL insertion queries failed and no data was added to the database for the pages with those long strings. I am using MySQL 5.7. To fix this I just changed the type of the affected columns to text in my database, but I agree with HertzDevil that the strings should be truncated before being added to the database. Also, currently there is no easy way of knowing if something went wrong, if a string is truncated or if an insertion/update query fails there is no warning or error message anywhere.

Nov 10 2019, 4:46 PM · MediaWiki-extensions-Cargo

Oct 7 2019

Tombolano added a comment to T234555: Upload file form does not update file name if the provided file name is not valid.

I have made a patch to solve the issue.

Oct 7 2019, 11:42 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Oct 3 2019

Tombolano created T234555: Upload file form does not update file name if the provided file name is not valid.
Oct 3 2019, 5:37 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Jul 23 2019

Tombolano added a comment to T223886: Add a bibtex format.

Thanks for accepting this change!

Jul 23 2019, 8:50 AM · MediaWiki-extensions-Cargo

Jun 30 2019

Tombolano created T226947: Remote autocompletion does not work with mappings.
Jun 30 2019, 11:14 PM · MediaWiki-extensions-Page_Forms

Jun 28 2019

Tombolano closed T226665: Remote autocompletion does not work when specifying cargo field=_pageName as Resolved.

Thank you!, yes, now the code works as expected, so I am marking this bug as resolved.

Jun 28 2019, 6:26 PM · MediaWiki-extensions-Page_Forms

Jun 26 2019

Tombolano added a comment to T226566: Autocompletion matching on every character does not work when remote autocompletion is done.

I have found the problematic line of code. The bug is in the function getSQLConditionForAutocompleteInColumn (In PF_ValuesUtils.php), which is called when autocompleting by category or namespace.

Jun 26 2019, 11:09 PM · MediaWiki-extensions-Page_Forms
Tombolano created T226665: Remote autocompletion does not work when specifying cargo field=_pageName.
Jun 26 2019, 8:32 PM · MediaWiki-extensions-Page_Forms

Jun 25 2019

Tombolano updated the task description for T226566: Autocompletion matching on every character does not work when remote autocompletion is done.
Jun 25 2019, 7:36 PM · MediaWiki-extensions-Page_Forms
Tombolano created T226566: Autocompletion matching on every character does not work when remote autocompletion is done.
Jun 25 2019, 7:29 PM · MediaWiki-extensions-Page_Forms

May 24 2019

Tombolano added a comment to T223886: Add a bibtex format.

Hi, thanks a lot for the questions and comments:

May 24 2019, 12:33 PM · MediaWiki-extensions-Cargo

May 20 2019

Tombolano added a comment to T223886: Add a bibtex format.

Hi Yaron, I think that you are right, I think that there is no important use case for a display format, and that the export format is enough. So I have uploaded a new patch to leave only a bibtex format (which now will be the exporting format).

May 20 2019, 4:27 PM · MediaWiki-extensions-Cargo
Tombolano created T223886: Add a bibtex format.
May 20 2019, 9:49 AM · MediaWiki-extensions-Cargo

May 19 2019

Tombolano closed T222824: Show self links in bold font as Resolved.

I'm closing this since the fix has been merged. Now everything works fine. Although one of the patch reviewers said that there is a ->equals() method in the Title class and that maybe we should use it.

May 19 2019, 12:05 PM · Patch-For-Review, MediaWiki-extensions-Cargo

May 18 2019

Tombolano reopened T222824: Show self links in bold font as "Open".

Thanks for the fix Yaron!, certainly your code is better than mine, I do not have experience with MediaWiki coding. However, you forgot to check $wgTitle for null and now the mainteinance scripts fail (at least cargoRecreateData), yikes! I am uploading a patch to fix it.

May 18 2019, 12:30 AM · Patch-For-Review, MediaWiki-extensions-Cargo

May 15 2019

Tombolano added a comment to T223222: Querying data in cargo with the "HOLDS" command combining with "AND" clause.

You are welcome 。^‿^。, you can use my explanations as you wish.

May 15 2019, 5:57 PM · MediaWiki-extensions-Cargo

May 14 2019

Tombolano added a comment to T223222: Querying data in cargo with the "HOLDS" command combining with "AND" clause.

I tried to make the query in cargo (without the instr function), just for curiosity, and as I said before it can be done with a 2 join query. For the example of books it would be like this:

May 14 2019, 6:37 PM · MediaWiki-extensions-Cargo
Tombolano added a comment to T223222: Querying data in cargo with the "HOLDS" command combining with "AND" clause.

The HOLDS command only works fine for one author. If you use the HOLDS query as you say with an OR, and a book is authored both by 'Leo Tolstoy' and 'Dostoevsky', then that book will appear twice in the query resutls.

May 14 2019, 4:32 PM · MediaWiki-extensions-Cargo

May 12 2019

Tombolano added a comment to T223025: Exports are corrupted with Warning: Cannot modify header information.

I have uploaded a second patch. In the first patch that I uploaded I disabled the output in the constructor of the CargoExport class, but that made the MediaWiki SpecialPages page to be blank, I have no idea why, it is very strange, everything else seems to work fine. I uploaded a second patch where I just replaced the line "$this->getOutput()->setArticleBodyOnly( true );" with "$this->getOutput()->disable();", that seems to work fine.

May 12 2019, 2:54 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano added a comment to T223025: Exports are corrupted with Warning: Cannot modify header information.

All the warnings are "Cannot modify header information". I am getting 6 of them, the given locations of the warnings in OutputPage.php are: 2665, 2667, 2681, 2531, 2575, and 2576, which are the lines that set the headers.

May 12 2019, 2:29 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano added a comment to T223025: Exports are corrupted with Warning: Cannot modify header information.

I was checking again this problem and I realized that I had several options set to debug errors on LocalSetting.php. Disabling this options solves the problem since no warnings are appended at the output, so this bug only occurs when using the debug options. I updated the bug description with this information.

May 12 2019, 1:11 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano updated the task description for T223025: Exports are corrupted with Warning: Cannot modify header information.
May 12 2019, 1:10 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano committed rEPFM67c9fb2f16cc: Minimize multiple instance forms when using the Header Tabs extension (authored by Tombolano).
Minimize multiple instance forms when using the Header Tabs extension
May 12 2019, 12:50 PM
Tombolano closed T222843: Fix ordering by date fields in tables as Resolved.

I marking this as resolved since the patch is merged. Thank you!

May 12 2019, 12:50 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano created T223034: Multiple instance forms are not minimized when using the Header Tabs extension.
May 12 2019, 12:25 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Tombolano created T223025: Exports are corrupted with Warning: Cannot modify header information.
May 12 2019, 12:56 AM · Patch-For-Review, MediaWiki-extensions-Cargo

May 8 2019

Tombolano updated the task description for T222843: Fix ordering by date fields in tables.
May 8 2019, 11:16 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano updated the task description for T222843: Fix ordering by date fields in tables.
May 8 2019, 9:07 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano created T222843: Fix ordering by date fields in tables.
May 8 2019, 8:37 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano updated the task description for T222824: Show self links in bold font.
May 8 2019, 5:17 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Tombolano created T222824: Show self links in bold font.
May 8 2019, 5:04 PM · Patch-For-Review, MediaWiki-extensions-Cargo

May 6 2019

Tombolano created T222649: URLs are shown as strings (i.e., not linked) in tables .
May 6 2019, 6:22 PM · MediaWiki-extensions-Cargo
Tombolano added a watcher for MediaWiki-extensions-Cargo: Tombolano.
May 6 2019, 12:47 AM
Tombolano updated Tombolano.
May 6 2019, 12:44 AM
Tombolano added a watcher for MediaWiki-extensions-Page_Forms: Tombolano.
May 6 2019, 12:41 AM