Page MenuHomePhabricator

DovAlp (DovAlp)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 23 2018, 2:22 PM (195 w, 1 d)
Availability
Available
LDAP User
DovAlp
MediaWiki User
DovAlp [ Global Accounts ]

Recent Activity

May 10 2019

DovAlp added a comment to T221974: apierror-unknownerror/qqq is out of date.

Ill give this a go.

May 10 2019, 10:29 PM · User-Kizule, Africa-Wikimedia-Developers, good first task, I18n, MediaWiki-Documentation, MediaWiki-API
DovAlp added a comment to T163394: Vector should mark language-neutral blockquotes.

I'll give this a try! Let me see what I can do.

May 10 2019, 3:50 PM · Google-Code-in-2018, good first task, UI-Standardization-Kanban, UI-Standardization, Design

Mar 14 2019

DovAlp added a comment to T190285: ApiEditPage.php assumes that higher revision numbers have later timestamps.

I can take a look at includes/EditPage.php later, but the original problem/tests have been fixed by my latest patch set. Let me know what you think.

Mar 14 2019, 3:20 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), good first task, MediaWiki-API, MediaWiki-Page-editing

Apr 30 2018

DovAlp added a comment to T190285: ApiEditPage.php assumes that higher revision numbers have later timestamps.

Simetrical, did the tests ever get changed. The code is edited but now the test suite is failing. The new tests should probably get merged in first.

Apr 30 2018, 7:41 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), good first task, MediaWiki-API, MediaWiki-Page-editing

Apr 29 2018

DovAlp added a comment to T187283: Improve ping limiter error message.
Apr 29 2018, 12:13 AM · MediaWiki-Authentication-and-authorization, good first task, MediaWiki-Interface

Apr 27 2018

DovAlp added a comment to T190285: ApiEditPage.php assumes that higher revision numbers have later timestamps.

The code in question is wrapped in a another block

                if ( $params['undoafter'] > 0 ) {
	          if ( $params['undo'] < $params['undoafter'] ) {
		    list( $params['undo'], $params['undoafter'] ) =
		    [ $params['undoafter'], $params['undo'] ];
		  }
		  $undoafterRev = Revision::newFromId( $params['undoafter'] );
		}

It seems all that code does is create this problem. I'll submit a patch to get rid of it now.

Apr 27 2018, 11:39 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), good first task, MediaWiki-API, MediaWiki-Page-editing