Nacc (Nacc)
User

Projects

User does not belong to any projects.

Calendar

User Details

User Since: Feb 27 2018, 11:12 PM (321 w, 5 d)
Availability: Available
LDAP User: Nacc
MediaWiki User: Unknown

Recent Activity
View All

Feb 28 2018

Nacc added a comment to T186240: Clarify handling of integer array indexes in Scribunto and php-luasandbox.

@Anomie: you are totally right, sorry, I misread what the block was trying to protect.

Feb 28 2018, 8:44 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), LuaSandbox, Scribunto

Nacc added a comment to T188467: php-luasandbox self-tests are failing on Ubuntu Bionic (18.04) on 32-bit architectures (i386 and armhf).

@Legoktm: glad to help! I'll sync that Ubuntu (well it should autosync before Feature Freeze I think) once it's published in Debian.

Feb 28 2018, 7:48 PM · LuaSandbox

Nacc added a comment to T188467: php-luasandbox self-tests are failing on Ubuntu Bionic (18.04) on 32-bit architectures (i386 and armhf).

@Legoktm: thanks! I tested locally in a i386 Bionic LXD and the tests pass now (they failed before).

Feb 28 2018, 6:24 PM · LuaSandbox

Nacc added a comment to T188467: php-luasandbox self-tests are failing on Ubuntu Bionic (18.04) on 32-bit architectures (i386 and armhf).

@Legoktm: thank you for the clarification!
@Anomie: that is a good catch!

Feb 28 2018, 5:08 PM · LuaSandbox

Feb 27 2018

Nacc created T188467: php-luasandbox self-tests are failing on Ubuntu Bionic (18.04) on 32-bit architectures (i386 and armhf).

Feb 27 2018, 11:29 PM · LuaSandbox

Nacc added a comment to T186240: Clarify handling of integer array indexes in Scribunto and php-luasandbox.

I'm looking at https://github.com/wikimedia/mediawiki-php-luasandbox/commit/122132a8a00fc373d359cf6beb831b5fdc040e72 and I don't see how the else blocks are correct.

Feb 27 2018, 11:14 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), LuaSandbox, Scribunto