Page MenuHomePhabricator

Android Citation pane

Authored By
RHo, Jul 24 2017
Referenced Files
F8832128: Article - citation - Light.png
Jul 24 2017, 1:27 PM
F8832136: Article - citation multiple - Light.png
Jul 24 2017, 1:27 PM
F8832147: Article - citation multiple - Dark.png
Jul 24 2017, 1:27 PM
F8832133: Article - citation - Dark.png
Jul 24 2017, 1:27 PM

Mock History

Current Revision

Event Timeline

@Sharvaniharan -- am afk till Monday so can provide Zeplin links then. In the meantime if you want to get going, note this should just use the existing bottom sheet and pagination dot components that already exist in the app..

No worries @RHo I have used existing components, but need a few heights and stuff... we can discuss Monday. Thanks :)

actually @Sharvaniharan - these were on Zeplin already - just do a search under "citation"

@RHo changes are complete and a patch is available for review here :
However, since the supporting page library PR is still not merged and published, you will not be able to verify it by checking out the patch and running as-is. So, just to get us started I have taken a few key screenshots here : . Please let me know if they need any design changes. Also, a question:
I am using the material_theme_shadow color theme for the unselected dot indicators at the bottom, which is : light: black26, dark: base10, and black: base10. However, it looks different from the zeplin mock. It looks like whte40? which we don't have in our palette at all. However, I used that and took one screenshot: which looks like the mock. So just wondering what it should be?