Maniphest T100069

added_lines include whitespace at the beginning
Closed, ResolvedPublic
Actions

Description

Since 1.26wmf6 (I can't find which change caused that if any) added_lines include whitespace after line breaks and at the beginning of the string. Happens also on removed_lines and edit_diff. Doesn't happen on wikitext variables.

This has broken eg. important filter #432 on English Wikipedia and possibly more filters which check these strings.

See also

T42478: AbuseFilter needs regression tests

Details

	Subject	Repo	Branch	Lines +/-
	Make the output of UnifiedDiffFormatter match diff -u	mediawiki/core	wmf/1.26wmf7	+10 -0
	Make the output of UnifiedDiffFormatter match diff -u	mediawiki/core	master	+10 -0

Customize query in gerrit

Related Objects

Mentioned In: rMWd95cac90c70f: Make the output of UnifiedDiffFormatter match diff -u
rMW066fcb80a1e7: Make the output of UnifiedDiffFormatter match diff -u
T42478: AbuseFilter needs regression tests
T74329: "added_lines" is not in "new_wikitext" anymore and causes false positives
Mentioned Here: T42478: AbuseFilter needs regression tests

Event Timeline

matej_suchanek created this task.May 23 2015, 9:48 AM

matej_suchanek raised the priority of this task from to Needs Triage.

matej_suchanek updated the task description. (Show Details)

matej_suchanek added a project: AbuseFilter.

matej_suchanek subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2015, 9:48 AM

Ciencia_Al_Poder mentioned this in T74329: "added_lines" is not in "new_wikitext" anymore and causes false positives.May 23 2015, 9:53 AM

Dalba subscribed.May 23 2015, 10:29 AM

He7d3r subscribed.May 23 2015, 6:31 PM

He7d3r updated the task description. (Show Details)May 23 2015, 6:51 PM

He7d3r set Security to None.

He7d3r mentioned this in T42478: AbuseFilter needs regression tests.

Change 213773 had a related patch set uploaded (by Ori.livneh):
Make the output of UnifiedDiffFormatter match diff -u

https://gerrit.wikimedia.org/r/213773

gerritbot added a project: Patch-For-Review.May 26 2015, 1:41 AM

• MZMcBride subscribed.May 26 2015, 2:18 AM

Change 213773 merged by Aaron Schulz:
Make the output of UnifiedDiffFormatter match diff -u

https://gerrit.wikimedia.org/r/213773

ori mentioned this in rMW066fcb80a1e7: Make the output of UnifiedDiffFormatter match diff -u.May 26 2015, 2:38 AM

Change 213775 had a related patch set uploaded (by Ori.livneh):
Make the output of UnifiedDiffFormatter match diff -u

https://gerrit.wikimedia.org/r/213775

https://gerrit.wikimedia.org/r/213773 (branch master): MW-1.26-release, WMF-deploy-2015-05-27_(1.26wmf8)

Billinghurst closed this task as a duplicate of T100499: added_lines and removed_lines now incorrectly start with a space.May 27 2015, 10:13 AM

Se4598 reopened this task as Open.May 27 2015, 10:29 AM

Se4598 merged a task: T100499: added_lines and removed_lines now incorrectly start with a space.

Se4598 added subscribers: Billinghurst, Nirmos.

Se4598 subscribed.

He7d3r triaged this task as Unbreak Now! priority.May 27 2015, 10:58 AM

https://gerrit.wikimedia.org/r/#/c/213775/ failed Jenkins... @ori: Any plans to fix that?

Change 213775 merged by Ori.livneh:
Make the output of UnifiedDiffFormatter match diff -u

https://gerrit.wikimedia.org/r/213775

ori mentioned this in rMWd95cac90c70f: Make the output of UnifiedDiffFormatter match diff -u.May 29 2015, 12:06 AM

ori closed this task as Resolved.May 29 2015, 12:11 AM

ori claimed this task.

Jdforrester-WMF added a project: WMF-deploy-2015-05-20_(1.26wmf7).Jun 10 2015, 2:04 AM

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM