Rename JavaScript modules to reflect their location
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bmansurov
	May 26 2015, 11:18 PM

Description

If you are new to MobileFrontend then is a great task to start on and get familiar with it!

Now that the resources files have been moved to the resources folder, it makes sense to change old module names too. For example, modules/search/SearchApi should be renamed to mobile.search.api/SearchApi, etc. (the text before the / is the name of the ResourceLoader module and the text after it the name of the class).
Old names should be deprecated like
M.define( 'mobile.search.api/SearchApi' ).deprecate( 'modules/search/SearchApi' )

Be careful to correctly deprecate modules as some other exntensions may be using them.

Details

	Subject	Repo	Branch	Lines +/-
	Rename modules in resources	mediawiki/extensions/MobileFrontend	master	+520 -473

Customize query in gerrit

Related Objects

Mentioned In: T115585: Outreachy proposal for : Improving static analysis tools for MediaWiki
T110718: Use core API code - reduce size of JS assets sent to mobile users
rMEXT206e2b7afe62: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFRc322c8f94288: Rename modules in resources
T103727: Empty message on watchlists is not center aligned.

Event Timeline

• bmansurov created this task.May 26 2015, 11:18 PM

• bmansurov raised the priority of this task from to Needs Triage.

• bmansurov updated the task description. (Show Details)

• bmansurov added a project: Web-Team-Backlog.

• bmansurov subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2015, 11:18 PM

Jdlrobson updated the task description. (Show Details)May 27 2015, 7:09 AM

Jdlrobson set Security to None.

Jdlrobson awarded a token.

Jdlrobson updated the task description. (Show Details)

phuedx awarded a token.May 28 2015, 1:43 PM

phuedx moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson updated the task description. (Show Details)Aug 14 2015, 12:06 AM

Jdlrobson added projects: good first task, Mobile, MobileFrontend.

Jdlrobson mentioned this in T103727: Empty message on watchlists is not center aligned..Aug 24 2015, 6:39 PM

Jdlrobson triaged this task as Lowest priority.Sep 8 2015, 12:28 AM

Jdlrobson subscribed.

Could someone assign this to me please (I cannot assign myself)

Change 237969 had a related patch set uploaded (by TasneemLo):
Rename modules in resources

https://gerrit.wikimedia.org/r/237969

gerritbot added a project: Patch-For-Review.Sep 13 2015, 4:54 AM

The above patch is a demo for the modules/search/SearchApi. Is this fine ? Or did I miss something ?

If it's fine, I'll continue and finish up the rest. Would you like different commit for each resource ? Or a single commit with all of them changed ?

Note: I used find . -type f -exec sed -i "s%'modules/search/SearchApi'%'mobile.search/SearchApi'%g" {} \; to make sure I didn't miss out any occurence.

Hi @TasneemLo! Like I wrote in the change, I'm pretty sure, that you understood the problem and your change looks good (except one little confusion from our side! :P). I'm not sure, how much changes in the code are needed. I would suggest to made them all in one commit (in the hope, that there aren't too much changed names).

To the mobile.search/SearchApi or mobile.search.api/SearchApi you should use mobile.search.api/SearchApi. This task was created before we moved the SearchApi to it's own module :)

Florian updated the task description. (Show Details)Sep 13 2015, 11:36 AM

Florian closed this task as Resolved.Sep 17 2015, 5:50 PM

Change 237969 merged by jenkins-bot:
Rename modules in resources

https://gerrit.wikimedia.org/r/237969

TasneemLo mentioned this in rEMFRc322c8f94288: Rename modules in resources.Sep 17 2015, 6:12 PM

Diffusion mentioned this in rMEXT206e2b7afe62: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 17 2015, 6:12 PM

ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 17 2015, 7:00 PM

Jdlrobson mentioned this in T110718: Use core API code - reduce size of JS assets sent to mobile users.Sep 17 2015, 7:23 PM

TasneemLo mentioned this in T115585: Outreachy proposal for : Improving static analysis tools for MediaWiki.Oct 15 2015, 12:57 PM

• Phabricator_maintenance moved this task from Triaged but Future to 2015-16 Q1 on the Web-Team-Backlog board.Mar 7 2018, 1:11 AM