Error introduced in recent #tag:ref change, breaks nested refs in enwp
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	czar
	May 26 2015, 11:50 PM

Description

enwp's nested template ({{:en:refn}}) broke with a recent change that we've traced back to "#tag:ref". Instances of nested refs now dump the nested refs at the bottom of the page instead of in the original reflist where they once displayed. For example, see [[:en:Fez (video game)]] or [[:en:Albany Free School]]

Could someone help us figure out what recent Mediawiki change caused this or what our next steps should be?

More information available at [[:en:Template talk:Refn#Refn references getting sent to the bottom of the page?]]

Thanks

Details

Subject	Repo	Branch	Lines +/-
Parse references as we go	mediawiki/extensions/Cite	master	+175 -74
Revert "Do all of Cite's real work during unstrip" and followup	mediawiki/extensions/Cite	wmf/1.26wmf8	+168 -71
Revert "Do all of Cite's real work during unstrip" and followup	mediawiki/extensions/Cite	master	+168 -71

Customize query in gerrit

Revisions and Commits

rMEXT MediaWiki Extensions
	rMEXT2b2ab0a29649 Updated mediawiki/extensions Project: mediawiki/extensions/Cite…
rECIT extension-Cite
	rECIT071351374fea Revert "Do all of Cite's real work during unstrip" and followup
	rECIT7af2f4443e05 Revert "Do all of Cite's real work during unstrip" and followup
	rECIT3f30e08d7752 Revert "Do all of Cite's real work during unstrip" and followup

Related Objects

Mentioned In: T101390: <ref> in section headings shown as raw text in TOC
T22707: Nested refs fail inside references block
Mentioned Here: T101390: <ref> in section headings shown as raw text in TOC
T22707: Nested refs fail inside references block
T68860: Cite: If there's no <references /> block on the page, show one automatically below the content rather than showing an error

Event Timeline

czar created this task.May 26 2015, 11:50 PM

czar raised the priority of this task from to Needs Triage.

czar updated the task description. (Show Details)

czar subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2015, 11:50 PM

czar renamed this task from Error introduced in recent #tag:ref change to Error introduced in recent #tag:ref change, breaks nested refs in enwp.May 27 2015, 12:00 AM

czar updated the task description. (Show Details)

czar set Security to None.

It's not exactly recent, but: T68860: Cite: If there's no <references /> block on the page, show one automatically below the content rather than showing an error

AIUI, the automatic showing of an undisplayed reflist is not a problem. With no group specified, the #tag:refs and the plain <ref>s used to be added to the same reflist. It appears this is no longer the case.

Change 214116 had a related patch set uploaded (by Jackmcbarn):
Parse references as we go

https://gerrit.wikimedia.org/r/214116

gerritbot added a project: Patch-For-Review.May 27 2015, 7:20 PM

T22707 might be related

StarryGrandma subscribed.May 31 2015, 6:19 PM

New here, apologies in advance for not getting things right...

There are a couple of referencing errors on "C (programming language)" on enwiki that appear to be related to nested references via the refn template. For example, {{refn|Page 3 of the original K&R<ref name="k&re />}} seems to generate the cite error. I think this may be related to this problem.

Change 216688 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216688

matmarex mentioned this in T101390: <ref> in section headings shown as raw text in TOC.Jun 8 2015, 2:30 PM

There is a wider discussion on T101390, which seems to be a different problem with the same cause. This should get fixed when the revert above is deployed today.

Change 216688 merged by jenkins-bot:
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216688

matmarex closed this task as Resolved by committing rECIT3f30e08d7752: Revert "Do all of Cite's real work during unstrip" and followup.Jun 8 2015, 3:06 PM

matmarex added a commit: rECIT3f30e08d7752: Revert "Do all of Cite's real work during unstrip" and followup.

matmarex added a commit: rMEXT2b2ab0a29649: Updated mediawiki/extensions Project: mediawiki/extensions/Cite….

Change 216711 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216711

Change 216711 merged by jenkins-bot:
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216711

matmarex added a commit: rECIT7af2f4443e05: Revert "Do all of Cite's real work during unstrip" and followup.Jun 8 2015, 3:10 PM

In T100477#1340361, @Rwessel wrote:

New here, apologies in advance for not getting things right...

There are a couple of referencing errors on "C (programming language)" on enwiki that appear to be related to nested references via the refn template. For example, {{refn|Page 3 of the original K&R<ref name="k&re />}} seems to generate the cite error. I think this may be related to this problem.

FYI: The problem on "C (programming language)" seems to have cleared up.

Jdforrester-WMF assigned this task to matmarex.Jun 10 2015, 2:12 AM

Jdforrester-WMF added a project: WMF-deploy-2015-05-27_(1.26wmf8).

Change 214116 abandoned by Jackmcbarn:
Parse references as we go

Reason:
Until its dependency comes back

https://gerrit.wikimedia.org/r/214116

matmarex added a commit: rECIT071351374fea: Revert "Do all of Cite's real work during unstrip" and followup.Apr 28 2016, 2:00 AM