Page MenuHomePhabricator
Create Task
Maniphest T101390

<ref> in section headings shown as raw text in TOC
Closed, ResolvedPublic
Actions

Description

Reported by <rotpunkt> on #wikimedia-dev.

<rotpunkt> Hi, there is a bug with tag ref, see table of content in http://en.wikipedia.org/wiki/Ambernac.
<andre> An ?action=purge on https://en.wikipedia.org/wiki/Allenwiller shows the same error now.
<rotpunkt> andre after refreshing the cache (action=purge) the problem is also there
<anomie> At a quick check, it looks like https://gerrit.wikimedia.org/r/#/c/181112/ slightly changed the behavior of <ref> in headings, and https://gerrit.wikimedia.org/r/#/c/213313/ really changed it in response to T99787

Details

SubjectRepoBranchLines +/-
Revert "Do all of Cite's real work during unstrip" and followupmediawiki/extensions/Citewmf/1.26wmf8+168 -71
Revert "Do all of Cite's real work during unstrip" and followupmediawiki/extensions/Citemaster+168 -71
Customize query in gerrit

Revisions and Commits

rMEXT MediaWiki Extensions
rMEXT2b2ab0a29649 Updated mediawiki/extensions Project: mediawiki/extensions/Cite…
rECIT extension-Cite
rECIT071351374fea Revert "Do all of Cite's real work during unstrip" and followup
rECIT7af2f4443e05 Revert "Do all of Cite's real work during unstrip" and followup
rECIT3f30e08d7752 Revert "Do all of Cite's real work during unstrip" and followup

Related Objects

Event Timeline

Aklapper created this task.Jun 4 2015, 1:29 PM
Aklapper raised the priority of this task from to High.
Aklapper updated the task description. (Show Details)
Aklapper added a project: Cite.
Aklapper mentioned this in T99787: Call to template can duplicate ref tag contents when using <h3>.
Aklapper added subscribers: Aklapper, Rotpunkt, Jackmcbarn, tstarling.
Bultro subscribed.Jun 4 2015, 8:07 PM
Aklapper added projects: MediaWiki-Parser, MediaWiki-User-Interface, Regression.Jun 5 2015, 12:36 PM
Aklapper set Security to None.
Aklapper merged a task: T101509: Source of ref-tag is visable in ToC.
Aklapper added subscribers: matmarex, Josve05a.
TTO added subscribers: TTO, Anomie.Jun 5 2015, 12:38 PM
Aklapper mentioned this in T101509: Source of ref-tag is visable in ToC.Jun 5 2015, 12:38 PM
Krenair subscribed.Jun 7 2015, 3:47 PM
Ricordisamoa subscribed.Jun 7 2015, 3:53 PM
Isarra subscribed.Jun 7 2015, 4:24 PM

Sounds like how bolds and italics in the headers apply to the toc, too, and any random html just shows up as source.

TheDJ subscribed.Jun 7 2015, 5:23 PM

Hmm, i think we have a similar problem with inline images that have references that are being put into the alt attribute. This is affecting quite a few images I suspect:

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=665912801#Phantom_citations

Aklapper added a subscriber: greg.Jun 7 2015, 10:31 PM

Who in the MediaWiki Parser or Cite land could investigate this, as it gets more and more exposure on Village Pumps (e.g. de.wp)?

doctaxon subscribed.Jun 8 2015, 12:51 AM
matmarex added a comment.Jun 8 2015, 1:05 AM

If nobody has a solution ready right now, it might be better to revert the two patches (https://gerrit.wikimedia.org/r/#/c/181112/ and https://gerrit.wikimedia.org/r/#/c/213313/). It seems that this is a pretty complicated issue (as indicated by the follow-up patch introducing new weirdnesses itself). Doing that will regress some old issues (mostly related to nested refs; linked on the changesets, see also recently closed tasks in Cite), but they are generally rare in practice and already well-known and documented (e.g. https://en.wikipedia.org/wiki/Wikipedia:Nesting_footnotes#What_does_not_work). Right now we have new and exciting bugs and features which are badly reacting with existing articles.

Let's take this opportunity to expand the test suite with newly discovered cases and try the patches again afterwards?

Aklapper added a comment.Jun 8 2015, 10:57 AM

@Jackmcbarn: Any comments?

TheDJ added a comment.Jun 8 2015, 12:54 PM

To me this sounds like revert, swat deploy, write testcases, try again....

• Elitre subscribed.Jun 8 2015, 1:03 PM
He7d3r subscribed.Jun 8 2015, 2:18 PM
gerritbot subscribed.Jun 8 2015, 2:19 PM

Change 216688 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216688

gerritbot added a project: Patch-For-Review.Jun 8 2015, 2:19 PM
matmarex added a comment.Jun 8 2015, 2:30 PM

The revert will probably also fix T100477, which I just found. There is a pending patch there (https://gerrit.wikimedia.org/r/214116), but it has been stuck for a week and I doubt anyone's comfortable deploying it rather than doing a revert.

matmarex mentioned this in T100477: Error introduced in recent #tag:ref change, breaks nested refs in enwp.Jun 8 2015, 2:36 PM
gerritbot added a comment.Jun 8 2015, 3:06 PM

Change 216688 merged by jenkins-bot:
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216688

matmarex closed this task as Resolved by committing rECIT3f30e08d7752: Revert "Do all of Cite's real work during unstrip" and followup.Jun 8 2015, 3:06 PM
matmarex added a commit: rECIT3f30e08d7752: Revert "Do all of Cite's real work during unstrip" and followup.
matmarex added a commit: rMEXT2b2ab0a29649: Updated mediawiki/extensions Project: mediawiki/extensions/Cite….
gerritbot added a comment.Jun 8 2015, 3:09 PM

Change 216711 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216711

gerritbot added a comment.Jun 8 2015, 3:10 PM

Change 216711 merged by jenkins-bot:
Revert "Do all of Cite's real work during unstrip" and followup

https://gerrit.wikimedia.org/r/216711

matmarex added a commit: rECIT7af2f4443e05: Revert "Do all of Cite's real work during unstrip" and followup.Jun 8 2015, 3:10 PM
MGChecker subscribed.Jun 8 2015, 4:12 PM
• Elitre awarded a token.Jun 9 2015, 3:48 PM
Jdforrester-WMF added a project: WMF-deploy-2015-05-27_(1.26wmf8).Jun 10 2015, 2:12 AM
matmarex added a commit: rECIT071351374fea: Revert "Do all of Cite's real work during unstrip" and followup.Apr 28 2016, 1:59 AM
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptApr 28 2016, 2:00 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL