Page MenuHomePhabricator

Regression: Valid maps data with citoid field/ template data type mismatch causes a js error/ endless pending
Closed, ResolvedPublic

Description

Steps to reproduce:

Change template data structure in a way that doesn't match citoid's data structure, i.e. "isbn" : "isbn" instead of the correct "issn": ["issn"]

Attempt to add citation which uses that field, i.e. http://www.ncbi.nlm.nih.gov/pmc/articles/PMC2841828/

Error is:

TypeError: input.match is not a function

in

ve.dm.MWTransclusionNode.static.escapeParameter

line 172

Event Timeline

Mvolz created this task.May 28 2015, 12:51 PM
Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added projects: Citoid, VisualEditor.
Mvolz moved this task to Extension on the Citoid board.
Mvolz added subscribers: Mvolz, Esanders.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 12:51 PM

Change 214340 had a related patch set uploaded (by Mvolz):
Check templateField type

https://gerrit.wikimedia.org/r/214340

Mvolz claimed this task.May 28 2015, 2:18 PM
Mvolz set Security to None.

Change 214340 merged by jenkins-bot:
Check templateField type & add QUnit tests

https://gerrit.wikimedia.org/r/214340

Mvolz closed this task as Resolved.Jun 23 2015, 9:43 AM