Maniphest T100651

Regression: Valid maps data with citoid field/ template data type mismatch causes a js error/ endless pending
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mvolz
	May 28 2015, 12:51 PM

Tags

Referenced Files

None

Subscribers

Description

Steps to reproduce:

Change template data structure in a way that doesn't match citoid's data structure, i.e. "isbn" : "isbn" instead of the correct "issn": ["issn"]

Attempt to add citation which uses that field, i.e. http://www.ncbi.nlm.nih.gov/pmc/articles/PMC2841828/

Error is:

TypeError: input.match is not a function

in

ve.dm.MWTransclusionNode.static.escapeParameter

line 172

Details

	Subject	Repo	Branch	Lines +/-
	Check templateField type & add QUnit tests	mediawiki/extensions/Citoid	master	+2 K -12

Customize query in gerrit

Related Objects

Mentioned In: rECEXc8ca892de0be: Check templateField type & add QUnit tests
rMEXT25e5ac318239: Updated mediawiki/extensions Project: mediawiki/extensions/Citoid…

Event Timeline

Mvolz created this task.May 28 2015, 12:51 PM

Mvolz raised the priority of this task from to Needs Triage.

Mvolz updated the task description. (Show Details)

Mvolz added projects: Citoid, VisualEditor.

Mvolz moved this task to Extension on the Citoid board.

Mvolz added subscribers: Mvolz, Esanders.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 12:51 PM

Change 214340 had a related patch set uploaded (by Mvolz):
Check templateField type

https://gerrit.wikimedia.org/r/214340

gerritbot added a project: Patch-For-Review.May 28 2015, 2:09 PM

Mvolz claimed this task.May 28 2015, 2:18 PM

Mvolz set Security to None.

Change 214340 merged by jenkins-bot:
Check templateField type & add QUnit tests

https://gerrit.wikimedia.org/r/214340

Mvolz mentioned this in rMEXT25e5ac318239: Updated mediawiki/extensions Project: mediawiki/extensions/Citoid….Jun 15 2015, 3:49 PM

Mvolz mentioned this in rECEXc8ca892de0be: Check templateField type & add QUnit tests.

https://gerrit.wikimedia.org/r/214340 (branch master): WMF-deploy-2015-06-16_(1.26wmf10)

Mvolz removed a project: Patch-For-Review.Jun 15 2015, 6:30 PM

Mvolz closed this task as Resolved.Jun 23 2015, 9:43 AM

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jun 30 2015, 12:50 AM

Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.Jul 18 2015, 11:34 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2015/16 Q1 blockers board.

Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.Aug 5 2015, 1:23 AM