Page MenuHomePhabricator
Create Task
Maniphest T101966

Remove use of label "hasSlaveScripts" in jobs
Closed, ResolvedPublic
Actions

Description

hasSlaveScripts should also be available on labs slaves, not only production slaves. It seems the scripts are there but the slaves are not tagged that way. Perhaps the solution is to remove the tag if every slave has them.

To find all such jobs:

ssh gallium.wikimedia.org 'grep -l hasSlaveScripts /var/lib/jenkins/jobs/*/config.xml|cut -d\/ -f6'

That is all the -jslint jobs and:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

JanZerebecki created this task.Jun 10 2015, 10:18 AM
JanZerebecki raised the priority of this task from to Needs Triage.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added a project: Continuous-Integration-Infrastructure.
JanZerebecki subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2015, 10:18 AM
hashar subscribed.Jun 10 2015, 11:08 AM

Yeah that is a leftover of when the slaves did not have a clone of integration/jenkins.git. It is part of T86659: Migrate all jobs to labs slaves

hashar added a parent task: T86659: Migrate all jobs to labs slaves.EditedJun 10 2015, 11:08 AM

grep -l hasSlaveScripts yields jobs still having it. Updating task details with the list.

hashar updated the task description. (Show Details)Jun 10 2015, 11:14 AM
hashar set Security to None.
gerritbot subscribed.Jun 10 2015, 11:15 AM

Change 217249 had a related patch set uploaded (by Hashar):
Migrate operations-puppet-{pep8,test} to labs

https://gerrit.wikimedia.org/r/217249

gerritbot added a project: Patch-For-Review.Jun 10 2015, 11:15 AM
hashar updated the task description. (Show Details)Jun 10 2015, 11:16 AM
hashar moved this task from Untriaged to Next on the Continuous-Integration-Infrastructure board.
gerritbot added a comment.Jun 10 2015, 11:18 AM

Change 217249 merged by jenkins-bot:
Migrate operations-puppet-{pep8,test} to labs

https://gerrit.wikimedia.org/r/217249

hashar triaged this task as Medium priority.Jun 10 2015, 11:19 AM
hashar removed a project: Patch-For-Review.
hashar mentioned this in rCICFd57ae0c0a277: Migrate operations-puppet-{pep8,test} to labs.Jun 10 2015, 11:20 AM
Krinkle renamed this task from hasSlaveScripts should also be available on labs slaves to Remove use of label "hasSlaveScripts" in jobs.Jun 10 2015, 9:46 PM
Krinkle edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure.
Krinkle subscribed.EditedJun 10 2015, 9:49 PM

In the past, hasSlaveScripts was the only label to ensure jobs run on production slaves (without hardcoding individual slave hosts). We now have productionSlaves for this purpose.

Any jobs left on production slaves after T86659 should probably be tied with gallium. Aside from things specifically running on gallium (e.g. publisher) I don't think we have any use cases for production slaves.

gerritbot added a comment.Jun 11 2015, 1:15 PM

Change 217503 had a related patch set uploaded (by Hashar):
Migrate perllint to labs and rm hasSlaveScripts

https://gerrit.wikimedia.org/r/217503

gerritbot added a project: Patch-For-Review.Jun 11 2015, 1:15 PM
hashar updated the task description. (Show Details)Jun 11 2015, 1:16 PM
gerritbot added a comment.Jun 11 2015, 1:17 PM

Change 217503 merged by jenkins-bot:
Migrate perllint to labs and rm hasSlaveScripts

https://gerrit.wikimedia.org/r/217503

hashar mentioned this in rCICF514ed501eb6f: Migrate perllint to labs and rm hasSlaveScripts.Jun 11 2015, 1:18 PM
gerritbot added a comment.Jun 11 2015, 1:22 PM

Change 217504 had a related patch set uploaded (by Hashar):
Migrate pplint-HEAD to labs and rm hasSlaveScripts

https://gerrit.wikimedia.org/r/217504

hashar updated the task description. (Show Details)Jun 11 2015, 1:22 PM
gerritbot added a comment.Jun 11 2015, 1:24 PM

Change 217504 merged by jenkins-bot:
Migrate pplint-HEAD to labs and rm hasSlaveScripts

https://gerrit.wikimedia.org/r/217504

hashar mentioned this in rCICFbf7935e5c9a9: Migrate pplint-HEAD to labs and rm hasSlaveScripts.Jun 11 2015, 1:24 PM
hashar updated the task description. (Show Details)Jul 1 2015, 1:54 PM
gerritbot added a comment.Jul 1 2015, 1:58 PM

Change 222115 had a related patch set uploaded (by Hashar):
Migrate jshint/jsonlint/jslint jobs to wmflabs

https://gerrit.wikimedia.org/r/222115

hashar updated the task description. (Show Details)Jul 1 2015, 1:58 PM
hashar updated the task description. (Show Details)Jul 1 2015, 2:02 PM
gerritbot added a comment.Jul 1 2015, 2:05 PM

Change 222115 merged by jenkins-bot:
Migrate jshint/jsonlint/jslint jobs to wmflabs

https://gerrit.wikimedia.org/r/222115

hashar mentioned this in rCICF218a10f8e530: Migrate jshint/jsonlint/jslint jobs to wmflabs.Jul 1 2015, 2:05 PM
gerritbot added a comment.Jul 1 2015, 2:55 PM

Change 222123 had a related patch set uploaded (by Hashar):
Migrate {name}-phpcs-HEAD to Precise labs

https://gerrit.wikimedia.org/r/222123

gerritbot added a comment.Jul 1 2015, 3:13 PM

Change 222123 merged by jenkins-bot:
Migrate {name}-phpcs-HEAD to Precise labs

https://gerrit.wikimedia.org/r/222123

hashar mentioned this in rCICFfb519885f0c3: Migrate {name}-phpcs-HEAD to Precise labs.Jul 1 2015, 3:13 PM
hashar updated the task description. (Show Details)Jul 1 2015, 3:30 PM
hashar updated the task description. (Show Details)Jul 2 2015, 10:49 AM
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptJul 2 2015, 10:49 AM
hashar added a comment.EditedJul 2 2015, 10:49 AM

Current status:

$ ssh gallium.wikimedia.org 'grep -l hasSlaveScripts /var/lib/jenkins/jobs/*/config.xml|cut -d\/ -f6'
erblint-HEAD
mediawiki-core-jslint
mediawiki-core-phpcs
mediawiki-core-whitespaces
mwext-CirrusSearch-whitespaces
parsoidsvc-php-parsertests
hashar updated the task description. (Show Details)Jul 2 2015, 10:53 AM
gerritbot added a comment.Jul 2 2015, 12:09 PM

Change 222280 had a related patch set uploaded (by Hashar):
Migrate whitespaces jobs to labs (on Trusty)

https://gerrit.wikimedia.org/r/222280

hashar updated the task description. (Show Details)Jul 2 2015, 12:09 PM
gerritbot added a comment.Jul 2 2015, 12:12 PM

Change 222280 merged by jenkins-bot:
Migrate whitespaces jobs to labs (on Trusty)

https://gerrit.wikimedia.org/r/222280

hashar mentioned this in rCICFe73ee67ec615: Migrate whitespaces jobs to labs (on Trusty).Jul 2 2015, 12:12 PM
gerritbot added a comment.Jul 2 2015, 12:14 PM

Change 222281 had a related patch set uploaded (by Hashar):
Migrate 'mediawiki-core-jslint to labs (on Trusty)

https://gerrit.wikimedia.org/r/222281

hashar updated the task description. (Show Details)Jul 2 2015, 12:15 PM
hashar updated the task description. (Show Details)
gerritbot added a comment.Jul 2 2015, 12:17 PM

Change 222281 merged by jenkins-bot:
Migrate mediawiki-core-jslint to labs (on Trusty)

https://gerrit.wikimedia.org/r/222281

hashar mentioned this in rCICF29d7023ab678: Migrate mediawiki-core-jslint to labs (on Trusty).Jul 2 2015, 12:17 PM
gerritbot added a comment.Jul 2 2015, 12:18 PM

Change 222282 had a related patch set uploaded (by Hashar):
Stop generating mediawiki-core-phpcs (ununsed)

https://gerrit.wikimedia.org/r/222282

hashar updated the task description. (Show Details)Jul 2 2015, 12:18 PM
gerritbot added a comment.Jul 2 2015, 12:20 PM

Change 222282 merged by jenkins-bot:
Stop generating mediawiki-core-phpcs (ununsed)

https://gerrit.wikimedia.org/r/222282

hashar mentioned this in rCICF37b0ed613ea7: Stop generating mediawiki-core-phpcs (ununsed).Jul 2 2015, 12:20 PM
gerritbot added a comment.Jul 2 2015, 12:24 PM

Change 222283 had a related patch set uploaded (by Hashar):
Migrate erblint-HEAD to labs slave (still on Precise)

https://gerrit.wikimedia.org/r/222283

hashar updated the task description. (Show Details)Jul 2 2015, 12:25 PM
gerritbot added a comment.Jul 2 2015, 12:26 PM

Change 222283 merged by jenkins-bot:
Migrate erblint-HEAD to labs slave (still on Precise)

https://gerrit.wikimedia.org/r/222283

hashar mentioned this in rCICF7f6a083b9a02: Migrate erblint-HEAD to labs slave (still on Precise).Jul 2 2015, 12:26 PM
gerritbot added a comment.Jul 3 2015, 12:49 PM

Change 222577 had a related patch set uploaded (by Hashar):
Migrate parsoidsvc-php-parsertests to labs

https://gerrit.wikimedia.org/r/222577

hashar updated the task description. (Show Details)Jul 3 2015, 12:49 PM
gerritbot added a comment.Jul 3 2015, 12:55 PM

Change 222577 merged by jenkins-bot:
Migrate parsoidsvc-php-parsertests to labs

https://gerrit.wikimedia.org/r/222577

hashar mentioned this in rCICF76bf8d048a5e: Migrate parsoidsvc-php-parsertests to labs.Jul 3 2015, 12:55 PM
gerritbot added a comment.Jul 3 2015, 12:57 PM

Change 222579 had a related patch set uploaded (by Hashar):
Remove last occurence of label 'hasSlaveScripts'

https://gerrit.wikimedia.org/r/222579

gerritbot added a comment.Jul 3 2015, 1:00 PM

Change 222579 merged by jenkins-bot:
Remove last occurence of label 'hasSlaveScripts'

https://gerrit.wikimedia.org/r/222579

hashar mentioned this in rCICF126bc0eed04a: Remove last occurence of label 'hasSlaveScripts'.Jul 3 2015, 1:00 PM
hashar closed this task as Resolved.Jul 3 2015, 1:00 PM
hashar claimed this task.

The Jenkins label hasSlaveScripts is now gone !

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL