Page MenuHomePhabricator

The old toolbar is visible while loading
Closed, ResolvedPublic

Description

On CodeEditor the old toolbar is visible while loading. It gets hidden when the new WikiEditor toolbar is loaded.

WikiEditor hides the old toolbar while loading by

/* Hide the old toolbar until the wikiEditor toolbar is deemed not supported,
 * hide the WikiEditor toolbar until it's css has loaded */
.wikiEditor-oldToolbar,
.wikiEditor-ui-toolbar {
	display: none;
}

in file modules/ext.wikiEditor.toolbar.styles.less. This file is loaded by module ext.wikiEditor.toolbar.styles on position top. CodeEditor does not load this module. This also generates T102738.

Event Timeline

Fomafix created this task.Jun 17 2015, 5:22 AM
Fomafix raised the priority of this task from to Low.
Fomafix updated the task description. (Show Details)
Fomafix added a project: CodeEditor.
Fomafix added a subscriber: Fomafix.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2015, 5:22 AM

Change 218820 had a related patch set uploaded (by Gerrit Patch Uploader):
Load module 'ext.wikiEditor.toolbar.styles'

https://gerrit.wikimedia.org/r/218820

Fomafix claimed this task.Jun 17 2015, 5:33 AM

Change 218820 merged by jenkins-bot:
Load module 'ext.wikiEditor.toolbar.styles'

https://gerrit.wikimedia.org/r/218820

TheDJ closed this task as Resolved.Jun 17 2015, 11:07 PM
TheDJ added a subscriber: TheDJ.